1081190 - Using InstallTrigger gets "NS_ERROR_FACTORY_NOT_REGISTERED" error - need to port bug 926712 to TB and IB

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[:Irving Reid (No longer working on Firefox)]

Bug 926712 introduced a change in the implementation of InstallTrigger, the API that allows content to request add-on installation.

The build config changes at https://bugzilla.mozilla.org/attachment.cgi?id=8421181&action=diff#a/browser/installer/package-manifest.in_sec2 need to be ported to Thunderbird (http://dxr.mozilla.org/comm-central/source/mail/installer/package-manifest.in#668) and Instantbird (http://dxr.mozilla.org/comm-central/source/im/installer/package-manifest.in#518)

Comment 1

[:Irving Reid (No longer working on Firefox)]

Might be worth making a thorough pass (and maybe implementing a test), see Seamonkey bug 1019021

Comment 2

[Magnus Melin [:mkmelin]]

Aha! This must be what's causing bug 1049157

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1081190_InstallTriggers.patch

This should be the packaging changes. But it doesn't seem to be enough...

Comment 5

[Frank Wein [:mcsmurf]]

So this issue does not occur with a local build, but with a packaged build only?

Comment 6

[Joe Sabash [:JoeS1]]

(In reply to Frank Wein [:mcsmurf] from comment #5)
> So this issue does not occur with a local build, but with a packaged build
> only?

It seems so, I just installed an extension no prob with a self built trunk TB running without packaging.

Comment 7

[Mark Banner (:standard8)]

Magnus: how about getting the packaging changes landed/reviewed, then see what doesn't work - i.e. errors on the error console or command line on debug builds.

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: bug1081190_InstallTriggers.patch

With this I can install from a test page. 
The dictionary example from bug 1049157 only offers the "Download" option, not the "Add to Thunderbird" so I can't really verify that works, though it probably does, if the page just start offering that alternative again.

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 8536076 [details] [diff] [review]
bug1081190_InstallTriggers.patch

Review of attachment 8536076 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like the right change from the m-c bug. Thanks for tracking this down!

Comment 10

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/4bbe6b265d18 -> FIXED

Comment 11

[Magnus Melin [:mkmelin]]

Comment on attachment 8536076 [details] [diff] [review]
bug1081190_InstallTriggers.patch

[Approval Request Comment]
Regression caused by (bug #): bug 926712 (which landed for firefox31)
User impact if declined: can't install extensions from web pages, and more importantly for thunderbird: can't install dictionaries from web pages either and for those a web page is the primary access point.
Testing completed (on c-c, etc.): landed on trunk. it's unclear if this solves all the problems with installing dictionaries as apparently the mozilla dictionaries web page changed its code
Risk to taking this patch (and alternatives if risky): no risk, just a packaging addition

Comment 12

[Magnus Melin [:mkmelin]]

Ok so with the official nightly build installing dictionaries do works (tried Frisian which is compatible with 37)!

Comment 14

[Shy]

after updating this morning to 31.3 all my extensions stopped working and I now have to re-install them manually from file. I don't understand how Thunderbird was released with this known issue (must have been known beforehand since it appears in the release notes).

Comment 15

[Magnus Melin [:mkmelin]]

Sky: that's not really what this bug is about. It just causes an inability to install new extensions from web pages. That's not such an easy situation to get into in thunderbird... except for with the dictionaries. Your "old" extensions should (usually) be updated automatically or updatable via Tools | Add-ons where you can also search and install extensions just fine.

Comment 16

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/releases/comm-esr31/rev/60630583a7df

Comment 17

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/releases/comm-beta/rev/61965265ed02

Comment 18

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/releases/comm-aurora/rev/5ea55acdc560

(oh well, aurora is 36...)