Closed Bug 1081190 Opened 10 years ago Closed 9 years ago

Using InstallTrigger gets "NS_ERROR_FACTORY_NOT_REGISTERED" error - need to port bug 926712 to TB and IB

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
major

Tracking

(thunderbird35 fixed, thunderbird36 fixed, thunderbird_esr3135+ fixed)

RESOLVED FIXED
Thunderbird 37.0
Tracking Status
thunderbird35 --- fixed
thunderbird36 --- fixed
thunderbird_esr31 35+ fixed

People

(Reporter: Irving, Assigned: mkmelin, Mentored)

References

Details

(Keywords: regression, Whiteboard: [regression:TB31])

Attachments

(1 file, 1 obsolete file)

Bug 926712 introduced a change in the implementation of InstallTrigger, the API that allows content to request add-on installation.

The build config changes at https://bugzilla.mozilla.org/attachment.cgi?id=8421181&action=diff#a/browser/installer/package-manifest.in_sec2 need to be ported to Thunderbird (http://dxr.mozilla.org/comm-central/source/mail/installer/package-manifest.in#668) and Instantbird (http://dxr.mozilla.org/comm-central/source/im/installer/package-manifest.in#518)
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Might be worth making a thorough pass (and maybe implementing a test), see Seamonkey bug 1019021
Blocks: cc-backlog
Aha! This must be what's causing bug 1049157
Attached patch bug1081190_InstallTriggers.patch (obsolete) — Splinter Review
This should be the packaging changes. But it doesn't seem to be enough...
Severity: normal → major
Whiteboard: [regression:TB32]
So this issue does not occur with a local build, but with a packaged build only?
(In reply to Frank Wein [:mcsmurf] from comment #5)
> So this issue does not occur with a local build, but with a packaged build
> only?

It seems so, I just installed an extension no prob with a self built trunk TB running without packaging.
Magnus: how about getting the packaging changes landed/reviewed, then see what doesn't work - i.e. errors on the error console or command line on debug builds.
Whiteboard: [regression:TB32] → [regression:TB31]
With this I can install from a test page. 
The dictionary example from bug 1049157 only offers the "Download" option, not the "Add to Thunderbird" so I can't really verify that works, though it probably does, if the page just start offering that alternative again.
Assignee: nobody → mkmelin+mozilla
Attachment #8503379 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8536076 - Flags: review?(clokep)
Comment on attachment 8536076 [details] [diff] [review]
bug1081190_InstallTriggers.patch

Review of attachment 8536076 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like the right change from the m-c bug. Thanks for tracking this down!
Attachment #8536076 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/4bbe6b265d18 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
Comment on attachment 8536076 [details] [diff] [review]
bug1081190_InstallTriggers.patch

[Approval Request Comment]
Regression caused by (bug #): bug 926712 (which landed for firefox31)
User impact if declined: can't install extensions from web pages, and more importantly for thunderbird: can't install dictionaries from web pages either and for those a web page is the primary access point.
Testing completed (on c-c, etc.): landed on trunk. it's unclear if this solves all the problems with installing dictionaries as apparently the mozilla dictionaries web page changed its code
Risk to taking this patch (and alternatives if risky): no risk, just a packaging addition
Attachment #8536076 - Flags: approval-comm-esr31?
Attachment #8536076 - Flags: approval-comm-beta?
Attachment #8536076 - Flags: approval-comm-aurora?
Ok so with the official nightly build installing dictionaries do works (tried Frisian which is compatible with 37)!
No longer blocks: 1049157
after updating this morning to 31.3 all my extensions stopped working and I now have to re-install them manually from file. I don't understand how Thunderbird was released with this known issue (must have been known beforehand since it appears in the release notes).
Attachment #8536076 - Flags: approval-comm-esr31?
Attachment #8536076 - Flags: approval-comm-esr31+
Attachment #8536076 - Flags: approval-comm-beta?
Attachment #8536076 - Flags: approval-comm-beta+
Attachment #8536076 - Flags: approval-comm-aurora?
Attachment #8536076 - Flags: approval-comm-aurora+
Sky: that's not really what this bug is about. It just causes an inability to install new extensions from web pages. That's not such an easy situation to get into in thunderbird... except for with the dictionaries. Your "old" extensions should (usually) be updated automatically or updatable via Tools | Add-ons where you can also search and install extensions just fine.
No longer blocks: cc-backlog
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: