Closed Bug 1070863 Opened 7 years ago Closed 7 years ago

The preprocessed channel-prefs.js file needs to be the same for each build

Categories

(Firefox :: Installer, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 35
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We don't update the channel-prefs.js file on app update though we do add it if it doesn't exist.

When it is preprocessed build specific info is left in the file such as the first line below:
//@line 2 "c:\builds\moz2_slave\m-cen-w32-ntly-000000000000000\build\browser\app\profile\channel-prefs.js"
/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

pref("app.update.channel", "nightly");

This will break Mac v2 signing so it can't be present.
Probably more appropriate as a toolkit bug since that is where it is preprocessed.
Attached patch patch rev1Splinter Review
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8493215 - Flags: review?(ted)
Comment on attachment 8493215 [details] [diff] [review]
patch rev1

Review of attachment 8493215 [details] [diff] [review]:
-----------------------------------------------------------------

Bleh.
Attachment #8493215 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/2cc605ebaad8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Landed on aurora in the Mac V2 signing combined patch in bug 1047584
You need to log in before you can comment on or make changes to this bug.