Closed Bug 1070888 Opened 5 years ago Closed 5 years ago

Themes panel Anchor is incorrectly placed in Customize mode the first time it opens when the browser window is short

Categories

(Firefox :: Theme, defect)

defect
Not set
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 35
Iteration:
35.3
Tracking Status
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: cornel_ionce, Assigned: Gijs)

References

Details

Attachments

(2 files)

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Mozilla/5.0 (X11; Linux i686; rv:35.0) Gecko/20100101 Firefox/35.0

STR:
1. Open Firefox in Window mode;
2. Click on the Menu Panel (hamburger button);
3. Enter Customize Mode;
4. Click on Themes.

Expected Results:
The themes menu is correctly displayed, with it's anchor origin in the Themes button, like in Maximized mode.

Actual Results:
The tooltip anchor is incorrectly displayed.

Notes:
This is also happening for the Menu Panel tooltip anchor.
Flags: qe-verify?
Duplicate of this bug: 1074178
I can't reproduce this reliably; only the first time I open the panel, and only if it's the "right" (well, wrong...) height.
Flags: qe-verify? → qe-verify+
Summary: Themes Tooltip Anchor is incorrectly placed in Customize mode → Themes panel Anchor is incorrectly placed in Customize mode the first time it opens when the browser window is short
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Marco, can you add this? See comment #3 as to how this got to be picked up. Thanks.
Iteration: --- → 35.3
Points: --- → 1
Flags: needinfo?(mmucci)
Added to IT 35.3
Flags: needinfo?(mmucci)
Comment on attachment 8499700 [details] [diff] [review]
set position and flip attribute so lightweight themes panel in customize mode opens correctly,

Review of attachment 8499700 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/content/customizeMode.inc.xul
@@ +33,5 @@
>          <panel type="arrow" id="customization-lwtheme-menu"
>                 onpopupshowing="gCustomizeMode.onLWThemesMenuShowing(event);"
>                 onpopuphidden="gCustomizeMode.onLWThemesMenuHidden(event);"
> +               position="topcenter bottomleft"
> +               flip="none"

Huh, I could have sworn that these were defined or passed in to the showPopup function already, but they are nowhere to be found. The default value for these, position="bottomcenter topleft" and flip="both" aren't what we want. It seems that flip="both" and the fact that this is located at the bottom of the browser window has allowed this to exist for so long. Thanks for fixing this.
Attachment #8499700 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/a70f7e0a4717
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
QA Contact: cornel.ionce
Considering bug 1073240 got verify-'d, I guess this should be, too.
Flags: qe-verify+ → qe-verify-
Comment on attachment 8499700 [details] [diff] [review]
set position and flip attribute so lightweight themes panel in customize mode opens correctly,

Approval Request Comment
[Feature/regressing bug #]: lwt picker panel feature
[User impact if declined]: weird placement of the panel
[Describe test coverage new/current, TBPL]: not for this aspect of it.
[Risks and why]: pretty much 0
[String/UUID change made/needed]: no
Attachment #8499700 - Flags: approval-mozilla-aurora?
Comment on attachment 8499700 [details] [diff] [review]
set position and flip attribute so lightweight themes panel in customize mode opens correctly,

Aurora+
Attachment #8499700 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.