Closed
Bug 1070890
Opened 10 years ago
Closed 10 years ago
[Messages][Refactoring] Make use of EventDispatcher in Compose
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: azasypkin, Assigned: azasypkin)
References
Details
(Whiteboard: [sms-sprint-2.1S5])
Attachments
(1 file)
It would beneficial for Compose to get rid of code that supports on/off/clearListeners. EventDispatcher implemented in bug 1039585 can be just mixed into Compose to provide event management methods.
|
Assignee | |
Comment 1•10 years ago
|
||
Hey Steve, This is part of my patch for bug 1067228, trying to split it into smaller parts to make review easier :) Thanks!
Attachment #8492972 -
Flags: review?(schung)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8492972 [details] [review] GitHub pull request URL Nice clean up! Just some suggestion that it would be better to sync up the change in mock_compose.js as well(like replacing the clearListener with offAll, or simply remove it if we don't need it). Although we might not need these for the testing for now, it's still better than leaving the outdated code in mock.
Attachment #8492972 -
Flags: review?(schung) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Thanks for review! Master: https://github.com/mozilla-b2g/gaia/commit/99bb2326e4282721ac4c1fe82cd3e55c7ed49ceb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [sms-sprint-2.1S5]
You need to log in
before you can comment on or make changes to this bug.
Description
•