1071069 - Thunderbird PFS removal - TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_inline | test-plugin-unknown.js::test_unknown_plugin_notification_bar

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Philip Chee]

Using profile dir: /builds/slave/test/build/mozmill/mozmillprofile
TEST-START | /builds/slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | setupModule
TEST-PASS | /builds/slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test-plugin-unknown.js::setupModule
TEST-START | /builds/slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test_unknown_plugin_notification_inline
Step Pass: {"function": "controller.click()"}
JavaScript error: chrome://messenger/content/plugins.js, line 261: TypeError: installStatus is null
Test Failure: Timed out waiting for plugin status div to appear
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_inline
TEST-START | /builds/slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test_unknown_plugin_notification_bar
Step Pass: {"function": "controller.click()"}
JavaScript error: chrome://messenger/content/plugins.js, line 261: TypeError: installStatus is null
Test Failure: Timeout waiting for the content tab to open
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/content-tabs/test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_bar

Comment 1

[Magnus Melin [:mkmelin]]

From bug 899347 - https://hg.mozilla.org/mozilla-central/rev/c07c6f96d613

installStatus is null - http://mxr.mozilla.org/comm-central/source/mail/base/content/plugins.js#261

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hrm - that patch should only affect things under browser/... I don't see how it could have affected mailnews code.

Comment 3

[Magnus Melin [:mkmelin]]

Indeed. I should have looked more closely :/

Comment 4

[Legacy TBPL/Treeherder Robot]

mkmelin
https://tbpl.mozilla.org/php/getParsedLog.php?id=49166048&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central debug test mozmill on 2014-09-29 18:41:19
revision: 4823bbd4a723
slave: t-w732-ix-072

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_inline
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_bar
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testLocalICS.js | testLocalICS.js::testLocalICS
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testTodayPane.js | testTodayPane.js::testTodayPane
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 5

[Hiroyuki Ikezoe (:hiro)]

https://hg.mozilla.org/mozilla-central/rev/d1ae4274cf8b

Comment 6

[Legacy TBPL/Treeherder Robot]

ssitter
https://tbpl.mozilla.org/php/getParsedLog.php?id=49449543&tree=Thunderbird-Trunk
TB Windows XP 32-bit comm-central debug test mozmill on 2014-10-02 18:41:12
revision: 8d4ad6998bcc
slave: t-xp32-ix-050

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_inline
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_bar
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testLocalICS.js | testLocalICS.js::testLocalICS
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testTodayPane.js | testTodayPane.js::testTodayPane
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 7

[Legacy TBPL/Treeherder Robot]

ssitter
https://tbpl.mozilla.org/php/getParsedLog.php?id=49449712&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central debug test mozmill on 2014-10-02 18:40:37
revision: 8d4ad6998bcc
slave: t-w732-ix-048

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_inline
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\content-tabs\test-plugin-unknown.js | test-plugin-unknown.js::test_unknown_plugin_notification_bar
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testLocalICS.js | testLocalICS.js::testLocalICS
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\testTodayPane.js | testTodayPane.js::testTodayPane
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: bug1071069_test_fail_unknown_plugin.patch

Since PFS was removed, we should just remove this code and test, as it does nothing useful anymore.

Comment 9

[Mark Banner (:standard8)]

I pushed this to help green up and clarify tree status:

https://hg.mozilla.org/comm-central/rev/ef1a562c5d12

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: comment fixes followup, v1

Two followups to the comment changes.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: comment fixes followup, v2, r=mkmelin

Comment 12

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/c49e5cc3a391