The default bug view has changed. See this FAQ.

Status

()

Core
Plug-ins
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: cers, Assigned: Dolske)

Tracking

unspecified
mozilla35
x86
All
Points:
5
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
This bug will track the changes needed to remove PFS from Firefox and services
(Reporter)

Updated

4 years ago
Depends on: 836420
(Assignee)

Updated

4 years ago
Depends on: 845638
(Assignee)

Updated

4 years ago
Depends on: 846990
(Assignee)

Updated

4 years ago
Depends on: 848160
Can you link to a blog post, or a Wiki page, or a dev.planning post, or something?  Where did this come from?
It was mentioned briefly at https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.apps.firefox/8CIIiXypoXY
Points: --- → 5
Flags: firefox-backlog+

Updated

3 years ago
Flags: qe-verify?
Hi Benjamin,

As you may know, the mozillaonline repack distributed by Beijing office used to have its own pfs server for extra Chinese sites/services specific plugins (bug 836420 comment 21). Most of these plugins do not need PFS for discovery and installation any more. However, there are still major websites here relying on PFS for Flash Player, such as Tencent video[1], Tencent Q-zone[2] and 4399 online games[3].

I'd like to know when and how will this "kill PFS with fire" (bug 836420 comment 22) happen? As Flash Player is also the top plugin globally (bug 848160 comment 2), will there be any kind of special treatment for Flash Player this time? Thanks!

[1]: http://v.qq.com/
[2]: http://qzone.qq.com/
[3]: http://www.4399.com/
Flags: needinfo?(benjamin)
Hector, there is no special treatment planned for Flash. Pretty much every site I've seen either falls back reasonably to HTML5 video, or prompts the user to install Flash using JS. Is that really not the case for major video sites?

Also note that since Flash is bundled with Windows 8+, we'd only be talking about new installs of Windows 7 or older, which isn't a growth market.
Flags: needinfo?(benjamin)
(Assignee)

Updated

3 years ago
Duplicate of this bug: 751100
(Assignee)

Comment 6

3 years ago
Created attachment 8489055 [details] [diff] [review]
Patch v.1

So. Much. Cruft.

remote: You can view the progress of your build at the following URL:
remote:   https://tbpl.mozilla.org/?tree=Try&rev=2a065c271125
remote: Alternatively, view them on Treeherder (experimental):
remote:   https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2a065c271125
Assignee: nobody → dolske
(Assignee)

Comment 7

3 years ago
One thought as I was ripping this code out: is there any reason to keep PFS working in Firefox 34/33?

There's too much here to uplift the whole patch, but the same effect could be achieved with a 1-liner fix: make showInstallNotification() in browser-plugins.js immediately return false.
Comment on attachment 8489055 [details] [diff] [review]
Patch v.1

Review of attachment 8489055 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, that's pretty spread out.
It would be great to base the browser-plugins.js/browser.js parts on bug 899347 or coordinate with mconley there, as that bug is about to land.
(Assignee)

Comment 9

3 years ago
I don't think bug 899347 landing first should be a problem, it looks like a fairly trivial update to this patch to just rip out the same code from where it's moved to.
(Assignee)

Comment 10

3 years ago
Comment on attachment 8489055 [details] [diff] [review]
Patch v.1

Try was mostly green, just a few failures (retriggered) which offhand seem more likely to be intermittent.
Attachment #8489055 - Flags: review?(benjamin)
Comment on attachment 8489055 [details] [diff] [review]
Patch v.1

\o/ !!!!
Attachment #8489055 - Flags: review?(benjamin) → review+
(Assignee)

Comment 12

3 years ago
Created attachment 8489597 [details] [diff] [review]
Patch v.2

Updated to what landed in bug bug 899347 (which has since bounced).
Attachment #8489055 - Attachment is obsolete: true

Updated

3 years ago
Status: NEW → ASSIGNED
Flags: qe-verify? → qe-verify-

Comment 13

3 years ago
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> Hector, there is no special treatment planned for Flash. Pretty much every
> site I've seen either falls back reasonably to HTML5 video, or prompts the
> user to install Flash using JS. Is that really not the case for major video
> sites?
> 
> Also note that since Flash is bundled with Windows 8+, we'd only be talking
> about new installs of Windows 7 or older, which isn't a growth market.

By contacting to Tencent which is one of the larget internet player in China for modifing their sites.
It sounds like the only thing we can do for China users is to pull it back and bundle it with China Edition ??
I don't know what "pull it back" means in this context. If you think Flash discovery is unusually important in the China edition, you could add some code specifically for Flash: but I'm skeptical that it actually matters in the market.

Also, please fix the UI and avoid the server dependency if you're going to do this. You can just hardcode https://get.adobe.com/flashplayer/ in the client.
(Assignee)

Comment 15

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/d1ae4274cf8b
(Assignee)

Comment 16

3 years ago
I've closed the remaining 62 open bugs in Toolkit :: Plugin Finder Service, and filed bug 1069487 to inactivate that component in bugzilla.
https://hg.mozilla.org/mozilla-central/rev/d1ae4274cf8b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

Updated

3 years ago
Iteration: --- → 35.2
(Assignee)

Updated

3 years ago
Blocks: 1071161
Blocks: 1071069

Updated

3 years ago
No longer blocks: 1071069
Depends on: 1071069
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> Also note that since Flash is bundled with Windows 8+, we'd only be talking
> about new installs of Windows 7 or older, which isn't a growth market.

The Flash Player bundled with Win8+ is unusable from Firefox (it is ActiveX only). Users will still have to download NPAPI Flash Player from Adobe.

Comment 19

2 years ago
(In reply to Justin Dolske [:Dolske] from comment #15)
> https://hg.mozilla.org/integration/fx-team/rev/d1ae4274cf8b

Just dropping two keywords here, to help others find this bug with the search function:
plugins.notifyMissingFlash
plugins.hide_infobar_for_missing_plugin

This bug is where these two prefs were removed from Firefox.

Reason for removal: they are not needed any more, because the function, which they disabled, was removed as well.
You need to log in before you can comment on or make changes to this bug.