1071245 - Please deploy Loop-Client 0.6.1 code to stage

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Mark Banner (:standard8)]

We'd like to deploy the loop-client 0.6.0 release to stage.

https://github.com/mozilla/loop-client/releases/tag/0.6.0

This can be done whenever, now that 0.12.2 is out. Preferably we'd like to deploy Tuesday/Wednesday if possible.

There are configuration and process changes required for release:

- Removed:
-- LOOP_PENDING_CALL_TIMEOUT / loop.config.pendingCallTimeout
- Added:
-- LOOP_FEEDBACK_API_URL / loop.config.feedbackApiUrl
-- LOOP_FEEDBACK_PRODUCT_NAME / loop.config.feedbackProductName

For stage, these can be created in config.js by "make config". Ideally, we should have different values to production:

loop.config.feedbackApiUrl for staging should be "https://input.allizom.org/api/v1/feedback" (this changes in production)
loop.config.feedbackProductName should be "Loop"

See README.md for more info about how to update this: https://github.com/mozilla/loop-client/blob/9a6301de54ada806d599b06d9d285166876d1dfd/README.md#configuration


Process changes:

We need to pull in the terms of service and include these in on staging, this is scripted, and can be generated by running "make install".

The ToS are generated as static pages and should show up under:

https://call.stage.mozaws.net/legal/terms/

Comment 1

[James Bonacci [:jbonacci]]

:rpapa will take this one. I will be his backup...

Comment 2

[Maire Reavy [:mreavy]]

:rpapa -- Do you know how quickly you'll be able to get this onto production (bug 1071251)?  (I realize this bug is about getting it to stage.)  I'm trying to time landing bug 1035846 -- which several folks are tracking.   I'd love to land it ASAP.  Thanks!

Comment 3

[James Bonacci [:jbonacci]]

:mreavy for loop-client, a lot of scheduling depends on OPs. Everybody is very busy and yet everybody understands the desire to get this into Prod this week. 
The gating factors are this: "configuration and process changes"
That alone usually adds a day's work for OPs.
That said, Richard and I will work with OPs and Dev to try to get this out by EOD Thursday of this week.

Comment 4

[Richard Pappalardo [:rpapa][:rpappalardo]]

:bobm, :whd -- Hey guys, I see that loop-client-stage is still at 0.5.0-2.  Do you know when things will be ready for deployment of 0.6.0 to stage?

Comment 5

[Wesley Dawson [:whd]]

I do not.

Comment 6

[James Bonacci [:jbonacci]]

Added fun for QA:
1. Verify the updated configs
2. Verify the updated yamls
3. Verify the updated manifest
4. Verify this feedback link (if it is exposed on Stage): https://input.allizom.org/api/v1/feedback
5. Verify the ToS: https://call.stage.mozaws.net/legal/terms/
(There is no Privacy page at this time)

Comment 7

[Bob Micheletto [:bobm]]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #4)
> :bobm, :whd -- Hey guys, I see that loop-client-stage is still at 0.5.0-2. 
> Do you know when things will be ready for deployment of 0.6.0 to stage?

Per mreavy on IRC this deploy can wait for :deanw tomorrow.  Changes are required for the build script for loop-server, and should be more / or less easily cribbed from the FxA build script.

See: https://github.com/mozilla-services/svcops/blob/master/services/loop/mock-create-client.sh

Comment 8

[Mark Banner (:standard8)]

I found an issue on staging with the link from the link-clicker page to the ToS. I've fixed it and so we need to update to 0.6.1:

https://github.com/mozilla/loop-client/releases/tag/0.6.1
https://github.com/mozilla/loop-client/blob/48f57f403e52f74858fa2783bd7f470e43d2752b/CHANGELOG

Comment 9

[Dean Wilson (:deanw)]

This has been deployed to staging.

Comment 10

[Richard Pappalardo [:rpapa][:rpappalardo]]

VERIFIED HOST RUNNING FOLLOWING CODE:

puppet-config-loop 20140924112304-1 x86_64 15370
loop-client-svcops 0.6.1-1 x86_64 11469095

/data/loop-client/content/VERSION.txt:
0.6.1
48f57f403e52f74858fa2783bd7f470e43d2752b Wed, 24 Sep 2014 13:06:25 +0100

FILES ON STAGE

/opt:
aws  openresty  stackdriver   ec2  rh

/data:
hekad  loop-client

/etc:
heka.d

/etc/puppet/yaml/app:
loop_client.dev.yaml
loop_client.prod.yaml
loop_client.stage.yaml
loop_client.yaml
loop_server.dev.yaml
loop_server.prod.yaml
loop_server.stage.yaml
loop_server.yaml

LOGS:
/var/log/circus.log
/var/log/hekad
/media/ephemeral0/nginx/logs 

HEKA
/data/hekad
/etc/heka.d

PROCESSES
stackdriver, nginx, python, circus, heka 

QUICK CHECKS

https://call.stage.mozaws.net/VERSION.txt:
0.6.1
48f57f403e52f74858fa2783bd7f470e43d2752b Wed, 24 Sep 2014 13:06:25 +0100

curl -I https://call.stage.mozaws.net:
HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-length: 2523
Content-Type: text/html
Date: Wed, 24 Sep 2014 15:25:05 GMT
ETag: "5422b811-9db"
Last-Modified: Wed, 24 Sep 2014 12:24:49 GMT
Vary: Accept-Encoding
Connection: keep-alive

https://call.stage.mozaws.net/config.js:
var loop = loop || {};
loop.config = {serverUrl: 'https://loop.stage.mozaws.net'};

https://call.stage.mozaws.net/:
Welcome to the WebRTC! web client.

https://loop.stage.mozaws.net/:
{"name":"mozilla-loop-server","description":"The Mozilla Loop (WebRTC App) server","version":"0.12.2","homepage":"https://github.com/mozilla-services/loop-server/","endpoint":"https://loop.stage.mozaws.net","fakeTokBox":false,"fxaOAuth":true,"i18n":{"defaultLang":"en-US","lang":"en-US"}}

Comment 11

[James Bonacci [:jbonacci]]

Here is OPs' summary of the changes made (from IRC):
1. Puppet manifests were changed to add the two new keys to the generated config via hiera lookups
2. Config file was changed to look like
https://github.com/mozilla-services/puppet-config/commit/58a8f49b80e7fd8b63b2c35d10d31aead4b11042
3. Values were added to the staging yaml config file
4. Package building script was modified to run a make install
5. A few extra packages were added to my build host to ensure this worked.
6. Package build was changed to remove all the node_module files. I don't think we've ever used these on the server and the package changed from 11000 files to 400 ish.

Comment 12

[Richard Pappalardo [:rpapa][:rpappalardo]]

from :natim -

config.js file should be https://call.stage.mozaws.net/config.js

And returns:

var loop = loop || {};

loop.config = {
  serverUrl: 'https://loop.stage.mozaws.net',
  feedbackApiUrl: 'https://input.allizom.org/api/v1/feedback',
  feedbackProductName: 'Loop'
};

Also https://call.stage.mozaws.net/VERSION.txt

0.6.1
48f57f403e52f74858fa2783bd7f470e43d2752b Wed, 24 Sep 2014 13:06:25 +0100

Comment 13

[James Bonacci [:jbonacci]]

And config.js is correct for Stage: /data/loop-client/content/config.js
shows this:
var loop = loop || {};

loop.config = {
  serverUrl: 'https://loop.stage.mozaws.net',
  feedbackApiUrl: 'https://input.allizom.org/api/v1/feedback',
  feedbackProductName: 'Loop'
};

Comment 14

[James Bonacci [:jbonacci]]

OK, so I *think* the only thing left for Richard to check are the two yaml files:
loop_client.stage.yaml
loop_client.yaml
located here: /etc/puppet/yaml/app

FYI this looks good to me: https://call.stage.mozaws.net/legal/terms/
but somebody from legal/Prod should really check the Production version of that when we get to that point...

Comment 15

[Rémy Hubscher (:natim)]

Standard8 — I've read somewhere that you said that:

  feedbackApiUrl: 'https://input.allizom.org/api/v1/feedback',

Should be there in stage. Do you know which url we should put there?
Also the feedback panel should happen in stage because we cannot do a call so far.

Comment 16

[Mark Banner (:standard8)]

(In reply to Rémy Hubscher (:natim) from comment #15)
> Standard8 — I've read somewhere that you said that:
> 
>   feedbackApiUrl: 'https://input.allizom.org/api/v1/feedback',

That's exactly what I see in stage at the moment:

https://call.stage.mozaws.net/config.js

(as per comment 0). The production one uses input.mozilla.org.

> Also the feedback panel should happen in stage because we cannot do a call
> so far.

That's fine. If it does work at some stage, then input.allizom.org is the right site as that's the testing site.

Comment 17

[Richard Pappalardo [:rpapa][:rpappalardo]]

FILES VERIFIED ON STAGE:
loop_client.stage.yaml
loop_client.yaml
located here: /etc/puppet/yaml/app