1071727 - [Contacts] Stuck in Gallery when attempting to add photo to contact while USB Plugged, then disconnecting

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Oliver Nelson [:oliverthor]]

Description:
When the user attempts to add a photo to a contact while maintaining a usb connection to a computer, they may encounter adverse affects upon disconnecting. The user is unable to add photos or use the gallery while within a usb connection, thus the phone requests they disconnect. Upon disconnecting, the user will be transitioned to the gallery application, however they are not able to select a photo for a contact at this point; instead, they have full functionality to select and edit photos as they see fit.
User may at this point:
- home button to return to home screen. Upon opening contacts again, they are essentially within the gallery with no way to exit, until the 'Contacts' application is force closed.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140922043003
2) Connect phone to neighboring computer via USB connection.
3) Ensure "USB storage" is enabled. 
4) Open the 'Contacts' app.
5) Create a new contact.
6) Attempt to add a photo from the gallery.
	- phone will request you disconnect from your USB connection to continue
7) Disconnect the USB cable by pulling the cable from the phone.
8) Observe gallery app and attempt to select a contact photo.
  
Actual:
Behaviour of the Gallery app now mimics that of merely opening the gallery. User cannot select an image to be used as a contact photo, but rather has full functionality of editting and selecting.
  
Expected: 
User is transitioned to the gallery app where they may select an image for a contact photo.
  
Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140922043003
Gaia: 3802009e1ab6c3ddfc3eb15522e3140a96b33336
Gecko: 5e704397529b
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Device: Flame 2.1
BuildID: 20140923003005
Gaia: 3a2947df41a480de1457a6dcdbf46ad0af70d8e0
Gecko: df42b05782aa
Version: 34.0a2
Firmware: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 5/5 attempts
See attached: 
video- http://youtu.be/LA9-IAybrBw

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Changing component to gallery, since contacts app is launching and activity and does not do anything with the gallery behavior.

Comment 2

[Peter Bylenga [:PBylenga]]

qawanted for branch checks to see if this is a regression.

Comment 3

[Hema Koka [:hema]]

David or Punam,

Can one of you please check whats going on after your blockers are addressed?

Thanks
Hema

Comment 4

[Duane Dixon [:ddixon]]

Branch Check 

Issue DOES occur in Flame 2.2, 2.1, 2.0, and 2.0 base image. 

Actual Results: 
User cannot select an image for an existing contact in Gallery app after device is disconnected from a USB connection to a computer. 

Device: Flame Master
Build ID: 20140923154520
Gaia: ff6dbb006e4e60edba697639aa2a2a199b07069b
Gecko: 30920bcb070a
Version: 35.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
------------------------------------------------------------
Device: Flame 2.1
Build ID: 20140925092639
Gaia: 86905e14c3ff06a0e6952ba635b6066ad2eea6b4
Gecko: e128c7d918de
Version: 34.0a2 
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
------------------------------------------------------------
Device: Flame 2.0
Build ID: 20140925082640
Gaia: 95a51689acd0488b3ba79abe2423cdcc132fff4a
Gecko: bd67c37ece85
Version: 32.0 (2.0)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
------------------------------------------------------------
Device: Flame 2.0 (base image)
Build ID: 20140904160718
Gaia: 506da297098326c671523707caae6eaba7e718da
Gecko: 2b27becae85092d46bfadcd4fb5605e82e1e1093
Version: 32.0 (2.0)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 5

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: not a regression but it is broken functionality / flow in a major app

Comment 6

[Punam Dahiya [:pdahiya]]

(In reply to Hema Koka [:hema] from comment #3)
> David or Punam,
> 
> Can one of you please check whats going on after your blockers are addressed?
> 
> Thanks
> Hema

Able to replicate the issue on Flame master v180, when photodb is available again after a USB mass storage, we are loading thumbnail list view by default.

https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/js/gallery.js#L291

Checking for any pending pick activity and taking appropriate action should resolve the issue. Cancelling the pick activity is the simplest fix as it will take user back to contact app and he will be able to try again and add picture without getting stuck in gallery list view. Looking into the fix.

Comment 7

[David Flanagan [:djf]]

Thanks for investigating this Punam. I think we may have had exactly the same issue with the Video app. I don't remember the bug number, but Russ might.  Russ: does this bug ring any bells for you?

Comment 8

[David Flanagan [:djf]]

I would guess that it is just a matter of putting a if (!pendingPick) {} around these lines in the onunavailable handler:

    // Switch back to the thumbnail view. If we were viewing or editing an image
    // it might not be there anymore when the MediaDB becomes available again.
    setView(LAYOUT_MODE.list);

Comment 9

[Russ Nicoletti [:russn]]

David, you may be thinking of bug 963636. There is a PR for that bug...

Comment 10

[Punam Dahiya [:pdahiya]]

Attachment: Patch with fix for Bug 1071727

Comment 11

[Punam Dahiya [:pdahiya]]

Comment on attachment 8496155 [details] [review]
Patch with fix for Bug 1071727

Hi David
Please review attached patch that fixes gallery pick activity while USB is plugged and than disconnected by user. It will help user to continue with pick activity and not get stuck in thumbnail list view. Thanks!

Comment 12

[David Flanagan [:djf]]

Comment on attachment 8496155 [details] [review]
Patch with fix for Bug 1071727

Looks good to me.

This turns out to be a dupe of bug 963636. Somehow I never reviewed the patch there. Punam reports that there are problems with that patch, however, so giving r+ for this simpler one.

We are purposely ignoring the corner case here of what happens if the user selects an image to crop, then deletes the file via UMS, and then returns and resumes cropping the delete image.

Comment 14

[Punam Dahiya [:pdahiya]]

(In reply to David Flanagan [:djf] from comment #12)
> Comment on attachment 8496155 [details] [review]
> Patch with fix for Bug 1071727
> 
> Looks good to me.
> 
> This turns out to be a dupe of bug 963636. Somehow I never reviewed the
> patch there. Punam reports that there are problems with that patch, however,
> so giving r+ for this simpler one.

Thanks David for review. In 963636 patch, if user selects a photo, crop, then mounts USB and deletes photo, we are taking user back to pick view without cleaning up crop view - cleanupCrop() , which shows previous crop overlays if user continues picking. 
> 
> We are purposely ignoring the corner case here of what happens if the user
> selects an image to crop, then deletes the file via UMS, and then returns
> and resumes cropping the delete image.

Comment 15

[Punam Dahiya [:pdahiya]]

Patch landed on master
https://github.com/mozilla-b2g/gaia/commit/14bf1e20971be0071a9ece7663d299fa1f0ed32f

Comment 16

[Hema Koka [:hema]]

Lets try to get this into 2.1. 

Punam or David, Please request approval from Fabrice and Bhavana

Comment 17

[Punam Dahiya [:pdahiya]]

Comment on attachment 8496155 [details] [review]
Patch with fix for Bug 1071727

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Not a regression
[User impact] if declined:
This will impact user trying to attach images from gallery [using Contacts, messaging app] while connected to computer using USB and than unplugging the device.

User cannot select an image via pick activity and get stuck in gallery thumbnail list view after device is disconnected from a USB connection to a computer.

[Testing completed]: On master
[Risk to taking this patch] (and alternatives if risky): Very low, it's a one line fix to not switch view to thumbnail list if it's a pending pick activity.

[String changes made]: None

Comment 18

[Punam Dahiya [:pdahiya]]

(In reply to David Flanagan [:djf] from comment #12)

> 
> We are purposely ignoring the corner case here of what happens if the user
> selects an image to crop, then deletes the file via UMS, and then returns
> and resumes cropping the delete image.

Created bug 1073688 to handle the corner case.

Comment 19

[bhavana bajaj [:bajaj]]

Comment on attachment 8496155 [details] [review]
Patch with fix for Bug 1071727

Adding verifyme for QA to help verify once this lands..

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/c052da2220b9e1f473bae49cafc14e9deb86ca7a

Comment 21

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.1 and Flame 2.2

Actual Results: User is transitioned to the gallery app where they may select an image for a contact photo.

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Leaving verifyme tag for uplift to 2.0

Comment 22

[Josh Cheng [:josh]]

Hi Kai-Zhen,
Could you help to land this on 2.0M? Thanks!

Comment 24

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/21448b78e35a01bf2af2d076b093f52c64dd617b

Comment 25

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 build.

Actual results: The user is returned to the image pick screen after deleting in image that was being cropped via usb.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150306010207
Gaia: 7a91c16bfa348be8b25e09719178efa051512988
Gecko: 0189941a3fd5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 26

[Shally Li（leave from Mozilla）]

This bug has been successfully verified on latest v2.1S and Woodduck v2.0. User is transitioned to the Gallery app after unplugging USB cable,then user can select a image and save the image as a contact photo.

See attachment: verified_v2.1S.mp4
Reproduce rate: 0/5

2.1S (512mb):
Build ID               20150308161201
Gaia Revision          ea97a87048a4c1e2a479bbea1d75e0a182b2c4c9
Gaia Date              2015-03-05 16:30:05
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/c1ba3b3ec5aa
Gecko Version          34.0
Device Name            scx15_sp7715ea
Firmware(Release)      4.4.2
Firmware(Incremental)  122
Firmware Date          Thu Feb  5 12:42:58 CST 2015

Woodduck 2.0:
Build ID               20150309050313
Gaia Revision          ca46abde35cda645a1c5dfa80e111c400feabdba
Gaia Date              2015-03-05 17:19:31
Gecko Revision         c77dc549894cf6956ca49cfb22228d5e4d2f9a2f
Gecko Version          32.0
Device Name            jrdhz72_w_ff
Firmware(Release)      4.4.2
Firmware(Incremental)  1425848690
Firmware Date          Mon Mar  9 05:05:10 CST 2015

Comment 27

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1S.MP4