1071919 - [Calendar] Settings drawer can become stuck open requiring app to be force closed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: Logcat.txt

Description:
Sometimes, after tapping the drawer icon in the calendar app, the resulting settings page that opens can become stuck open and the user will have to force close the app. Tapping the drawer icon or underneath the settings window will have no effect and the settings/accounts window will not close.
   
Repro Steps:
1) Update a Flame device to BuildID: 20140922043003
2) Calendar > Drawer Icon > Drawer Icon again
3) If drawer closes correctly, force close the app
4) Repeat steps 2-3 until issue occurs
  
Actual:
Drawer will become stuck open.
  
Expected: 
Drawer closes when prompted.

Device: Flame 2.1
BuildID: 20140923003005
Gaia: 3a2947df41a480de1457a6dcdbf46ad0af70d8e0
Gecko: df42b05782aa
Version: 34.0a2
Firmware: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 7/10
See attached: Video, logcat

Comment 1

[Rachel Pribble [:rpribble]]

This issue does not occur on the Flame v2.2 KK.

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20140922043003
Gaia: 3802009e1ab6c3ddfc3eb15522e3140a96b33336
Gecko: 5e704397529b
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Calendar drawer opens and closes as expected.

Comment 2

[Peter Bylenga [:PBylenga]]

qawanted for branch checks, it's strange that 2.1 is affected while 2.2 is not.

Comment 3

[Cody Roesch [:croesch]]

This bug repro's on Flame KK builds: Flame 2.1 KK

Actual Results: Able to get the drawer in Calendar to get stuck in the open position.

Repro Rate: 3/5

Environmental Variables:
Device: Flame 2.1 KK
BuildID: 20140925094247
Gaia: 86905e14c3ff06a0e6952ba635b6066ad2eea6b4
Gecko: d773f9b77e7e
Version: 34.0a2
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

-----------------------------------------------------------------
-----------------------------------------------------------------

This bug does NOT repro on Flame kk build: Flame 2.2 KK, Flame 2.0 KK

Actual Result: Calendar drawer functions as expected every time.

Repro Rate: 0/20

Environmental Variables:
Device: Flame Master
BuildID: 20140925053746
Gaia: c5d2e2f4ebf5f370d6003517057dcd47493dec90
Gecko: e9e56750ca5b
Version: 35.0a1 (Master) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
-----------------------------------------------------------------
Environmental Variables:
Device: Flame 2.0
BuildID: 20140925082640
Gaia: 95a51689acd0488b3ba79abe2423cdcc132fff4a
Gecko: bd67c37ece85
Version: 32.0 (2.0) 
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 4

[Joshua Mitchell (Inactive)]

[Blocking Requested - why for this release]: Regression in a major feature, broken functionality and must close the app to recover



Regression Window - let's find the 'reverse-window' for what fixed this issue in 2.2; possibly something just needs an uplift to 2.1

Comment 5

[Adam Alldredge [:AdamA][Inactive]]

----------------------------------------------------
B2G-Inbound "Reverse" Regression Window
----------------------------------------------------

Last Broken:
Device: Flame 2.2 Master
BuildID: 20140904071744
Gaia: 5cd232651c5a34bebf4d973e7e4904f11d6ce547
Gecko: bcc8a8fd2c07
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First Working:
Device: Flame 2.2 Master
BuildID: 20140904091341
Gaia: b2bc7392fd1a1407ba3fc774fd84e185a5a09365
Gecko: b168136915f5
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Last Broken Gaia First Working Gecko: Issue DOES reproduce
Gaia: 5cd232651c5a34bebf4d973e7e4904f11d6ce547
Gecko: b168136915f5

First Working Gaia Last Broken Gecko: Issue does NOT reproduce
Gaia: b2bc7392fd1a1407ba3fc774fd84e185a5a09365
Gecko: bcc8a8fd2c07

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/5cd232651c5a34bebf4d973e7e4904f11d6ce547...b2bc7392fd1a1407ba3fc774fd84e185a5a09365

Fixed in 2.2 by Reverting Bug 1023664

Comment 6

[Joshua Mitchell (Inactive)]

Kevin - it looks like this bug might have been fixed in 2.2 when you reverted  "Calendar modularization again with unit test fixes"  or by the landing of it - I'm having a hard time sorting out the pushlog - but can you take a look and determine what needs to happen / get uplifted to get the fix to 2.1

Comment 7

[Candice Serran (:cserran)]

definite poor user experience, identified how this was broken. Regression.

Comment 8

[Miller Medeiros [:millermedeiros]]

taking this since Gareth is swamped. will try to identify what introduced the regression and fix it.

Comment 9

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24854

bug doesn't happen on master because the "modularization" patch added some delay to the `onactive` logic. We can't really uplift that patch because it changed a lot of other stuff.. My changes are minimal and should fix the problem without introducing regressions.

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8500712 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24854

So this is okay with me for now, but I'm also starting to think that we have a good bit of state between the dom and this view and wonder if we can simplify things at all.

Comment 11

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8500712 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24854

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): race condition that became evident after we started to use the <gaia-header> custom element (Bug 1015292)
[User impact] if declined: user needs to restart the app, pretty bad UX
[Testing completed]: manual testing (more than 10 tries)
[Risk to taking this patch] (and alternatives if risky): very small risk, code changes affects only the calendar settings view.
[String changes made]: none

Comment 12

[Miller Medeiros [:millermedeiros]]

landed on v2.1: https://github.com/mozilla-b2g/gaia/commit/55ce3612bd8a8665139d6b85114ce59993a3fa0a

Comment 13

[pete siphantong [:Petes]]

This bug is verified fixed on the Flame 2.1 (319mb)


Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Result: Drawer closes when prompted.