1072141 - browser/webaudioeditor tests fail in e10s

Status: RESOLVED FIXED

(DevTools Graveyard :: Web Audio Editor, defect)

Description

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Attachment: 0001-Bug-XXXXXXX-get-browser-devtools-webaudioeditor-test.patch

Most of the necessary changes are shallow and very similar to bug 1065355 (and hence requesting review from Patrick again!)

Note however there is also a change to toolkit/devtools/server/actors/webaudio.js, which moves the null-ing of this.tabActor to after this.tabActor is passed to off().  With these changes the tests all pass locally for me with e10s enabled.

Comment 1

[Patrick Brosset <:pbro>]

Comment on attachment 8494327 [details] [diff] [review]
0001-Bug-XXXXXXX-get-browser-devtools-webaudioeditor-test.patch

Review of attachment 8494327 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, that does look exactly like bug 1065355 and since no test actually use debuggee, it's the perfect fix for this.
Thanks!

Comment 2

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

You're welcome :)

https://hg.mozilla.org/integration/fx-team/rev/6d9fb906e5b9

Comment 3

[Carsten Book [:Tomcat]]

sorry had to backout this change for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=48757407&tree=Fx-Team

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: fix_browser_audionode-actor-get-param-flags-js.patch

The tests in browser/devtools/webaudioeditor/test/browser_audionode-actor-get-param-flags.js were not running at all. This was because:
- An attempt was made to yield inside an Array.forEach (not valid... prevents the JS engine from entering the loop).
- nodes[i].getParamFlag(param) should have been nodes[i].getParamFlags(param) (the error was not visible because the browser never entered the loop).

Spoke with markh who seems happy for me to add it to this bug.

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Looks like the same fixes (as debuggee is never used) as bug 1061904, so closing that one (was waiting for refactoring bug 1057042 to land, but that just landed)

Comment 7

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Comment on attachment 8494507 [details] [diff] [review]
fix_browser_audionode-actor-get-param-flags-js.patch

Sorry to mess you around Mike, but if it's OK, can you please put this new patch into a different bug, as I'm going to reland the larger patch.

Comment 8

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Relanded with the tests I mysteriously missed fixed in the same way, so carrying r= forward.  Try at https://tbpl.mozilla.org/?tree=Try&rev=1f6e18d9d4c8

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b9f4aa97c721