Fix resource dependency issues in new tablet UI (affects SDK9-only builds)

RESOLVED FIXED in Firefox 35

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

unspecified
Firefox 35
All
Android
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, fennec35+)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
We'll have to creates aliases/stubs for the resources that are now only present on tablets.
Requesting tracking 'cos we're tentatively/informally tracking 35 for splitapk.

Adding a kinda-depends-on to Bug 1072400 for tests to catch this kind of thing.

N.B., stubs are only needed for in-code references that are compiled even on the non-tablet range; see Bug 1044334 for how we tackled that in the last pass.

One solution to avoid the need to stub is to have tablet-related code split into separate files, and then conditionally build those files, or to conditionally build parts of a preprocessed file. So long as the compiler never sees the reference, the ID can be missing.

(I'm sure this is no news to you, but capturing the knowledge for anyone wandering by.)
Blocks: 1039789
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
Depends on: 1044334, 1072400
Summary: New tablet UI breaks build for Gingerbread-only apks → Fix resource dependency issues in new tablet UI (affects SDK9-only builds)
(Assignee)

Comment 2

3 years ago
Created attachment 8498133 [details] [diff] [review]
Fix resource dependency issues in new tablet UI (r=rnewman)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8498133 [details] [diff] [review]
Fix resource dependency issues in new tablet UI (r=rnewman)

Stubs IDs and layouts that should exist even on Gingerbread-only builds. FYI: the patch in bug 1065494 is necessary to completely fix this bug.
Attachment #8498133 - Flags: review?(rnewman)
Comment on attachment 8498133 [details] [diff] [review]
Fix resource dependency issues in new tablet UI (r=rnewman)

Review of attachment 8498133 [details] [diff] [review]:
-----------------------------------------------------------------

If this builds a 9-9 APK, I'm happy! Thanks for getting this done.

I assume we'll be doing a pass after the new tablet stuff lands, both to eliminate the new_tablet prefix and to see if there's stuff we can tease apart and move?

For example, some of the 'base' dimensions (new_tablet_tab_strip_height?) look like they can be in a tablet resource if we exclude tablet-specific code from the build, which is something we want to do anyway for Gingerbread builds.
Attachment #8498133 - Flags: review?(rnewman) → review+
(Assignee)

Comment 5

3 years ago
(In reply to Richard Newman [:rnewman] from comment #4)
> Comment on attachment 8498133 [details] [diff] [review]
> Fix resource dependency issues in new tablet UI (r=rnewman)
> 
> Review of attachment 8498133 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> If this builds a 9-9 APK, I'm happy! Thanks for getting this done.
> 
> I assume we'll be doing a pass after the new tablet stuff lands, both to
> eliminate the new_tablet prefix and to see if there's stuff we can tease
> apart and move?
> 
> For example, some of the 'base' dimensions (new_tablet_tab_strip_height?)
> look like they can be in a tablet resource if we exclude tablet-specific
> code from the build, which is something we want to do anyway for Gingerbread
> builds.

Yeah, this is all done in bug 1065494. It's not a complete cut but good enough (about 90% of the new tablet resources are stripped out) for a temporary situation.
tracking-fennec: ? → 35+
(Assignee)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/cd9cc5f3d9ed
Created attachment 8499770 [details] [diff] [review]
Part 2: Correct new tablet favicon size

Seems this dimen was mis-copied.
Assignee: lucasr.at.mozilla → michael.l.comella
https://hg.mozilla.org/integration/fx-team/rev/445bcb561d7f
Assignee: michael.l.comella → lucasr.at.mozilla
https://hg.mozilla.org/mozilla-central/rev/cd9cc5f3d9ed
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
https://hg.mozilla.org/mozilla-central/rev/445bcb561d7f
Created attachment 8507253 [details] [diff] [review]
Part 3: Stub new_tablet_site_security_level

Oops.
Assignee: lucasr.at.mozilla → michael.l.comella
Assignee: michael.l.comella → lucasr.at.mozilla
https://hg.mozilla.org/integration/fx-team/rev/c564a54e2e71
https://hg.mozilla.org/mozilla-central/rev/c564a54e2e71
Blocks: 1093394
status-firefox35: --- → fixed
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.