Fix resource dependency issues again in new tablet UI (affects SDK9-only builds)

RESOLVED FIXED in Firefox 36

Status

()

Firefox for Android
Build Config & IDE Support
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 36
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Same again. This is mhaigh's file. Throwing it at him unless I fix it first!

 0:13.05 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/new_tablet_tabs_item_cell.xml:24: error: Error: No resource found that matches the given name (at 'textColor' with value '@color/new_tablet_tab_item_title').
 0:13.05
 0:13.05 /Users/rnewman/moz/hg/fx-team/mobile/android/base/resources/layout/new_tablet_tabs_item_cell.xml:34: error: Error: No resource found that matches the given name (at 'src' with value '@drawable/new_tablet_tab_item_close_button').
(Assignee)

Comment 1

4 years ago
Created attachment 8516370 [details] [diff] [review]
Move new_tablet_tabs_item_cell.xml into a tablet resource directory. v1

This makes things build for me.
Attachment #8516370 - Flags: review?(lucasr.at.mozilla)
(Assignee)

Updated

4 years ago
Assignee: mhaigh → rnewman
(Assignee)

Comment 2

4 years ago
Also, I don't even see the color defined at all. Might be a second bug hiding there.

$ ag 'new_tablet_tab_item_title' mobile/
mobile/android/base/resources/layout/new_tablet_tabs_item_cell.xml
30:                  android:textColor="@color/new_tablet_tab_item_title"
Comment on attachment 8516370 [details] [diff] [review]
Move new_tablet_tabs_item_cell.xml into a tablet resource directory. v1

Review of attachment 8516370 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.
Attachment #8516370 - Flags: review?(lucasr.at.mozilla) → review+
Tracking that colour issue over at https://bugzilla.mozilla.org/show_bug.cgi?id=1093636
https://hg.mozilla.org/mozilla-central/rev/6f5199eec3c0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
I still get this same build error when building with "MOZ_ANDROID_NEW_TABLET_UI=" unset...except for the error is now complaining about being in the file mobile/android/base/resources/layout-v11/new_tablet_tabs_item_cell.xml

Is it not supported to build Firefox-36 with MOZ_ANDROID_NEW_TABLET_UI unset?

It seems (in my simple test) that moving mobile/android/base/resources/layout-v11/new_tablet_tabs_item_cell.xml to mobile/android/base/newtablet/res/layout-large-v11/new_tablet_tabs_item_cell.xml fixes the issue for when MOZ_ANDROID_NEW_TABLET_UI is not set...though I don't know if that breaks the build when MOZ_ANDROID_NEW_TABLET_UI is set.
(Assignee)

Comment 8

3 years ago
(In reply to Nathan Toone from comment #7)
 
> Is it not supported to build Firefox-36 with MOZ_ANDROID_NEW_TABLET_UI unset?

Correct: it is not supported. The flag will be removed soon.
You need to log in before you can comment on or make changes to this bug.