1073823 - Turn off enhanced tiles for all Firefox 33 users

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Sounds like we're moving Enhanced Tiles to Firefox 34.

Comment 1

[Ed Lee :Mardak]

Forgot to write the actual bug contents :p

Similar to bug 1056279, we want to turn off enhanced for all users and not just non-en-US.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Ed, could you prepare a patch so that we are ready? Thanks

Comment 3

[Ed Lee :Mardak]

Attachment: v1

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8497776 [details] [diff] [review]
v1

Review of attachment 8497776 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/newtab/head.js
@@ +24,5 @@
>  let isWindows = ("@mozilla.org/windows-registry-key;1" in Cc);
>  let gWindow = window;
>  
> +// Override with enabled for testing (except for individual tests that turn off)
> +DirectoryLinksProvider.enabled = true;

Should that be |._testing = true| as well?

Comment 5

[Ed Lee :Mardak]

(In reply to Tim Taubert [:ttaubert] from comment #4)
> > +// Override with enabled for testing (except for individual tests that turn off)
> > +DirectoryLinksProvider.enabled = true;
> Should that be |._testing = true| as well?
For the mochitest, init() will have already been called, so we just override it directly. But for xpcshell test, init() is called multiple times, so we need the _testing to have it initialize correctly.

We have all this oddness because the tests were always assuming it would be enabled for en-US, but the main code change here explicitly turns off for en-US.

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Ok, fair enough.

Comment 7

[Ed Lee :Mardak]

Attachment: for beta uplift

Approval Request Comment
[Feature/regressing bug #]: Bug 1030832 / Enhanced Tiles
[User impact if declined]: Users of 8 locales will see the "what is this" link and explanation doorhanger on first newtab
[Describe test coverage new/current, TBPL]: Updated tests for turning off functionality for all locales including en-US https://tbpl.mozilla.org/?tree=Try&rev=8c7ecded425c
[Risks and why]: low - turned off for majority of locales already, so turning off for the remainder
[String/UUID change made/needed]: none

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/8dfb2430db1c

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Verified fixed on Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 12.04 32bit using Firefox 33 beta 9, build ID: 20141002185629.

Tested with the following locales: en-US/ach/de/es-ES/fr/ja-JP/pl/pt-BR and ru - the enhanced tiles is disabled.
Clicking on the gear button from about:newtab will toggle the page to blank and back.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Ed, could you open a new bug for 33.1 to enable this back? Thanks

Comment 11

[Ed Lee :Mardak]

(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> Ed, could you open a new bug for 33.1 to enable this back?
Filed bug 1082051.