1074166 - [2.1] Device specific strings like "Reset phone" are not localized on pvt builds

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Build info
Tested against today's 2.1.

Prerequisite
Have the phone in another language (tested with French or Spanish)

STR
1. Go to settings -> Information
2. Scroll at the bottom of the page

Actual result
The button shows "Reset phone"

Expected
The button should show "Réinitialiser le téléphone" in French like in 2.0

[Blocking Requested - why for this release]: Regression +  Non-localizable strings

Comment 1

[howie [:howie]]

qawanted to check if this happens in other language. Could be missing string in French or non-localizable strings. Tested on 2.2 unaffected.

Comment 2

[Duane Dixon [:ddixon]]

Issue DOES occur in other languages.

NOTE:  Not every language was tested for this issue. 

Actual Results: "Reset Phone" is not localized. 

Language tested: 

Affected: 
Euskara
Afrikaans
Kiswahili

Unaffected: 
Galego
Dansk
Italiano
Magyar
Srpski
Catala

Environmental Variables:
Device: Flame Master
Build ID: 20140930061521
Gaia: 77ef35f5429bc3dfe9ca192b9aacc3c0bf8857de
Gecko: 2ae57957e4bb
Version: 35.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Johan,

based on comment 2, it seems that some languages are okay while some are not, so I suspect this is a l10n issue.

Can you provide more details about how you test this ? Any full steps to flash phones ... blah would be thankful.

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Axel,

we did check built file pulling from pvt and we noticed that the related languages are not translated yet in 2.1 while they got well translated in 2.2 (master)

I think this bug is caused by pointing to wrong commit id where related languages are not translated yet while they do exist on master already.

Can you help us check this ? Thanks.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #4)
> we did check built file pulling from pvt and we noticed that the related
> languages are not translated yet in 2.1 while they got well translated in
> 2.2 (master)

MASTER
l10n hasn't branched yet, so gaia-l10n is currently covering 2.1, we don't have anything for master (yet).
https://hg.mozilla.org/gaia-l10n/

This specific string is not localized in all languages yet (it was introduced in 2.1)
http://transvision.mozfr.org/string/?entity=apps/settings/device_type/phone/settings.device.properties:reset-device&repo=gaia

eu is missing only those strings, af and sw are much more behind (about 1k strings).

2.1
About comment 0 (French on 2.1): this looks like a build problem. See bug 1065175, but that was fixed by a structural change that's not available on 2.1 (bug 1022767).

Sherman, can you confirm if this is the same bug?

Comment 6

[Johan Lorenzo [:jlorenzo]]

(In reply to EJ Chen [:eragonj][:小龍哥] from comment #3)
You're right. I'm removing the nom' then.

Comment 7

[Francesco Lodolo [:flod]]

Well, for 2.1 it's actually a blocker if confirmed.

Comment 8

[Sherman Chen [:chens] (inactive)]

(In reply to Francesco Lodolo [:flod] from comment #5)
> About comment 0 (French on 2.1): this looks like a build problem. See bug
> 1065175, but that was fixed by a structural change that's not available on
> 2.1 (bug 1022767).
> 
> Sherman, can you confirm if this is the same bug?

I was thinking these two are the same, but patch from bug 1022767 didn't solve this issue.
Still looking if anything could help from build system.

Comment 9

[Francesco Lodolo [:flod]]

Bug 1022767 is *not* on 2.1. AFAIK we don't have this issue anymore on master, only on 2.1

Comment 10

[Sherman Chen [:chens] (inactive)]

I've tried to pull the latest l10n files and still not able to reproduce.

One think I would like to make sure, are we using the same l10n files for 2.1 and master? or did we specify any version of l10n when build 2.1?

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Sherman Chen [:chens] from comment #10)
> One think I would like to make sure, are we using the same l10n files for
> 2.1 and master? or did we specify any version of l10n when build 2.1?

Someone from releng should be able to confirm, but we don't have any repo for 2.1 yet, so I don't think that "wrong l10n" repo is an option.

Comment 12

[Sherman Chen [:chens] (inactive)]

Thanks flod, I think there's a bad assumption made on locales folder in bug 944604 patch. It assumes all locales files are under |locales| folder, but actually it could be other folder because |LOCALE_BASEDIR| flag could change it[1].

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1065175#c20

Comment 13

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request

Comment 14

[Francesco Lodolo [:flod]]

Comment on attachment 8498681 [details] [review]
Pull request

Not really in a position to give feedback on this (can't even flash my own builds right now).

I'll pass it to :gandalf since he's more familiar with this code.

Comment 15

[Sherman Chen [:chens] (inactive)]

IMO we can apply two patches from bug 1022767 and fix this one, but it would be too risky to uplift huge patch. These patch could fix this in the other way.

Comment 16

[Joshua Mitchell (Inactive)]

removing regression-window wanted: bug is not blocking and already patched

Comment 17

[Sherman Chen [:chens] (inactive)]

Based on comment 2 and comment 5, I would say master is not affected, those affected strings in comment 2 are actually not translated yet.

Comment 18

[Francesco Lodolo [:flod]]

Yes, this is 2.1 only. I'm marking the other bug as duplicate to avoid wasting everyone's time.

Comment 20

[Francesco Lodolo [:flod]]

Editing bug subject, also removing 2.2 from affected versions (see bug 1065175 comment 35).

Comment 21

[Francesco Lodolo [:flod]]

[Blocking Requested - why for this release]: part of settings (device specific strings) are not correctly localized on 2.1. Issue was already fixed on master, but the fix depends on bugs that can't be landed on 2.1

Comment 22

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8498681 [details] [review]
Pull request

It looks good to me and also works on my environment.

r=@RickyChien. Thanks

Comment 23

[howie [:howie]]

Triage: regression, blocking

Comment 24

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8498681 [details] [review]
Pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 944604
[User impact] if declined: Device specific strings are not localized correctly.
[Testing completed]: Manual test + unit test.
[Risk to taking this patch] (and alternatives if risky): Low risk and no alternatives.
[String changes made]: None.

Comment 26

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8498681 [details] [review]
Pull request

lgtm

Comment 27

[Sherman Chen [:chens] (inactive)]

2.1: https://github.com/mozilla-b2g/gaia/commit/7ef2e1e59637a34ca4489c329b3bdee93df3ac6c

Comment 28

[Ryan VanderMeulen [:RyanVM]]

Reverted for breaking Windows desktop B2G builds.
v2.1: https://github.com/mozilla-b2g/gaia/commit/dc744273ab3f342fa03e145acb3e892258358817

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=305918&repo=mozilla-aurora

Comment 29

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Hey, :chens, do you have time to dig this today? We need to get all 2.1+ bugs done by today.

Comment 30

[Sherman Chen [:chens] (inactive)]

I'm working on it, still figuring out what's happening on windows build.

Comment 31

[Sherman Chen [:chens] (inactive)]

Attachment: Pull request 2

Comment 32

[Sherman Chen [:chens] (inactive)]

Update regex in device type string checking, also replace dirname|basename with NSIFile operation.

Comment 33

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8502322 [details] [review]
Pull request 2

I leaved a comment on Github to improve regexp.

However, it seems to be no problem landing after try server all green.

r=@RickyChien

Comment 34

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8502322 [details] [review]
Pull request 2

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 944604
[User impact] if declined: Device specific strings are not localized correctly.
[Testing completed]: Manual test + unit test.
[Risk to taking this patch] (and alternatives if risky): Low risk and no alternatives.
[String changes made]: None.

Comment 35

[Sherman Chen [:chens] (inactive)]

2.1: https://github.com/mozilla-b2g/gaia/commit/94241841e18c0ce41943bd12ab16c338faf99257

Comment 36

[sarsenyev]

Verified on Flame 2.1, "Reset Phone" string is localized on "French" and "Spanish" languages 

Device: Flame 2.1

BuildID: 20141023001201
Gaia: 1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1
Gecko: 09fb60a37850
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0