107421 - --disable-mailnews build broken

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Chris Waterson]

Ben, I figured out why btek is broken. The problem is that I'm doing a
--disable-mailnews build (so that my turnaround time is good): I don't need
mailnews to run the performance tests. Until last night, that is! I'm getting
the following error on startup:

  *** Failed to load overlay chrome://messenger/content/mailOverlay.xul

And after that, my browser window is trashed.

So, I guess we either need to decide that browser now _requires_ mailnews, or
you need to fix something in the chrome here.

Comment 1

[Brendan Eich [:brendan]]

browser should not require mailnews, period full stop.

/be

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

This is a major problem to me as well.  I depend on using --disable-mailnews. 
Raising severity to blocker (IMHO, change if you like).

Comment 3

[Akkana Peck]

This also affects release builds if you check "custom" and don't install
mailnews -- the browser doesn't work.
I'm surprised this isn't considered important enough to hold the tree closed.

Comment 4

[Jeremy M. Dolan]

> I guess we either need to decide that browser now _requires_ mailnews, or

Bahahah, that's funny.

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 107661 has been marked as a duplicate of this bug. ***

Comment 6

[Arthur Wagner]

This is NOT the same as 107661 !!!!!!! I did NOT disable-mailnews in
my build. The error message from loader <attach 55838) does indicate
failure to load MailOverlay.xul, but I specified a COMPLETE install.
The problem must be in  <2001103011>
Art Wagner

Comment 7

[pocemit]

Same thing here, 2001103108 homemade build

"*** Failed to load overlay chrome://messenger/content/mailOverlay.xul
Warning add child failed!!"

blue window, contains parts of statusbar and "Document: Done."
thankfully I only compile mozilla for the GTK embedding widget :)

Comment 8

[Arthur Wagner]

I tried to reproduce the error by going through a complete mozilla-install using
the same copy of mozilla-install I used previously. I failed to reproduce the
error but i got a new build (2001103012) instead of (2001103011) previously.
I am absolutely sure I did a "complete" install of the original build.
The GOOD news is that I could not reproduce the error. Might have been a glitch
in the 103011 build process????
Art

Comment 9

[hacker formerly known as [e-mail]]

This should've been a smoketest blocker originally.

Comment 10

[Håkan Waara]

Someone will have to adopt this -- I don't think Ben Goodger is awake at this
time. Any volunteers?

Comment 11

[R.K.Aa.]

*** Bug 107810 has been marked as a duplicate of this bug. ***

Comment 12

[J.J. Enser]

cc'ing twalker since people claim this should be a smoketest blocker. However,
smoketests are performed against release builds and embedding builds, both built
without this option (--disable-mailnews) I believe, so I don't think he could
have detected this bug.
Should this keep the tree closed ? (that's what smoketest blocker typically implies)

Comment 13

[Akkana Peck]

It's still seen with release builds, if you install "custom" and don't install
mailnews.  Anyone trying to install a release build to test just the browser
would see it, and would be unable to test the browser without going back and
reinstalling everything.

Comment 14

[J.J. Enser]

ok, then it defenitely sounds like a blocker.
So is this the 3rd day this happens, or has it been around longer?

Comment 15

[Jeremy M. Dolan]

I always deselect mailnews in the installer. Started happening two or three days
ago, no longer.

Comment 16

[Robert Ginda]

Ben's 10/29 checkins look suspicious, has no one else made progress on this yet?
 I'll have a look.

Comment 17

[Robert Ginda]

on 10/29 ben added editor/ui/composer/content/editorNavigatorOverlay.xul, which
depends on chrome://messenger/content/mailOverlay.xul.  If this file is missing,
we mess ourself.  Upcoming patch drops the dependency, at the expense of some
mailnews commands in editor menus.

Comment 18

[Robert Ginda]

Attachment: remove mailOverlay.xul from editorNavigatorOverlay.xul

Comment 19

[andreww]

seems ok to remove the reference - r=andreww

Comment 20

[Simon Fraser [no longer active]]

sr=sfraser, but we need Ben to look at this later.

Comment 21

[Robert Ginda]

patch checked in.  I leave it up to Ben to deal with the bug.

Comment 22

[Tracy Walker [:tracy]]

looks okay with respin on linux commercial 2001-10-31-13-trunk

Comment 23

[Simon Fraser [no longer active]]

This was fixed yesterday, right?

Comment 24

[Daniel Veditz [:dveditz]]

*** Bug 107613 has been marked as a duplicate of this bug. ***

Comment 25

[timeless]

Attachment: do the right thing?

Comment 26

[Ben Goodger (use ben at mozilla dot org for email)]

No, that line was actually not necessary, and a mistake on my part. It 
shouldn't be added back in. I'm going to remove the line altogether. 

Comment 27

[Tracy Walker [:tracy]]

verified with latest builds