Closed Bug 1074332 Opened 10 years ago Closed 10 years ago

[Utility Tray] Status Bar icons toggle off/on to soon


(Firefox OS Graveyard :: Gaia::System, defect, P1)

Gonk (Firefox OS)



tracking-b2g backlog


(Reporter: epang, Assigned: apastor)



(Keywords: polish, Whiteboard: [systemsfe], ux-most-wanted-nov2014, 2x-uxnom)


(2 files)

Hi Alberto,

I'm opening this bug as a follow up to bug 1067913.
Currently with the patch in bug 1067913 the status bar icons toggle off before the handle passes with the vice versa happening when the tray goes up.

I've attached a visual flow of what ideally should happen.
If you have any questions please let me know, thanks!
blocking-b2g: --- → backlog
Priority: -- → P1
Blocks: 1098041
Eric, could you please ui-review this?

Attachment #8523812 - Flags: ui-review?(epang)
Blocks: 994991
Whiteboard: [systemsfe] → [systemsfe], ux-most-wanted-nov2014
Comment on attachment 8523812 [details] [review]
Link to Pull Request:

Hey Alberto, this is looking really good but I think a few tweaks are needed.

1. Is it possible to have the handle of the utility tray full opaicty all the way though?  I think it will help with the transition.

2.  When pulling down the handle at the top it feels a little jagged. Right after you see the entire handle it feels like it snaps down.  Is there anything we can do to make this smoother?

3. When you close the tray the date/icons shouldn't move up.  It looks cool, but the icons end up flashing back that are under the tray.  This only happens when you you flick the tray closed - if you hold you're finger down it doesn't happen.

Let me know if you have any questions or if I need to clarify :).  This is looking great so far!!  Flag more for review again when ready and feel free to bug me!
Flags: needinfo?(apastor)
Attachment #8523812 - Flags: ui-review?(epang) → ui-review-
Comment on attachment 8523812 [details] [review]
Link to Pull Request:

Hi Eric. I just updated the patch, and now 1 and 3 should be fixed. Regarding 2, couldn't find an easy way of making it smoother (we are showing/hiding the real statusbar when that happens, so moving only in that space is not cheap). I'll ask for advice on the review for that.

Flags: needinfo?(apastor)
Attachment #8523812 - Flags: ui-review- → ui-review?(epang)
Comment on attachment 8523812 [details] [review]
Link to Pull Request:

This is great, thanks for working on this Alberto :).  It also seems pretty smooth to me - have you updated the patch since yesterday? R+
Attachment #8523812 - Flags: ui-review?(epang) → ui-review+
Attachment #8523812 - Flags: review?(mhenretty)
Comment on attachment 8523812 [details] [review]
Link to Pull Request:

Looking real good on the phone! I had a couple of questions on github, please reflag me when you answer/address those.
Attachment #8523812 - Flags: review?(mhenretty)
Blocks: 1107244
Whiteboard: [systemsfe], ux-most-wanted-nov2014 → [systemsfe], ux-most-wanted-nov2014, 2x-uxnom
Comment on attachment 8523812 [details] [review]
Link to Pull Request:

I updated the PR with some fixes and also replied to the comments. Could you please re-check? Thanks!
Attachment #8523812 - Flags: review?(mhenretty)
Comment on attachment 8523812 [details] [review]
Link to Pull Request:

Looks good! Left a couple of tiny comments on github. Also, we should probably have an integration test for protecting the statusbar icon states when toggling the utility tray.
Attachment #8523812 - Flags: review?(mhenretty) → review+
Added integration tests and fixed comments.

Closed: 10 years ago
Resolution: --- → FIXED
Backed out for making permafail on OSX.
Resolution: FIXED → ---
Sorry, everything was green when I checked in:

I'll take a look. Thanks!
Looks like the failure rate is ~40% based on the retriggers I've done.
Relanded with tests fix:

Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Depends on: 1115047
Depends on: 1114764
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.