1074553 - [e10s] make social iframes remote

Status: RESOLVED WONTFIX

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

social iframes are not remote, there is no reason they shouldn't be (other than a chunk of work to make it happen).

Comment 1

[Mark Hammond [:markh] [:mhammond]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> social iframes are not remote, there is no reason they shouldn't be (other
> than a chunk of work to make it happen).

IIRC, there might also be some API issues - memory is vague, but I seem to recall there were at least some APIs we expose that are sync, and which couldn't be sync in that world.

(Not that that should stop us, but it might be worth investigating now so we can deprecate old stuff)

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: WIP

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: WIP

an actual patch rather than an empty patch :)

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: exploring remote=true

Took another spin on this.  The basic problem is the browser is never made visible if remote=true, and it seems there are assumptions in remote-browser that the browser is in a tab which would not be the case here.

Comment 5

[Mark Banner (:standard8)]

Is this likely to affect PanelFrame at any stage? We're currently only doing e10s for the conversation window since that's the high load one (and it was simpler/required for working with e10s).

We could do the panel, but our code/tests aren't going to work with that at the moment.

Comment 6

[Shane Caraveo (:mixedpuppy)]

My first step would be share since that is 99% of socialapi usage.  Given the problems I encountered with making the adjustment, I'm not sure how that will progress.

Comment 7

[Jim Mathies [:jimm]]

The sandboxing team isn't going to block on this for the first roll out of a level 1 sandbox on Windows. (The first content sandbox that will roll out.) But we're going to block on it for other content sandboxes and the next windows sandbox milestone. Can you all get this prioritized into your queues so it gets fixed fairly soon?

Comment 8

[Jim Mathies [:jimm]]

(I think we would want this fix in release by spring 2017.)

Comment 9

[Mark Banner (:standard8)]

(In reply to Jim Mathies [:jimm] from comment #7)
> The sandboxing team isn't going to block on this for the first roll out of a
> level 1 sandbox on Windows. (The first content sandbox that will roll out.)
> But we're going to block on it for other content sandboxes and the next
> windows sandbox milestone. Can you all get this prioritized into your queues
> so it gets fixed fairly soon?

Filed bug 1261350

Comment 10

[Jim Mathies [:jimm]]

Mark, can we close this out as wontfix? Or is this still valid for some social services we support?

Comment 11

[Mark Hammond [:markh] [:mhammond]]

(In reply to Jim Mathies [:jimm] from comment #10)
> Mark, can we close this out as wontfix? Or is this still valid for some
> social services we support?

Shane is probably in a better position to answer this.

Comment 12

[Shane Caraveo (:mixedpuppy)]

The share panel is still not remote.  If the new share button in the activitystream experiment were to replace it we wouldn't need to do anything.

Comment 13

[Jim Mathies [:jimm]]

kicking this out of sandboxing tracking

Comment 14

[BMO Automation]

SocialAPI was removed from Firefox 57 and is no longer available in any current release.