[e10s] make social iframes remote

RESOLVED WONTFIX

Status

defect
RESOLVED WONTFIX
5 years ago
4 months ago

People

(Reporter: mixedpuppy, Unassigned)

Tracking

32 Branch
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(e10slater)

Details

(Whiteboard: sb-)

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Description

5 years ago
social iframes are not remote, there is no reason they shouldn't be (other than a chunk of work to make it happen).
Reporter

Updated

5 years ago
Blocks: 1055590
Reporter

Updated

5 years ago
Blocks: e10s-social
(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> social iframes are not remote, there is no reason they shouldn't be (other
> than a chunk of work to make it happen).

IIRC, there might also be some API issues - memory is vague, but I seem to recall there were at least some APIs we expose that are sync, and which couldn't be sync in that world.

(Not that that should stop us, but it might be worth investigating now so we can deprecate old stuff)
Reporter

Updated

5 years ago
Depends on: 1072980
Reporter

Comment 2

5 years ago
Posted patch WIP (obsolete) — Splinter Review
Reporter

Comment 3

5 years ago
Posted patch WIPSplinter Review
an actual patch rather than an empty patch :)
Attachment #8535714 - Attachment is obsolete: true
Reporter

Updated

4 years ago
Depends on: 1162322
Reporter

Updated

4 years ago
Depends on: 1164979
Reporter

Comment 4

3 years ago
Took another spin on this.  The basic problem is the browser is never made visible if remote=true, and it seems there are assumptions in remote-browser that the browser is in a tab which would not be the case here.

Updated

3 years ago
Whiteboard: sb?
Is this likely to affect PanelFrame at any stage? We're currently only doing e10s for the conversation window since that's the high load one (and it was simpler/required for working with e10s).

We could do the panel, but our code/tests aren't going to work with that at the moment.
Reporter

Comment 6

3 years ago
My first step would be share since that is 99% of socialapi usage.  Given the problems I encountered with making the adjustment, I'm not sure how that will progress.

Updated

3 years ago
Whiteboard: sb? → sbwc1

Updated

3 years ago
Whiteboard: sbwc1 → sbwc2
The sandboxing team isn't going to block on this for the first roll out of a level 1 sandbox on Windows. (The first content sandbox that will roll out.) But we're going to block on it for other content sandboxes and the next windows sandbox milestone. Can you all get this prioritized into your queues so it gets fixed fairly soon?
Flags: needinfo?(standard8)
(I think we would want this fix in release by spring 2017.)
Reporter

Updated

3 years ago
Depends on: 1257316
Reporter

Updated

3 years ago
Depends on: 898706
Reporter

Updated

3 years ago
Depends on: 1257723
Blocks: 1261350
(In reply to Jim Mathies [:jimm] from comment #7)
> The sandboxing team isn't going to block on this for the first roll out of a
> level 1 sandbox on Windows. (The first content sandbox that will roll out.)
> But we're going to block on it for other content sandboxes and the next
> windows sandbox milestone. Can you all get this prioritized into your queues
> so it gets fixed fairly soon?

Filed bug 1261350
Flags: needinfo?(standard8)
Mark, can we close this out as wontfix? Or is this still valid for some social services we support?
Flags: needinfo?(markh)
(In reply to Jim Mathies [:jimm] from comment #10)
> Mark, can we close this out as wontfix? Or is this still valid for some
> social services we support?

Shane is probably in a better position to answer this.
Flags: needinfo?(markh) → needinfo?(mixedpuppy)
Reporter

Comment 12

3 years ago
The share panel is still not remote.  If the new share button in the activitystream experiment were to replace it we wouldn't need to do anything.
Flags: needinfo?(mixedpuppy)
kicking this out of sandboxing tracking
Whiteboard: sbwc2 → sb-

Comment 14

4 months ago
SocialAPI was removed from Firefox 57 and is no longer available in any current release.
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WONTFIX

Updated

4 months ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.