1074611 - B2G NFC: pass NDEF info to MozNFCTag.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This bug is filed for the Gecko part of Bug 1061512.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

There are 4 attributes that needs to be passed into MozNFCTag
1. ndefType
2. maxNDEFLength
3. isReadOnly
4. isFormatable

However we still need Bug 991970 to dispatch these informatio into DOM part.
If Bug 991970 stil needs a while, I will pass these information in Chrome process only in this bug, and file another bug for ContentProcess and DOM part.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 6

[Dimi Lee [:dimi]]

Comment on attachment 8511850 [details] [diff] [review]
Patch

Review of attachment 8511850 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/nsNfc.js
@@ +27,5 @@
>   * NFCTag
> + *
> + * @param window  global window object.
> + * @param sessionToken  session token received from Chrome process.
> + * @parem event   type of nsINfcTagEvent received from Chrome process.

According to bug 991970 comment 23, maybe parent process would be better

::: dom/webidl/MozNFCTag.webidl
@@ +26,5 @@
> +  "type2",
> +  "type3",
> +  "type4",
> +  "mifare_classic"
> +};

mifare classic is not defined in NFC forum, should we change the naming to NFCTagType ?

@@ +35,5 @@
> +  readonly attribute NFCForumTagType type;
> +  readonly attribute long maxNDEFSize;
> +  readonly attribute boolean isReadOnly;
> +  readonly attribute boolean isFormatable;
> +  readonly attribute boolean canBeMadeReadOnly;

For type, maxNDEFSize, isReadOnly, isFormatable and  canBeMAdeReadOnly, they are all related to NDEF infromation.
If there is no NDEF in this tag, these attributes will be meaningless.

As discussed, we can add nullable for those attributes.
Those attributes should be null when NfcMessageHandler::TechDiscoveredNotification get |ndefInfo| equals to false

@@ +41,3 @@
>    DOMRequest readNDEF();
>    DOMRequest writeNDEF(sequence<MozNDEFRecord> records);
>    DOMRequest makeReadOnlyNDEF();

|NDEF| may be removed because MozNFCTag will only operate on tag support NDEF

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #6)
> @@ +41,3 @@
> >    DOMRequest readNDEF();
> >    DOMRequest writeNDEF(sequence<MozNDEFRecord> records);
> >    DOMRequest makeReadOnlyNDEF();
> 
> |NDEF| may be removed because MozNFCTag will only operate on tag support NDEF

File Bug 1090803.

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2.

Comment 9

[Dimi Lee [:dimi]]

Comment on attachment 8513363 [details] [diff] [review]
Patch. v2.

Review of attachment 8513363 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8513363 [details] [diff] [review]
Patch. v2.

Review of attachment 8513363 [details] [diff] [review]:
-----------------------------------------------------------------

r? to smaug for the WebIDL change.

Comment 11

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v3.

rebase

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v4.

rebase

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/7f3fa88e0776

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7f3fa88e0776