1087925 - calling some NFCTag API should throw if the condition is not met.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 1074611 we will add maxNDEFSize, isReadOnly, canBeMadeReadOnly attributes into MozNFCTag.

So the following situations should throw.
1. Writing a NDEF that exceeds the maxNDEFSize or isReadOnly is true
2. call makeReadOnly when canBeMadeReadOnly is false.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Also calling format when the tag is not formatable should throw.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 3

[Dimi Lee [:dimi]]

Comment on attachment 8517321 [details] [diff] [review]
Patch

Review of attachment 8517321 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/nsNfc.js
@@ +78,5 @@
> +
> +    let ndefLen = 0;
> +    for (let record of records) {
> +      let idLen = record.id.length ? 1 : 0;
> +      let payloadLen = record.payload.length > 256 ? 4 : 1;

Check the NDEF spec,it doesn't define that a NDEF record with payload length less than 256, it must use a short record.
So we should check SR field in flag here.

Comment 4

[Dimi Lee [:dimi]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #3)
> Comment on attachment 8517321 [details] [diff] [review]
> Patch
> 
> Review of attachment 8517321 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/nfc/nsNfc.js
> @@ +78,5 @@
> > +
> > +    let ndefLen = 0;
> > +    for (let record of records) {
> > +      let idLen = record.id.length ? 1 : 0;
> > +      let payloadLen = record.payload.length > 256 ? 4 : 1;
> 
> Check the NDEF spec,it doesn't define that a NDEF record with payload length
> less than 256, it must use a short record.
> So we should check SR field in flag here.
After checking, the flag in NDEF is set in nfcd not in App, so current way is correct.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v2.

use record.size base on Bug 1094669.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8518682 [details] [diff] [review]
Patch v2.

Add r? to smaug for reviewing the DOMError part.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b6e75437bc68

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6e75437bc68