1074709 - As a user, I should be notified when the room is full

Status: RESOLVED FIXED

(Hello (Loop) :: Client, enhancement, P1)

Description

[Mark Banner (:standard8)]

Attachment: Expected UX

Comment 1

[Romain Testard [:RT]]

When 2 link clickers join a room prior to the link generator joining it - it seems the only workable option for Fx35 (will change as we implement 2+ rooms) is to provide the second link clicker with a "room full" notification, otherwise the link generator could be in a situation where he can't join his own room.

Clarification on behavior for Fx35 implementation:
* The 2nd link clicker joining concurrently will get "Room full notification"
* The link generator won't get notified as the second link clicker can't join the room

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Full Loop room end user notification.

Please note that the message is only displayed after the user attempts to join a full room.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8522174 [details] [diff] [review]
Full Loop room end user notification.

Review of attachment 8522174 [details] [diff] [review]:
-----------------------------------------------------------------

Not far off, though a few things to be addressed.

::: browser/components/loop/standalone/Makefile
@@ +14,5 @@
>  
>  LOOP_SERVER_URL := $(shell echo $${LOOP_SERVER_URL-http://localhost:5000})
>  LOOP_FEEDBACK_API_URL := $(shell echo $${LOOP_FEEDBACK_API_URL-"https://input.allizom.org/api/v1/feedback"})
>  LOOP_FEEDBACK_PRODUCT_NAME := $(shell echo $${LOOP_FEEDBACK_PRODUCT_NAME-Loop})
> +LOOP_BRAND_SHORTNAME := $(shell echo $${LOOP_BRAND_SHORTNAME-"Firefox"})

brandShortname is in the L10n file already.

@@ +19,4 @@
>  LOOP_BRAND_WEBSITE_URL := $(shell echo $${LOOP_BRAND_WEBSITE_URL-"https://www.mozilla.org/firefox/"})
>  LOOP_PRIVACY_WEBSITE_URL := $(shell echo $${LOOP_PRIVACY_WEBSITE_URL-"https://www.mozilla.org/privacy"})
>  LOOP_LEGAL_WEBSITE_URL := $(shell echo $${LOOP_LEGAL_WEBSITE_URL-"/legal/terms"})
> +LOOP_PRODUCT_NAME := $(shell echo $${LOOP_PRODUCT_NAME-"Firefox Hello"})

clientShortname2 should be used for this.

::: browser/components/loop/standalone/content/js/standaloneRoomViews.jsx
@@ +16,5 @@
>    var sharedViews = loop.shared.views;
>  
> +  var StandaloneRoomInfoArea = React.createClass({
> +    propTypes: {
> +      helper: React.PropTypes.instanceOf(loop.shared.utils.Helper).isRequired

this is one of those situations where I start to wonder if helper should be a "global" utility (not to be addressed here, of course).

@@ +22,5 @@
> +
> +    _renderCallToActionLink: function() {
> +      if (this.props.helper.isFirefox(navigator.userAgent)) {
> +        return (
> +          <a href={loop.config.learnMoreUrl} className="btn btn-info">

Can we get these to open in a new tab/window?

Comment 4

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Full Loop room end user notification. Patch v2

Addressed comments.

(In reply to Mark Banner (:standard8) from comment #3)
> Comment on attachment 8522174 [details] [diff] [review]
> this is one of those situations where I start to wonder if helper should be
> a "global" utility (not to be addressed here, of course).

Sure, filed bug 1098355.

> Can we get these to open in a new tab/window?

As per discussed on IRC with Darrin, I'll keep them that way.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8522246 [details] [diff] [review]
Full Loop room end user notification. Patch v2

Review of attachment 8522246 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great.

Comment 6

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/a9b6d02a6f63

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/be28aa12810c

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1063ba517149

Comment 9

[Romain Testard [:RT]]

It seems that 2 link clickers can get in the room causing the link generator to be unable to join it?

Comment 10

[Mark Banner (:standard8)]

(In reply to Romain Testard [:RT] from comment #9)
> It seems that 2 link clickers can get in the room causing the link generator
> to be unable to join it?

Fixed in bug 1107536.