Closed Bug 1074709 Opened 5 years ago Closed 5 years ago

As a user, I should be notified when the room is full

Categories

(Hello (Loop) :: Client, enhancement, P1)

enhancement
Points:
2

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Unassigned)

References

Details

(Whiteboard: [rooms][strings])

User Story

As a user, I should be notified when the room is full, so that I can decide what action to take

UX:
* If the room is full, display a message, and offer to download Firefox if the user does not have Firefox.

Strings:
* There are already two people in this conversation.
* Download Firefox to start your own

Implementation:
* When the room is full (before joining), adjust the standalone room view to show the room is full string when the room is full

Attachments

(2 files, 1 obsolete file)

Attached image Expected UX
No description provided.
User Story: (updated)
User Story: (updated)
backlog: --- → Fx35+
Priority: -- → P1
When 2 link clickers join a room prior to the link generator joining it - it seems the only workable option for Fx35 (will change as we implement 2+ rooms) is to provide the second link clicker with a "room full" notification, otherwise the link generator could be in a situation where he can't join his own room.

Clarification on behavior for Fx35 implementation:
* The 2nd link clicker joining concurrently will get "Room full notification"
* The link generator won't get notified as the second link clicker can't join the room
Please note that the message is only displayed after the user attempts to join a full room.
Attachment #8522174 - Flags: review?(standard8)
Assignee: nobody → nperriault
Points: --- → 2
Comment on attachment 8522174 [details] [diff] [review]
Full Loop room end user notification.

Review of attachment 8522174 [details] [diff] [review]:
-----------------------------------------------------------------

Not far off, though a few things to be addressed.

::: browser/components/loop/standalone/Makefile
@@ +14,5 @@
>  
>  LOOP_SERVER_URL := $(shell echo $${LOOP_SERVER_URL-http://localhost:5000})
>  LOOP_FEEDBACK_API_URL := $(shell echo $${LOOP_FEEDBACK_API_URL-"https://input.allizom.org/api/v1/feedback"})
>  LOOP_FEEDBACK_PRODUCT_NAME := $(shell echo $${LOOP_FEEDBACK_PRODUCT_NAME-Loop})
> +LOOP_BRAND_SHORTNAME := $(shell echo $${LOOP_BRAND_SHORTNAME-"Firefox"})

brandShortname is in the L10n file already.

@@ +19,4 @@
>  LOOP_BRAND_WEBSITE_URL := $(shell echo $${LOOP_BRAND_WEBSITE_URL-"https://www.mozilla.org/firefox/"})
>  LOOP_PRIVACY_WEBSITE_URL := $(shell echo $${LOOP_PRIVACY_WEBSITE_URL-"https://www.mozilla.org/privacy"})
>  LOOP_LEGAL_WEBSITE_URL := $(shell echo $${LOOP_LEGAL_WEBSITE_URL-"/legal/terms"})
> +LOOP_PRODUCT_NAME := $(shell echo $${LOOP_PRODUCT_NAME-"Firefox Hello"})

clientShortname2 should be used for this.

::: browser/components/loop/standalone/content/js/standaloneRoomViews.jsx
@@ +16,5 @@
>    var sharedViews = loop.shared.views;
>  
> +  var StandaloneRoomInfoArea = React.createClass({
> +    propTypes: {
> +      helper: React.PropTypes.instanceOf(loop.shared.utils.Helper).isRequired

this is one of those situations where I start to wonder if helper should be a "global" utility (not to be addressed here, of course).

@@ +22,5 @@
> +
> +    _renderCallToActionLink: function() {
> +      if (this.props.helper.isFirefox(navigator.userAgent)) {
> +        return (
> +          <a href={loop.config.learnMoreUrl} className="btn btn-info">

Can we get these to open in a new tab/window?
Attachment #8522174 - Flags: review?(standard8) → review-
Addressed comments.

(In reply to Mark Banner (:standard8) from comment #3)
> Comment on attachment 8522174 [details] [diff] [review]
> this is one of those situations where I start to wonder if helper should be
> a "global" utility (not to be addressed here, of course).

Sure, filed bug 1098355.

> Can we get these to open in a new tab/window?

As per discussed on IRC with Darrin, I'll keep them that way.
Attachment #8522174 - Attachment is obsolete: true
Attachment #8522246 - Flags: review?(standard8)
Comment on attachment 8522246 [details] [diff] [review]
Full Loop room end user notification. Patch v2

Review of attachment 8522246 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great.
Attachment #8522246 - Flags: review?(standard8) → review+
https://hg.mozilla.org/integration/fx-team/rev/a9b6d02a6f63
Iteration: --- → 36.3
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/be28aa12810c
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Flags: qe-verify-
It seems that 2 link clickers can get in the room causing the link generator to be unable to join it?
(In reply to Romain Testard [:RT] from comment #9)
> It seems that 2 link clickers can get in the room causing the link generator
> to be unable to join it?

Fixed in bug 1107536.
You need to log in before you can comment on or make changes to this bug.