Make "cancel all jobs" prompt to avoid accidental usage

RESOLVED FIXED

Status

Tree Management
Treeherder
P2
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: emorley, Assigned: KWierso)

Tracking

Details

Attachments

(1 attachment)

49 bytes, text/x-github-pull-request
emorley
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
The cancel all jobs button is more prominent than it is in TBPL (after bug 1059279), so I think we should make it prompt before performing the action.
(Assignee)

Comment 1

4 years ago
Created attachment 8513647 [details] [review]
Link to pr 252

TBPL's cancel all jobs button actually does prompt, so I just stole TBPL's code for the prompt.

I guess the only thing needed now before reverting bug 1089020 once this PR lands would be the changes suggested in bug 1075473.
Attachment #8513647 - Flags: review?(emorley)
(Assignee)

Updated

4 years ago
Assignee: nobody → kwierso
(Reporter)

Comment 2

4 years ago
Comment on attachment 8513647 [details] [review]
Link to pr 252

Thank you :-)
Attachment #8513647 - Flags: review?(emorley) → review+

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/860ace91df9562f2cd15724b6ab336b7bcce1ad3
Bug 1074858 - Make the cancel all jobs button prompt before doing anything

https://github.com/mozilla/treeherder-ui/commit/45d8eb823fa2917d794774d97401e0a1ee358a96
Merge pull request #252 from KWierso/CANCELALLSAFER

Bug 1074858 - Make the cancel all jobs button prompt before doing anything r=edmorley
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 4

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/cdbbed6b177cda6c2f455b191e3ff7d43b9f2702
Bug 1074858 - Make the cancel all jobs button prompt before doing anything

https://github.com/mozilla/treeherder/commit/ed0a228f3ec6a756df07b6162208cd60b75fb3cc
Merge pull request #252 from KWierso/CANCELALLSAFER

Bug 1074858 - Make the cancel all jobs button prompt before doing anything r=edmorley
You need to log in before you can comment on or make changes to this bug.