Closed Bug 1074858 Opened 10 years ago Closed 10 years ago

Make "cancel all jobs" prompt to avoid accidental usage

Categories

(Tree Management :: Treeherder, defect, P2)

Product:
Tree Management
Component:
Treeherder
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: KWierso)

References

Details

Attachments

(1 file)

Link to pr 252
49 bytes, text/x-github-pull-request
emorley
: review+
Details | Review
The cancel all jobs button is more prominent than it is in TBPL (after bug 1059279), so I think we should make it prompt before performing the action.
Attached file Link to pr 252 —
TBPL's cancel all jobs button actually does prompt, so I just stole TBPL's code for the prompt. I guess the only thing needed now before reverting bug 1089020 once this PR lands would be the changes suggested in bug 1075473.
Attachment #8513647 - Flags: review?(emorley)
Assignee: nobody → kwierso
Comment on attachment 8513647 [details] [review] Link to pr 252 Thank you :-)
Attachment #8513647 - Flags: review?(emorley) → review+
Commits pushed to master at https://github.com/mozilla/treeherder-ui https://github.com/mozilla/treeherder-ui/commit/860ace91df9562f2cd15724b6ab336b7bcce1ad3 Bug 1074858 - Make the cancel all jobs button prompt before doing anything https://github.com/mozilla/treeherder-ui/commit/45d8eb823fa2917d794774d97401e0a1ee358a96 Merge pull request #252 from KWierso/CANCELALLSAFER Bug 1074858 - Make the cancel all jobs button prompt before doing anything r=edmorley
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/cdbbed6b177cda6c2f455b191e3ff7d43b9f2702 Bug 1074858 - Make the cancel all jobs button prompt before doing anything https://github.com/mozilla/treeherder/commit/ed0a228f3ec6a756df07b6162208cd60b75fb3cc Merge pull request #252 from KWierso/CANCELALLSAFER Bug 1074858 - Make the cancel all jobs button prompt before doing anything r=edmorley
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: