107521 - Mac FileWidget implementation w/NavServices needs to support filters

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The UI for "Save With Images, Objects etc" requires this UI:

File name:     [ goats.html                         ]
Save as type:  [ Web Page, complete (*.htm;*.html :^]
                |Web Page, HTML only (*.htm;;*.html|
                |Text only (*.txt)                 |
                |All Files (*.*)                   |
                +----------------------------------+

The selection of the a specific filter causes different 'save modes' to be 
used (saving with images, just the html file, or perform a plaintext 
conversion). 

I'm told that currently our use of NavServices doesn't even use a filter list 
box (so I assume calls to appendFilter through nsIFilePicker are ignored). We 
need support for this, and we also need implementation of a method which 
gets/sets the index of the selected filter (0-based). 

This is currently blocking implementation of this feature on Mac, we can only 
get around it by disabling the feature on Mac ;)

Comment 1

[Simon Fraser [no longer active]]

Sounds like a job for rjc if you ask me  ;)

Comment 2

[Frank Tang]

If you need to fix this, please also consider bug 95478. 
The new CFString based method in navigation services seems have support for 
filer. 
I quickly scan the 
http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsFilePicker.cpp
It seems it have some filter code there. But maybe the filter implementation is 
not completed.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Can we get a target milestone in this?

I'm going to proceed with landing the Save with Objects feature but will 
disable it on the Mac. 

Comment 4

[Robert John Churchill]

Steve wants this one.

Comment 5

[sairuh (rarely reading bugmail)]

steve, what's the status on this?

Comment 6

[Steve Dagley]

it's on my 0.9.8 list

Comment 7

[Steve Dagley]

punting to 0.9.9 as crasher bug #99561 has become a priority

Comment 8

[TommyBee (No E-mail)]

Hmm... I think bug 123178 that I posted yesterday is either a duplicate or
related.  (Probably fixing this bug would fix that one as well, although the new
bug is really a symptom of this one.)  Perhaps the same is true of bug 123174.

Comment 9

[Steve Dagley]

*** Bug 123178 has been marked as a duplicate of this bug. ***

Comment 10

[Peter Trudelle]

nsbeta1+ per ADT triage team

Comment 11

[TommyBee (No E-mail)]

How likely is this to hit for 0.9.9?  I've got some web pages that remain
bookmarked or in e-mail messages because I can't figure out how to save them the
way I want them.  (Sometimes they save with images when I don't want them to;
others, they save without images when I want them to.  The pages that don't end
in .html are the worst.)

Comment 12

[Steve Dagley]

-> Moz1.0 (sorry tommy)

Comment 13

[TommyBee (No E-mail)]

*sigh*  ;-)  That's all right.  Just didn't want to be getting my hopes up or
anything.  Maybe in a couple of years I might know how to fix it myself, but
right now my programming skills only go up to a point.  Thank goodness the
University of Alabama CS department focuses on C++.

Comment 14

[Greg K.]

Removing mozilla0.9.8 keyword as that milestone is passed, and also removing
resolved/fixed bugs from blocks list as open bugs don't block fixed bugs.

Comment 15

[Steve Dagley]

Greg, please never touch dependencies in my bugs.  I may want to refer to them
to verify something.

Comment 16

[Steve Dagley]

Attachment: Patch to implement support for Format popup menu in PutFile dialogs

Comment 17

[Steve Dagley]

Attachment: Patch to implement support for Format popup menu in PutFile dialogs

Fixed some tab/whitespace probs in the previous patch

Comment 18

[Conrad Carlen (not reading bugmail)]

Comment on attachment 74018 [details] [diff] [review]
Patch to implement support for Format popup menu in PutFile dialogs

r=ccarlen

Comment 19

[Mike Pinkerton (not reading bugmail)]

+void nsFilePicker :: HandleShowPopupMenuSelect(NavCBRecPtr callBackParms)
+{
+       if (callBackParms)
+       {

this entire section of code has tabs. 

+       nsFilePicker* self = NS_REINTERPRET_CAST(nsFilePicker*, callbackUD);
+       switch (msg)
+       {
+               case kNavCBEvent:

ditto

+                               case updateEvt:
+                               WindowPtr window = reinterpret_cast<WindowPtr>
(cbRec->eventData.eventDataParms.event->message);
+                               nsCOMPtr<nsIEventSink> sink;
+                               nsToolkit::GetWindowEventSink (window, 
getter_AddRefs(sink));
+                               if (sink)

this will break mach-o (jump past initializer). you need to enclose the case w/in 
a block to scope the compPtr.

Question: how does this behave on 8.6 with TARGET_CARBON? You mention you're 
using NavServices3. Will it just crash?.

Comment 20

[Steve Dagley]

Tabs are fixed

{} added for case kNavCBEvent: to scope the compPtr

CarbonLib 1.1 and later is listed as requirment for Nav Services 3.0

Comment 21

[Steve Dagley]

Attachment: Patch incorporating comments from ccarlen, pink and scc. Now tab free

Ok, I think the last of the damn tabs have been removed.  Here's the final
version of the patch incorporating everybody's feedback.  And I added my name
as a contributor lest folks think Pav is a Mac engineer :-)

Comment 22

[Scott Collins]

Comment on attachment 74197 [details] [diff] [review]
Patch incorporating comments from ccarlen, pink and scc.  Now tab free

sr=scc

Comment 23

[Conrad Carlen (not reading bugmail)]

Comment on attachment 74197 [details] [diff] [review]
Patch incorporating comments from ccarlen, pink and scc.  Now tab free

r=ccarlen

Comment 24

[Asa Dotzler [:asa]]

Comment on attachment 74197 [details] [diff] [review]
Patch incorporating comments from ccarlen, pink and scc.  Now tab free

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 25

[Steve Dagley]

Fix checked in

Comment 26

[TommyBee (No E-mail)]

It works for me on build 2002031509 on Mac OS 9.2.2 -- woo hoo!
Thanks, Steve and all!  :-)

Comment 27

[sairuh (rarely reading bugmail)]

vrfy fixed using 2002.03.20.08 comm bits on mac 10.1.3 and 9.1 (under classic emul).

side note: the format option is not remembered, so filed bug 132467.

Comment 28

[TommyBee (No E-mail)]

*** Bug 123174 has been marked as a duplicate of this bug. ***

Comment 29

[Dan M]

*** Bug 9621 has been marked as a duplicate of this bug. ***

Comment 30

[Dan M]

*** Bug 9620 has been marked as a duplicate of this bug. ***