1075689 - Please Push The Open Standard Theme & Plugins To Dev

Status: RESOLVED FIXED

(Infrastructure & Operations :: IT-Managed Tools, task)

Description

[Ben (:bensternthal)]

Please update the theme and one plugin from our github repo to the dev install of the open standard blog.

https://github.com/mozilla/theopenstandard

Theme
https://github.com/mozilla/theopenstandard/tree/master/themes/theopenstandard

Plugin
https://github.com/mozilla/theopenstandard/tree/master/plugins/the-open-standard-social

Please note the above plugin is custom and developed by our consultants.

Thanks again!

Comment 1

[Chris Turra [:cturra]]

updates pushed as requested. there appeared to be some theme updated, but no plugin changes. is that correct?

  https://github.com/mozilla/theopenstandard/tree/master/plugins/the-open-standard-social

Comment 2

[Ben (:bensternthal)]

Please also update that plugin, it was changed as part of the latest PR but it shows up as being changed "days ago"

This may be due to our consultant developing in another github repo and moving those changes here.

Comment 3

[Ben (:bensternthal)]

Chris, did you do a full theme overwrite?

I ask because it looks pretty wonky.. and when i test on my local machine everything looks OK

Comment 4

[Rex Vokey]

Chris - we have a theory that it could be that short_open_tags is not enabled on the server's php.ini.

We could:
1) Enable short_open_tags

or 2) Change all short open tags to long open tags.

We'd prefer to go with option 1, if that's possible.

Comment 5

[Chris Turra [:cturra]]

(In reply to Rex Vokey from comment #4)
> 
> We could:
> 1) Enable short_open_tags

i'd rather not do this. here is the comment in a default php.ini on the subject...

; This directive determines whether or not PHP will recognize code between
; <? and ?> tags as PHP source which should be processed as such. It's been
; recommended for several years that you not use the short tag "short cut" and
; instead to use the full <?php and ?> tag combination. With the wide spread use
; of XML and use of these tags by other languages, the server can become easily
; confused and end up parsing the wrong code in the wrong context. But because
; this short cut has been a feature for such a long time, it's currently still
; supported for backwards compatibility, but we recommend you don't use them.

Comment 6

[Jake Maul [:jakem]]

Piling on, in our env, this app is actually run alongside a number of other php apps so this would affect more than just this one theme on this one blog. It'd definitely be preferable to use the longer tag so we don't risk confusing other apps.

Comment 7

[Ben (:bensternthal)]

Understood and our code is updated.

Looks like rex just fixed so can you repull the theme and plugins (in this PR they added an addtional one).

Thanks!

Comment 8

[Chris Turra [:cturra]]

after the theme upgrade, the site is returning a http 500 error. i turned on wp_debug so you could see what it's complaining about.

Comment 9

[Rex Vokey]

Looks like it's missing the simple-fields.php file in the theme folder -- could that have not been pulled over somehow?

Comment 10

[Ben (:bensternthal)]

Failed opening required 'simple-fields.php' (include_path='.:/usr/share/pear:/usr/share/php') in /data/www/blog-dev.allizom.org/wp-content/themes/theopenstandard/functions.php on line 118 

Double checking this is confirmed in the repo. Chris can you advise?

Comment 12

[Chris Turra [:cturra]]

moving over from bug 1077001...

(In reply to Rex Vokey from comment #0)
> Please update the theme and add plugin from to the dev install of the open
> standard blog.
> 
> https://github.com/mozilla/theopenstandard
> 
> Theme
> https://github.com/mozilla/theopenstandard/tree/master/themes/theopenstandard
> 
> Plugin
> http://plugins.svn.wordpress.org/wordpress-23-related-posts-plugin/tags/3.5.
> 1/
> 
> When installing/enabling the Related Posts plugin, please have debugging
> turned on, so we can isolate any issues. It's now been tested on other
> multi-site installations without any issues, so we'd like to see if we can
> get it working here.
> 
> Thanks again!

Comment 13

[Chris Turra [:cturra]]

theme updated, plug reinstalled and debug enabled.

Comment 14

[Rex Vokey]

Thanks Chris.

I apologize for the error, but I realized I linked to the wrong Related Posts plugin. 

Here's the correct one: http://plugins.svn.wordpress.org/related-posts-for-wp/tags/1.6.3/

Again - sorry for the mistake. 

We now have more code to pull -- including another plugin we created for the site. So I'd like to request another update of the theme and plugins.

Here's a summary of the plugin updates for this round-

Deactivate and remove:
WordPress Related Posts

Add and activate:
http://plugins.svn.wordpress.org/related-posts-for-wp/tags/1.6.3/
http://plugins.svn.wordpress.org/contact-form-7/tags/3.9.3/
https://github.com/mozilla/theopenstandard/tree/master/plugins/the-open-standard-search

And update theme:
https://github.com/mozilla/theopenstandard/tree/master/themes/theopenstandard

Thanks again!

Comment 15

[Chris Turra [:cturra]]

done and done.

Comment 16

[Rex Vokey]

OK, it looks as though the issue *might* be getting caused by the fact of the debug output itself being returned in the ajax response when the plugin tries linking posts. Can we turn off debugging and see if it works?

Comment 17

[Chris Turra [:cturra]]

debug disabled as requested.

Comment 18

[Rex Vokey]

Thank you! Plugin operational.

Comment 19

[Ben (:bensternthal)]

Re-opening to do another deployment to dev.

Please update plugins and theme as usual.

Thanks.

Comment 20

[Chris Turra [:cturra]]

go home :kanban, you're drunk.

:bensternthal - i pushed an update to the theme and plugins to dev with the work on bug 1080248.

Comment 21

[Ben (:bensternthal)]

got it.. thanks!