1076824 - All jobs in the pinboard should be highlighted in the main jobs list

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Carsten Book [:Tomcat]]

Having a bustage with lots of things to classify brings for me in the daily work the problem that its not clear what all is selected now and in the pinboard.

Maybe we could highlight all of the stuff that is selected in the pinboard, would save some time before you have to go over the results again and do a classification for the missed results :)

Comment 1

[Ed Morley [:emorley]]

Yeah definitely agree, this caught me out the other day too - thank you for filing :-)

Comment 2

[Ed Morley [:emorley]]

STR:
1) Open https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central
2) Ctrl + click any visible job
3) Ctrl + click another visible job

Expected:
Two jobs in the pinboard, and some way to tell which jobs have been added to the pinboard when looking at the list of all jobs shown for the push.

Actual:
Two jobs in the pinboard, and only one job highlighted in the main job list.

Comment 3

[Jonathan French (:jfrench)]

Perhaps we could do some sort of 2-3px blue-gradient halo around the not-primary-selected-but-pinned-jobs in the resultset job block, whose blue halo color would match that of the pinboard itself.

It would work for color-blind users as well even if they couldn't discern blue. Perhaps we'd want some sort of aria-label on those job(s) so if the user steps across them via < or > selection, they would be read as "[job-type]-pinned" also?

Comment 4

[MikeLing]

Hi~ I would like to work on it after bug 1160873 been fixed and I notice bug 1074385 is similar to this bug, maybe I could fix them both at the same time :)

Comment 5

[Jonathan French (:jfrench)]

Hi Mike, yes it looks like bug 1160873 is getting closer to being landed. 1074385 is a different bug to this one but we can assign you whichever of the two bugs you prefer to do first. :)

Comment 6

[MikeLing]

(In reply to Jonathan French (:jfrench) from comment #5)
> Hi Mike, yes it looks like bug 1160873 is getting closer to being landed.
> 1074385 is a different bug to this one but we can assign you whichever of
> the two bugs you prefer to do first. :)

Thank you for your trust(^_^)

Could you tell me more about this issue? Which file or files I should check and work on? Thank you very much!

Comment 7

[Jonathan French (:jfrench)]

Whichever bug you prefer to work on, it's up to you. Let me know.

I think perhaps bug 1074385 might be more straightforward, it looks like some angular. You might just want to add a needinfo from the submitter or Ed to it if you need clarification. That bug is failure summary bug interaction (in the Failure Summary tab at the bottom of the app when a job is selected).

This bug (1076824 we are commenting in right now) might be roughly similar. I just did a UI mock for it and am going to add it to this bug. On first glance it would require conditionally adding btn-lg-xform to any job that is pinned, and then negating the scale and -ve margin properties, unless it is the selected job. The mockup I will attach supersedes my comment 3 above. 

Feel free to join us on IRC if you have any questions too, it's often a quicker means of interaction. :)

Comment 8

[Jonathan French (:jfrench)]

Attachment: pinnedJobsMockupRev1

This UI mockup was discussed in channel with RyanVM and jmaher, so attaching it for feedback. To me it seems the simplest solution rather than adding some new kind of treatment.

1) We apply our 'selected' styling against any pinned job, but negate the -ve margin and scale
2) We continue to apply our current selected styling to the actual selected job. So only its larger scale is what denotes selection.

I think when it's applied against adjacent pinned jobs (ie. not selected, small size) we'll have co-incidental borders, but I don't think that will look too terrible. We'll have to see in a working branch.

Comment 9

[MikeLing]

(In reply to Jonathan French (:jfrench) from comment #7)
> Whichever bug you prefer to work on, it's up to you. Let me know.
> 

Great! I think this issue maybe a good start :)

Comment 10

[Jonathan French (:jfrench)]

Ok, thanks Mike :) You will want to hold off actual work until we hear back from Carsten he agrees with the proposed mockup and approach.

In the meantime you can inspect and browse/search the treeherder-ui Github repo to familiarize yourself with how the css styles are presently applied during selection.

Comment 11

[MikeLing]

(In reply to Jonathan French (:jfrench) from comment #10)
> Ok, thanks Mike :) You will want to hold off actual work until we hear back
> from Carsten he agrees with the proposed mockup and approach.
> 

Hello French :)

If we can't start to work this issue yet, could you assign another bug(like Bug 1062995) to me? I could start to work with it first and wait for the feedback about this bug at the same time.

Thank you very much!

Comment 12

[Jonathan French (:jfrench)]

Mike wants to fix a more complex bug 1125232, so I am unassigning this one. After we hear back from Carsten on the mockup here, if still unassigned I will put it in my bug queue.

Comment 13

[Carsten Book [:Tomcat]]

looks great thanks!

Comment 14

[Jonathan French (:jfrench)]

We will also have to support selected adjacent job counts (bug 1163064) - eg. jobs of differing status that have been selected in a group and their job group collapsed back down to counts. Knowing the complexity of camd's upcoming change (https://github.com/mozilla/treeherder/pull/872/files), if we don't get that behavior for free, this bug may not be suitable as a good-next bug.

That would be revealed in trying to apply a potential fix and seeing how the counts behave, after camd's fix is landed.

Comment 15

[Pas]

Hi, I am new to fixing bugs and I would like to work on the bug please.

Comment 16

[William Lachance (:wlach)]

(In reply to Pas from comment #15)
> Hi, I am new to fixing bugs and I would like to work on the bug please.

Hi Pas, I'm not sure if this is a great first bug as it's rather complex and doesn't have a mentor assigned.

But if you're still interested let us know and we can assign it to you.