Closed Bug 1077358 Opened 10 years ago Closed 10 years ago

[10.10] Browser chrome turns black when opening sidebar in window without hardware acceleration (BasicLayers)

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla35
Tracking Status
firefox34 + verified
firefox35 --- verified

People

(Reporter: mstange, Assigned: mstange)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We clear the sidebar background using a BasicColorLayer with a transparent color and blend mode OP_SOURCE. OP_SOURCE is unbounded in Moz2D so it doesn't only erase the sidebar but everything that's been painted into the window until that point.
Attachment #8499481 - Flags: review?(bas)
Comment on attachment 8499481 [details] [diff] [review]
clip color layer drawing

Review of attachment 8499481 [details] [diff] [review]:
-----------------------------------------------------------------

OP_SOURCE is actually really slow on D2D. We should probably fix that as well and do either an OVER or a ClearRect and an OVER
Attachment #8499481 - Flags: review?(bas) → review+
This won't be a problem since at the moment OS X is the only platform on which you can even get a color layer with blend mode OP_SOURCE (since that's the only platform on which nsITheme::NeedToClearBackgroundBehindWidget returns true in some cases).
[Tracking Requested - why for this release]:
black backgrounds for machines without basiclayers and/or transparency is pretty sad. AIUI this only affects yosemite, so it's not the end of the world, but it'd be Really Good if we can avoid shipping this.
Tracking for 34 as we're fixing a number of Yosemite issues in this release.
https://hg.mozilla.org/mozilla-central/rev/22d7b9f14890
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Is this safe for uplift to 34 while that's still on Aurora? :-)
Flags: needinfo?(mstange)
Comment on attachment 8499481 [details] [diff] [review]
clip color layer drawing

Absolutely.

Approval Request Comment
[Feature/regressing bug #]: Sidebar vibrancy (bug 1051522 + bug 1059278)
[User impact if declined]: unexpected black areas for some users on 10.10
[Describe test coverage new/current, TBPL]: none
[Risks and why]: low, the fix is simple and well-understood
[String/UUID change made/needed]: none
Attachment #8499481 - Flags: approval-mozilla-aurora?
Flags: needinfo?(mstange)
Comment on attachment 8499481 [details] [diff] [review]
clip color layer drawing

Aurora+
Attachment #8499481 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
Reproduced the initial issue using an old Nightly (2014-10-03) on Mac OS X 10.10, verified that the issue is fixed on latest Nightly build, latest Aurora/Developer Edition and Firefox 34 beta 8.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.