Closed Bug 1077423 Opened 8 years ago Closed 8 years ago

overhaul generic feedback form style

Categories

(Input Graveyard :: Submission, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: u=user c=feedback p=5 s=input.2014q4)

+++ This bug was initially created as a clone of Bug #979486 +++

This bug covers restyling the generic feedback forms and related flow pages (thank you, unknown product, ...).

All of these template, css and js files should be in fjord/feedback/ .
I want to do the following when restyling:

1. Write the CSS so it's mobile-first with media query breakpoints at 768px and 1024px.

2. Make sure that the page can be scrolled so that users can move to the bottom of it. (bug #1073908)

3. Support the following test devices:

   We're looking at supporting the following hardware "use cases":

   1. desktop (landscape, > 900px width)
   2. laptop (landscape, > 900px width)
   3. tablet (landscape)
   4. tablet (portrait)
   5. low-end phone (portrait)

4. Be responsive

I was thinking about using Schalk's Sandstone theme, but I'm not sure that's in good enough shape to use, so I think instead I'm going to go with a minimal theme based on Rehan's changes to the Firefox OS form.

This needs to be done before we can update the generic feedback form for 5-thing ratings because the current form isn't responsive at all.
Assignee: nobody → willkg
Blocks: 1020307
I threw together a prototype and passed it around to various people to get wording and phrasing approved as well getting thoughts on flow, colors, layout, etc.

I'm pulling that into the generic feedback dev form now. Then I need to re-add field validation and some other things. I'm pretty close, though.
Status: NEW → ASSIGNED
Whiteboard: u=user c=feedback p= s=input.2014q4 → u=user c=feedback p=5 s=input.2014q4
Tyler mentioned that we should add a link to SUMO on the Thank you page since we've removed it from the form. I made bug #1097203 for that.
Landed in master:

https://github.com/mozilla/fjord/commit/da31b47f1942fa2c3dd9cff7d410f9d3803c39f7
https://github.com/mozilla/fjord/commit/46b5897722c589f6f89ce2b12e5fe46118014ac2

Pushing to stage today and will push to prod on Monday.

Next step is to get the strings localized.
Early Thursday, Kadir and I synced strings with Verbatim. I sent out an email to the l10n mailing list asking for help with translations.

Later Thursday, Besnik_b pointed out a bunch of issues with the strings, so I sent an email asking people to wait on translation while I cleaned things up. I removed a bunch of dead code, removed a bunch of gettext calls in sections of the site that shouldn't be translated, fixed some typos and fixed some strings to be clearer.

Early Friday (today), I sent another email to the l10n mailing list asking people to resume translations.

Hopefully the translating is easy and quick. I created bug #1099138 to cover waiting for translations and then making the new form live.

Marking this one as FIXED now. Any issues with the form should get new bugs.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.