1079128 - No buttons on incoming call notification screen when link clicker selects "Voice conversation" - Aurora issue only

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Romain Testard [:RT]]

Environment: latest Aurora on Windows 8.1
This issue does not apply to the last nightly.

Steps to reproduce
1 Share a call-back lick
2 Click link and select "Voice conversation"
3 Incoming call notification window appears on the link generator browser although no buttons are available 

This is a fairly big issue given there is no way for the link generator to get the browser to stop ringing (unable to revoke the URL).

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: fully remove Loop "accept/cancel" tooltips in Aurora

when the buttons are flipped, it was looking for a tooltip on the secondary button that was no longer there.  Far simpler and more consistent is to remove both tooltips on Aurora (instead of only having audio).  Note: no string change, just js/jsx change to remove the reference.

Comment 2

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8501159 [details] [diff] [review]
fully remove Loop "accept/cancel" tooltips in Aurora

Review of attachment 8501159 [details] [diff] [review]:
-----------------------------------------------------------------

Transfering review to :Standard8 after discussing about it on IRC.

Comment 3

[Mark Banner (:standard8)]

Ah, so this is caused by bug 1042060 not being able to uplift the string.

Comment 4

[Mark Banner (:standard8)]

Attachment: Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Slightly different patch to display the tooltip when it is possible to do so. I've tested this locally on my aurora build.

I've filed bug 1079814 to create a functional test covering audio calls, and bug 1080387 to refactor the AcceptCallButton so that it would be more testable for unit tests.

Comment 5

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Comment on attachment 8502327 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Review of attachment 8502327 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me with comment addressed.

::: browser/components/loop/content/js/conversation.jsx
@@ +169,5 @@
>      },
>  
>      render: function() {
>        var mode = this.props.mode;
> +      var secondaryTooltip = mode.secondary.tooltip ? mozL10n.get(mode.secondary.tooltip) : "";

Please add a comment explaining why is that plus a reference to bug 1080387.

Comment 6

[Mark Banner (:standard8)]

Attachment: Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Updated patch to add the comment.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8502365 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

This is an aurora only patch.

Approval Request Comment
[Feature/regressing bug #]: Regressed by bug 1042060 not being able to uplift a string to aurora.
[User impact if declined]: Incoming audio-only calls will result in a blank conversation window - the user will not be able to accept.
[Describe test coverage new/current, TBPL]: Manually tested on aurora. Unfortunately not automated test coverage - follow-up bugs that are more intensive fixes have been filed.
[Risks and why]: Low, handles the missing tooltip by replacing it with an empty string.
[String/UUID change made/needed]: None

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7f910ea634e

Comment 9

[Mark Banner (:standard8)]

Marking as fixed, as 34 was the only place this was needed.

Comment 10

[u279076]

Florin, can you please have someone on your team check this in the latest Beta?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8502365 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Already landed, tacking for posterity.

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 Win 8.1 x64

Comment 13

[u279076]

Does this have developer automation test coverage?

Comment 14

[Mark Banner (:standard8)]

Clearing in-testsuite requests for features that are being removed from Hello as part of te user journey work in bug 1209713.