No buttons on incoming call notification screen when link clicker selects "Voice conversation" - Aurora issue only

VERIFIED FIXED in Firefox 34

Status

Hello (Loop)
Client
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: RT, Assigned: standard8)

Tracking

unspecified
mozilla34
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox33 unaffected, firefox34 verified, firefox35 unaffected)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

3 years ago
Environment: latest Aurora on Windows 8.1
This issue does not apply to the last nightly.

Steps to reproduce
1 Share a call-back lick
2 Click link and select "Voice conversation"
3 Incoming call notification window appears on the link generator browser although no buttons are available 

This is a fairly big issue given there is no way for the link generator to get the browser to stop ringing (unable to revoke the URL).
Created attachment 8501159 [details] [diff] [review]
fully remove Loop "accept/cancel" tooltips in Aurora

when the buttons are flipped, it was looking for a tooltip on the secondary button that was no longer there.  Far simpler and more consistent is to remove both tooltips on Aurora (instead of only having audio).  Note: no string change, just js/jsx change to remove the reference.

Updated

3 years ago
Attachment #8501159 - Flags: review?(nperriault)
Whiteboard: [loop-uplift]
Comment on attachment 8501159 [details] [diff] [review]
fully remove Loop "accept/cancel" tooltips in Aurora

Review of attachment 8501159 [details] [diff] [review]:
-----------------------------------------------------------------

Transfering review to :Standard8 after discussing about it on IRC.
Attachment #8501159 - Flags: review?(nperriault) → review?(standard8)
(Assignee)

Comment 3

3 years ago
Ah, so this is caused by bug 1042060 not being able to uplift the string.
Depends on: 1042060
(Assignee)

Updated

3 years ago
Blocks: 1080387
(Assignee)

Comment 4

3 years ago
Created attachment 8502327 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Slightly different patch to display the tooltip when it is possible to do so. I've tested this locally on my aurora build.

I've filed bug 1079814 to create a functional test covering audio calls, and bug 1080387 to refactor the AcceptCallButton so that it would be more testable for unit tests.
Attachment #8501159 - Attachment is obsolete: true
Attachment #8501159 - Flags: review?(standard8)
Attachment #8502327 - Flags: review?(nperriault)
(Assignee)

Updated

3 years ago
Assignee: nobody → standard8
OS: Windows 8 → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla35
Comment on attachment 8502327 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Review of attachment 8502327 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=me with comment addressed.

::: browser/components/loop/content/js/conversation.jsx
@@ +169,5 @@
>      },
>  
>      render: function() {
>        var mode = this.props.mode;
> +      var secondaryTooltip = mode.secondary.tooltip ? mozL10n.get(mode.secondary.tooltip) : "";

Please add a comment explaining why is that plus a reference to bug 1080387.
Attachment #8502327 - Flags: review?(nperriault) → review+
(Assignee)

Updated

3 years ago
Target Milestone: mozilla35 → mozilla34
(Assignee)

Comment 6

3 years ago
Created attachment 8502365 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Updated patch to add the comment.
Attachment #8502327 - Attachment is obsolete: true
Attachment #8502365 - Flags: review+
(Assignee)

Comment 7

3 years ago
Comment on attachment 8502365 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

This is an aurora only patch.

Approval Request Comment
[Feature/regressing bug #]: Regressed by bug 1042060 not being able to uplift a string to aurora.
[User impact if declined]: Incoming audio-only calls will result in a blank conversation window - the user will not be able to accept.
[Describe test coverage new/current, TBPL]: Manually tested on aurora. Unfortunately not automated test coverage - follow-up bugs that are more intensive fixes have been filed.
[Risks and why]: Low, handles the missing tooltip by replacing it with an empty string.
[String/UUID change made/needed]: None
Attachment #8502365 - Flags: approval-mozilla-aurora?

Updated

3 years ago
status-firefox34: --- → fixed
(Assignee)

Comment 9

3 years ago
Marking as fixed, as 34 was the only place this was needed.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Florin, can you please have someone on your team check this in the latest Beta?
Flags: qe-verify+
Flags: needinfo?(florin.mezei)
QA Contact: anthony.s.hughes
status-firefox33: --- → unaffected
status-firefox35: --- → unaffected
Flags: needinfo?(florin.mezei)
QA Contact: paul.silaghi
Comment on attachment 8502365 [details] [diff] [review]
Display tooltip when possible for Loop accept/cancel conversation buttons on aurora.

Already landed, tacking for posterity.
Attachment #8502365 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed FF 34b1 Win 8.1 x64
Status: RESOLVED → VERIFIED
status-firefox34: fixed → verified

Updated

3 years ago
Iteration: --- → 35.3
Does this have developer automation test coverage?
Flags: in-testsuite?
(Assignee)

Comment 14

2 years ago
Clearing in-testsuite requests for features that are being removed from Hello as part of te user journey work in bug 1209713.
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.