Closed Bug 1079164 Opened 10 years ago Closed 10 years ago

Logical coordinate support for grid

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: smontagu, Assigned: MatsPalmgren_bugz)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Initial testcases for CSS grid in vertical writing mode
15.09 KB, patch
MatsPalmgren_bugz
: review+
Details | Diff | Splinter Review
Part of support for vertical text
This may fall to whoever writes the grid layout code, which hasn't been done yet.
(In reply to David Baron [:dbaron] ⏰UTC-7 from comment #1) > This may fall to whoever writes the grid layout code +cc: mats
All Grid code is using logical coordinates already. Let me know if you see any issues. (I haven't tested it in vertical mode.)
In a *very* brief test just now (i.e., I took a couple of the grid reftests, and changed writing-mode on the <body> element) things seemed to be working fine. Let's have a few testcases that specifically check the behavior of Grid with vertical modes, to confirm that it's doing the right thing; then I think we can call this done. Awesome!
Here are a couple of vertical versions of one of the grid tests. Note that the vertical-rl version requires bug 1153140 before it will pass.
Attachment #8590785 - Flags: review?(mats)
Depends on: 1153140
Just a minor update: as we don't yet propagate writing-mode from <body> to the ICB, it's better to set it on the <html> element.
Attachment #8590791 - Flags: review?(mats)
Attachment #8590785 - Attachment is obsolete: true
Attachment #8590785 - Flags: review?(mats)
Comment on attachment 8590791 [details] [diff] [review] Initial testcases for CSS grid in vertical writing mode Thanks!
Attachment #8590791 - Flags: review?(mats) → review+
Assignee: nobody → mats
https://hg.mozilla.org/mozilla-central/rev/28af6476176a
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Depends on: 1163432
Depends on: 1171773
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: