1153140 - [css-grid][RTL] grid contents in right-to-left mode offset by left+right border width

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: testcase for css-grid with dir=rtl

See testcase: the grid items are offset to the left by an amount that depends on the border width of the containing grid.

A similar problem occurs with writing-mode:vertical-rl.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Include borderPadding width in the containerWidth for grid item placement

I don't know if this is the best place to handle it, but a simple fix to gridWidth in nsGridContainerFrame::ReflowChildren appears to resolve the problem.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: dir=rtl versions of a couple of the grid reftests

For sanity-checking, here are RTL versions of a couple of the reftests; these fail without the gridWidth fix, and pass with it.

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8590714 [details] [diff] [review]
Include borderPadding width in the containerWidth for grid item placement

LGTM.  Could you rename it to 'containerWidth' while you're here?
I think it would be more accurate.

I think I just misunderstood what aContainerWidth meant in the
ReflowChild/FinishReflowChild signatures.  Perhaps it's worth a adding
a @param there that explains it's the container's border-box width?

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/646e795e8e46
https://hg.mozilla.org/integration/mozilla-inbound/rev/129ed36713d3

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Mats Palmgren (:mats) from comment #3)
> I think I just misunderstood what aContainerWidth meant in the
> ReflowChild/FinishReflowChild signatures.  Perhaps it's worth a adding
> a @param there that explains it's the container's border-box width?

Good idea, done.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/646e795e8e46
https://hg.mozilla.org/mozilla-central/rev/129ed36713d3