1079953 - [Lockscreen][Camera] Non-function UI in preview when camera app is launched from the Lockscreen with Passcode enabled.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Martin Shuman [:Marty]]

Attachment: Status_Bar_Lockscreen_Screenshot.png

Description:
The status bar icons (battery, SIM, WiFi) are visible in the Camera app when launched from the Lockscreen, and will overlap camera UI, especially in the Snapshot Preview.

Note: These status bar icons are only present when the user has a Passcode enabled.  Launching the camera app from the Lockscreen (without a Passcode), or launching from the Homescreen does not display the status bar icons.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141008000201
2) Enable Lock screen and Passcode lock in Settings > Screen lock.
3) Lock the device.
4) Press the Power Button and launch the Camera app without unlocking the phone.
5) Take a picture, then view the photo preview.
  
Actual:
Status Bar icons overlap the Camera UI
  
Expected: 
Status Bar icons do not overlap the Camera UI
  
Environmental Variables:
Device: Flame 2.1
BuildID: 20141008000201
Gaia: d71f8804d7229f4b354259d5d8543c25b4796064
Gecko: 7fa82c9acdf2
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: v184
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Note: This occurs with both the v180 and v184 base firmware

Repro frequency: 5/5
See attached: screenshot

-------------------------------------------------------------------------

This issue DOES occur in Flame 2.2
Status bar icons overlap the Camera UI

Environmental Variables:
Device: Flame 2.2 Master
BuildID: 20141008040203
Gaia: 0bc74ce502672cf0265b24cf3a25d117c3de5e71
Gecko: e4cfacb76830
Gonk: 2c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: v184
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Comment 1

[Peter Bylenga [:PBylenga]]

QAWanted for branch checks.

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

Issue is NOT reproducible on Flame 2.0. Status bar is NOT visible when previewing picture that was taken from camera via passcode screen.

Device: Flame (shallow flash)
BuildID: 20141008192303
Gaia: c1f60895e5bcc6a951f3667c2a1e1bd39d393420
Gecko: 4540201b5da0
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 3

[Joshua Mitchell (Inactive)]

QAnalyst Triage - Based on the screenshot this just seems a slight overlap of status bar icons - worth fixing but not worth blocking on (not nomming)

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

The icons are overlapping and the "share" and the "..." buttons are non functional so nominating this 2.1?

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is a regression in the fact that the share and settings buttons are there at all.  In older builds those buttons are not there (they are presumably unresponsive because of the passcode lock).  Per conversation with Ktucker offline I am finding the window for when the buttons were added to this screen.

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1008187 seems to be the cause of this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.1
BuildID: 20140713220712
Gaia: 0e6b5fec5eb508c5a94115555906261f8d809825
Gecko: 8112c0230130
Version: 33.0a1 (2.1) 
Firmware Version: L1TC00011230
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken 
EnvironDevice: Flame 2.1
BuildID: 20140713224813
Gaia: 9d822c4666c507da8ffe9967df530aa6980acbf8
Gecko: 0bbba283216e
Version: 33.0a1 (2.1) 
Firmware Version: L1TC00011230
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: 0e6b5fec5eb508c5a94115555906261f8d809825
Gecko: 0bbba283216e

First Broken gaia / Last Working gekko - Issue DOES occur
Gaia: 9d822c4666c507da8ffe9967df530aa6980acbf8
Gecko: 8112c0230130

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/0e6b5fec5eb508c5a94115555906261f8d809825...9d822c4666c507da8ffe9967df530aa6980acbf8

Comment 7

[Wilson Page [:wilsonpage]]

NI mhenretty to see if has any ideas.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Sounds like there are two issues here. First, the statusbar icons show up in the camera app which is fullscreen. Second, the `settings` and `share` buttons show up in the camera preview page when going from lockscreen with a passcode. To me these are both 2.1 blocking issues. Can we file a separate bug for the statusbar icons please, and I will have a look. The regression window above only seems to apply to the share and settings buttons.

Comment 9

[Joshua Mitchell (Inactive)]

See also bug from prior comment is the new bug for the other issue

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Updating the title of this bug to refer to the share and settings buttons.

Comment 11

[howie [:howie]]

moving component to camera since caused by bug 1008187

Comment 12

[Hema Koka [:hema]]

Blocking Reason: Status Bar icon overlaps leading to non-functional UI. In the lockscreen case share and settings shouldn't be showing up. 

Justin to investigate. Punam please provide your input since you fixed similar issues.

Comment 13

[Punam Dahiya [:pdahiya]]

(In reply to Hema Koka [:hema] from comment #12)
> Blocking Reason: Status Bar icon overlaps leading to non-functional UI. In
> the lockscreen case share and settings shouldn't be showing up. 
> 
> Justin to investigate. Punam please provide your input since you fixed
> similar issues.

Hi Hema
At first from screen shot attached it looks like bug 1079953 and bug 1081819 are same, after going through this thread I realized this particular bug is specific to share and settings/options button show up in preview mode when user 
1. open camera app from passcode lockscreen.
2. clicks picture
3. Go to preview.
As per #comment 5 these buttons should not be there in this flow and appears to be regression of bug 1008187 #comment 6.

Bug 1081819 that's specific to status bar icons showing up (in camera app when opened from passcode lockscreen) and making that area unresponsive in full screen apps (camera, video) bug 1081562 is what I looked into. 1081819 and 1081562 are due to regression from bug 1045017 and does not look related to this bug. Thanks

Comment 14

[Punam Dahiya [:pdahiya]]

Sorry typo in previous comment bug 1081819 ~ bug 1081319

Comment 15

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

This is a <gaia-header> style specificity issue.

Comment 16

[Wilson Page [:wilsonpage]]

Comment on attachment 8505431 [details] [review]
pull-request (master)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: User will see share/more buttons in camera preview when in secure mode.
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): Minimal. Just CSS.
[String changes made]: None

Comment 17

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8505431 [details] [review]
pull-request (master)

LGTM! There is still a Lockscreen bug here that I will file a follow-up for. Since Camera is a full-screen app, the status bar should not be showing at the top.

Comment 18

[Justin D'Arcangelo [:justindarc]]

(In reply to Justin D'Arcangelo [:justindarc] from comment #17)
> Comment on attachment 8505431 [details] [review]
> pull-request (master)
> 
> LGTM! There is still a Lockscreen bug here that I will file a follow-up for.
> Since Camera is a full-screen app, the status bar should not be showing at
> the top.

My bad. As Punam already mentioned in Comment 14, there already is a bug filed for the lockscreen regression (Bug 1081319).

Comment 19

[bhavana bajaj [:bajaj]]

waiting for master landing before consider approval for uplift.

Comment 20

[Wilson Page [:wilsonpage]]

Comment on attachment 8505431 [details] [review]
pull-request (master)

LANDED https://github.com/mozilla-b2g/gaia/commit/3d9e6dd83a0394c12f948c43250aa5874892c1d4

Comment 21

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.2

Actual Results: Share and settings buttons do not appear on lockscreen camera image preview

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022040201
Gaia: 4d7f051cede6544f4c83580253c743c22b0cb279
Gecko: ae4d9b4ff2ee
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0


Leaving verifyme keyword awaiting 2.1 uplift

Comment 22

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/fd859ec69b2709dbc99da7a25a862c0824281a59

Comment 23

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: Status bar, share button, and settings button are not displayed on lockscreen camera preview screen.

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141023001201
Gaia: 1e48e3e40e0780c0cd07a3457e5fe2efeeb542d1
Gecko: 09fb60a37850
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0