1080051 - [FTE] Tapping on the SIM 1 PIN text box does not invoke the keyboard

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Description:
If the user locks their device while on the FTE "Enter PIN code" screen, the keyboard will not be invoked no matter how many times the user taps on the "SIM 1 PIN" text box. 

Repro Steps:
1)  Updated Flame to Build ID: 20141008000201
2)  Set a PIN for SIM 1 and then factory reset the phone.
3)  Tap next on the language screen.
4)  When prompted to enter in the PIN for SIM 1, lock the device.
5)  Wake up the device and notice the cursor is blinking in the SIM 1 PIN box but no keyboard is present. Keep tapping on the "SIM 1 PIN" text box.

Actual:
The keyboard is not invoked.

Expected:
The keyboard should either pop up automatically after waking up the device or should be invoked after the user taps on the "SIM 1 PIN" text box.

Environmental Variables:
Device: Flame 2.1(KK)(319mb)(Full Flash)
Build ID: 20141008000201
Gaia: d71f8804d7229f4b354259d5d8543c25b4796064
Gecko: 7fa82c9acdf2
Version: 34.0a2 Flame 2.1 KK (319mb)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Notes:
Repro frequency: 100%
Link to failed test case: Found while exploratory testing.
See attached: Video, http://youtu.be/J6eswK357lI

Please note that i could not get a logcat for this issue because it only happens during the FTE after a flash or factory reset. The developer menu FTE did not reproduce this issue.

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue also occurs on the Flame 2.2(319mb)(KK)(Full Flash)

The keyboard does not invoke when tapping on the SIM PIN 1 text box after waking up the phone.

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141008040203
Gaia: 0bc74ce502672cf0265b24cf3a25d117c3de5e71
Gecko: e4cfacb76830
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: v180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

--------------------------------------------------------------------

The issue does not occur on the Flame 2.0(KK)(319mb)(Full Flash).

The keyboard automatically pops up after waking up the phone on the "Enter SIM PIN" screen. 

Device: Flame 2.0 (KK)(319mb)(Full Flash)
BuildID: 20141008000202
Gaia: 31a49c7932c7085961760a6bef9ed381ea38d7e3
Gecko: a2d707e79061
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

If the user has a SIM pin on their SIM card, they should always be able to unlock it during the FTE. Poor UX and a regression

Comment 3

[Seth Miko [:SMiko]]

This issue is possibly caused by bug 1064648
https://github.com/mozilla-b2g/gaia/commit/e1c58ceb17529aef027da0cac240b5f38b87f1c0

Aurora Regression Window: 

Last working:
Device: Flame 2.1 (319mb)
BuildID: 20140922123823
Gaia: 2c5f245929d40ee7b0227ef39e47a0220171d17b
Gecko: f22aa9158262
Version: 34.0a2  
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First broken
Environmental Variables:
Device: Flame 2.1 (319mb)
BuildID: 20140922142823
Gaia: 350704775d13bd374540d8cdb4619349433202c0
Gecko: 5d36d6e3f576
Version: 34.0a2  
Firmware Version: L1TC10011800
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia First Broken Gecko - Issue does NOT repro
Gaia: 2c5f245929d40ee7b0227ef39e47a0220171d17b
Gecko: 5d36d6e3f576

First Broken Gaia Last Working Gecko - Issue DOES repro
Gaia: 350704775d13bd374540d8cdb4619349433202c0
Gecko: f22aa9158262

https://github.com/mozilla-b2g/gaia/compare/2c5f245929d40ee7b0227ef39e47a0220171d17b...350704775d13bd374540d8cdb4619349433202c0

Comment 4

[Joshua Mitchell (Inactive)]

regression likely caused by bug 1064648 - can you take a look George?

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

In the past, we keep the keyboard status, if it's opened and then turn the screen off, we would do nothing, so the keyboard is still there. Bug 1064648 has changed the behavior, we hide the keyboard if the screen is off, unless we try to focus on any input field again. However, it seems that keyboard cannot get input-focused event again if the cursor has already existed on it.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

I would suggest to blur the focused item while calling hideKeyboardImmediately.

Comment 7

[Gregor Wagner [:gwagner]]

Moving to system-platform since it's a regression from bug 1064648

Comment 8

[Andrew Overholt [:overholt]]

Regression + bad user experience = 2.1+.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

I think bug 1081860 also fix this issue on latest master(gaia). could you help to verify ? Thanks.

Comment 10

[Seth Miko [:SMiko]]

Issue still occurs on Flame 2.2 (319mb/full flash)

Actual result: The keyboard is not present when powering off/on in FTU

Device: Flame 2.2
BuildID: 20141016040204
Gaia: 841d0d7d1b879f0ff4b5a8727f5dd23c7b0000a9
Gecko: a280a03c9f3c
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 36.0a1 (2.2)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Repro rate 2/2

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

This gaia version doesn't have my fix from bug 1081860. Please use latest master to test again.

(In reply to Seth Miko [:SethM] from comment #10)
> Issue still occurs on Flame 2.2 (319mb/full flash)
> 
> Actual result: The keyboard is not present when powering off/on in FTU
> 
> Device: Flame 2.2
> BuildID: 20141016040204
> Gaia: 841d0d7d1b879f0ff4b5a8727f5dd23c7b0000a9
> Gecko: a280a03c9f3c
> Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
> Version: 36.0a1 (2.2)
> Firmware: V180
> User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
> 
> Repro rate 2/2

Comment 12

[Joshua Mitchell (Inactive)]

QA-Wanted to recheck in the latest Master

Comment 13

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue no longer occurs on the latest 2.2 build.

Environmental Variables:
Device: Flame 2.2
BuildID: 20141020055012
Gaia: dc496d04907dd314f9736ff78bab3bd27156f79a
Gecko: f2d7d694aae5
Version: 36.0a1 (2.2) 
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 14

[Joshua Mitchell (Inactive)]

Marking this as fixed by patch from bug 1081860

Comment 15

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue is still occurring on the latest Flame 2.1(319mb)(KK)(Full Flash)

The keyboard is not invoked after locking/unlocking the device on the SIM PIN screen. Tapping on the SIM PIN text box does not bring up the keyboard. 

Environmental Variables
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141021001201
Gecko: https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ee86921a986f
Gaia: e458f5804c0851eb4e93c9eb143fe044988cecda
Platform Version: 34.0
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 16

[sarsenyev]

Verified, as per comment 14, the bug is fixed on Master build Flame 2.2, but still occurs on Flame 2.1

Flame 2.2 KK (319mb Full Flash)
Device: Flame 2.2 Master
BuildID: 20141022040201
Gaia: 27a1d1baaa8e375b70e043efee67d5f2206c330b
Gecko: ae4d9b4ff2ee
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

The issue still occurs on 2.1
Device: Flame 2.1 KK (319mb Full Flash)
BuildID: 20141022001201
Gaia: 3d9cc667f4e929861a9a77c41096bbf5a9c1bde0
Gecko: 928b18f7d8ff
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Adding verifyme for 2.1 verification once the patch has been uplifted.

Comment 17

[Sam Foster [:sfoster] (he/him)]

George, Comment 15 says this is still reproducing on v2.1, even though the fix in bug 1081860 has been uplifted and verified. Do we need further 2.1-specific work to get this blocker fixed?

Comment 18

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Needs v2.1 approval still :)

Comment 20

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8510254 [details] [review]
PR to 2.1

Hi Alive,
could you help to review this patch for 2.1 only?

Thanks.

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8510254 [details] [review]
PR to 2.1

I will let Tim judge if this is a valid fix.

Comment 22

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8510254 [details] [review]
PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): None
[User impact] if declined: Keyboard cannot be launched if we has launched keyboard  and turn screen off/on. see comment 0.
[Testing completed]: test has completed. And I also check the behavior
1. Boot up device and check sim dialog of FTU, keyboard is launched correctly
2. bug 1064648
3. (disable lockscreen) Focus on input field and screen off/on, the keyboard is still there.
[Risk to taking this patch] (and alternatives if risky): No.
[String changes made]:

Comment 24

[(Inactive after June) George Duan [:gduan] [:喬智]]

2.1: https://github.com/mozilla-b2g/gaia/commit/027a7de0c95320cea0579bfd1a4ceef3e9038f34

Comment 25

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: Keyboard appears properly after locking and unlocking the device and tapping the field.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141106001204
Gaia: 9658b93b412bdcc0f953d668e8c8e68318c99fb8
Gecko: 76880403db44
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0