1080544 - Remove some dead code from the product details

Status: RESOLVED WONTFIX

(www.mozilla.org :: Product Details, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: remove-dead-code.diff

Product detail used to be included in the website, most of the code is now useless.

I haven't touched the thunderbird code and the json is not touched.

Sorry for the mass review, I just want to make sure I won't break too many things.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 8502476 [details] [diff] [review]
remove-dead-code.diff

Review of attachment 8502476 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I can tell, this doesn't affect Thunderbird. I've not looked at the rest of it in detail though, so just f+ from me.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug_1080544.diff

Delete a bunch of dead code.

Comment 3

[Paul [:pmac] McLanahan]

Comment on attachment 8507767 [details] [diff] [review]
bug_1080544.diff

Review of attachment 8507767 [details] [diff] [review]:
-----------------------------------------------------------------

I'm pretty sure that we no longer use the html generation bits of this on mozilla.org, but I'd like to ask others first.

::: firefoxDetails.class.php
@@ -35,5 @@
> - *
> - * @author Wil Clouser <[e-mail]>
> - *
> - */
> -class firefoxDetails extends productDetails {

Looks like deleting this and not having the new one inherit from productDetails would possibly break export_json.php. Have you tested that? I've not run it myself, but that file does seem to get builds from this class, though could probably fall back to directly using productDetails.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

(In reply to Paul McLanahan [:pmac] from comment #3)

> Looks like deleting this and not having the new one inherit from
> productDetails would possibly break export_json.php. Have you tested that?
Of course :)
It does not introduced a single change in json.

Comment 5

[Steven Garrity [:sgarrity]]

Isn't this going to break the download button on the 404 page?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

AFAIK, this code is no longer used. It is still the case, I would be interested to see the code.

Comment 7

[Steven Garrity [:sgarrity]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> AFAIK, this code is no longer used. It is still the case, I would be
> interested to see the code.

getNoScriptBlockForLocale and getDownloadBlockForLocale are used in en-US/404.html

http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/404.html?view=markup#l16

Comment 8

[Pascal Chevrel:pascalc]

(In reply to Steven Garrity [:sgarrity] from comment #7)
> (In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> > AFAIK, this code is no longer used. It is still the case, I would be
> > interested to see the code.
> 
> getNoScriptBlockForLocale and getDownloadBlockForLocale are used in
> en-US/404.html
> 
> http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/en-US/404.
> html?view=markup#l16


https://bugzilla.mozilla.org/show_bug.cgi?id=1008100

fixing this bug would ease p-d migration and would make l10n life better too.

Comment 9

[Steven Garrity [:sgarrity]]

Agreed. If we can't get the 404 page migrated, we could replace the download button on the 404 page with a simple (dumb) "Get Firefox" button that links to the 2nd-stage of /firefox/new/ (or just to /firefox/new/).

Comment 10

[Paul [:pmac] McLanahan]

Fastest fix is what :sgarrity said about the dumb button. Getting the 404 to be fully bedrock is what we want to do for sure, but requires a lot more technical work since it involves flipping our current architecture (from php -> python, to python -> php).

Comment 11

[Steven Garrity [:sgarrity]]

(In reply to Paul McLanahan [:pmac] from comment #10)
> Fastest fix is what :sgarrity said about the dumb button. Getting the 404 to
> be fully bedrock is what we want to do for sure, but requires a lot more
> technical work since it involves flipping our current architecture (from php
> -> python, to python -> php).

I've filed Bug 1085573 to do this.

Comment 12

[Steven Garrity [:sgarrity]]

Comment on attachment 8507767 [details] [diff] [review]
bug_1080544.diff

Review of attachment 8507767 [details] [diff] [review]:
-----------------------------------------------------------------

As is, this would break the download button on the PHP 404 page. Until I've got something for that in Bug 1085573, this will have to wait.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Touching product details is too risky. We will work on bug 1083718 instead.

Comment 14

[Paul [:pmac] McLanahan]

(In reply to Sylvestre Ledru [:sylvestre] from comment #13)
> Touching product details is too risky. We will work on bug 1083718 instead.

WOO! Let me know how I can help!