1082516 - [Flatfish][Gallery]&[Video] There are no title bars at Gallery and Video apps.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[eva.chen.fx]

Attachment: issue_Gallery_title bar.png

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/37.0.2062.124 Safari/537.36

Steps to reproduce:

1. Open the Gallery app or Video app.
2. <ISSUE> There are no title bars at Gallery and Video apps.
See attached: 1) issue_Gallery_title bar.png
              2) issue_Video_title bar.png
------------------------------------------------------
* "Broken" Env. Info:
  Device  : Flatfish 2.2 Master
  B2G     : 2.2.0.0-prerelease
  Gaia    : ba6667c83c5d0fb1e333349dfeaf5f6ca8043e63
  Gecko   : f35a18db764219dce00bd8bffdb93d320dfbf9d7
  BuildID : 20141014014140
  Version : 35.0a1
  Repro frequency: 100%
  
* "Working" Env. Info:
  Device  : Flatfish 2.2 Master
  B2G     : 2.2.0.0-prerelease
  Gaia    : 77ef35f5429bc3dfe9ca192b9aacc3c0bf8857de
  Gecko   : 85d6d4633af6d71c417a1980c6b2853f2f79f752
  BuildID : 20140930013737
  Version : 35.0a1
  Repro frequency: 100%

Comment 1

[eva.chen.fx]

Attachment: issue_Video_title bar.png

Comment 3

[YF (Yang)]

Attachment: add default_theme to Flatfish tablet

Please test this patch (I don't have a build environment).
I think it may solve this problem by repairing the theme could not be loaded error (introduced by bug 1069840).

Comment 4

[Sherman Chen [:chens] (inactive)]

I think this patch can fix the issue, but I would suggest 'apps-engineering.list' should be updated also. And you may ask :rickychien for review, thanks!

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8523579 [details] [review]
add default_theme to Flatfish tablet

LGTM. Thanks

Comment 6

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/983ef67d9a7a96f26f86c46063bba42ce8bab57c

Comment 7

[eva.chen.fx]

Tested on TCP 20141121 build, it works well.
Environmental Variables:
Flatfish 2.2
BuildID: 20141121014025
Gaia   : c18773452502102ae59076710ca51f841832c677
Gecko  : 2a90415e24d555dc1ed7a6423d54707a313cb332
Version: 36.0a1