1069840 - Update apps links to fetch shared style from default theme

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Olle Klang]

Themeable apps css styles from ”shared/style” should be loaded from the current theme (app://theme.gaiamobile.org/shared/style).

Comment 1

[Olle Klang]

Attachment: GitHub pull-request

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8492079 [details] [review]
GitHub pull-request

r+.

Comment 3

[Olle Klang]

Attachment: GitHub pull-request

Updated PR to reflect changes in Bug 1069791.

Comment 4

[Olle Klang]

Attachment: GitHub pull-request

After conversation with Wilson Page about what's coming in 2.2 I've decided to only change the links concerning the gaia-theme/style.css.

Please review.

Comment 5

[Olle Klang]

Attachment: GitHub pull-request

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Hi Olle!

Is this bug still in place, if so, I think we need to rebase it.

Thanks!

Comment 7

[Olle Klang]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #6)
> Hi Olle!
> 
> Is this bug still in place, if so, I think we need to rebase it.
> 
> Thanks!

PR rebased.

Comment 8

[[:fabrice] Fabrice Desré]

Olle, you need to rebase again, and set the commit message to "Bug 1069840 - Update apps links to fetch shared style from default theme r=vingtetun"

Comment 9

[Olle Klang]

(In reply to Fabrice Desré [:fabrice] from comment #8)
> Olle, you need to rebase again, and set the commit message to "Bug 1069840 -
> Update apps links to fetch shared style from default theme r=vingtetun"

Rebased.

Comment 10

[[:fabrice] Fabrice Desré]

(In reply to Olle Klang from comment #9)
> (In reply to Fabrice Desré [:fabrice] from comment #8)
> > Olle, you need to rebase again, and set the commit message to "Bug 1069840 -
> > Update apps links to fetch shared style from default theme r=vingtetun"
> 
> Rebased.

You forgot the r=vingtetun ...

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/a8e94695b841e3be4d5b80a757c716b7de397ae4

Please request Gaia v2.1 approval on this when you get a chance :)

Comment 12

[Kevin Grandon :kgrandon]

This commit message landed totally wrong. It should've been fixed as pointed out in comment 8, not sure why the rebase didn't work here. I've backed it out and re-landed with the appropriate commit message.

Backout: https://github.com/mozilla-b2g/gaia/commit/8507ce6eec44ea245c330d20bf298adffcca4ef1
Re-landing /w proper commit message: https://github.com/mozilla-b2g/gaia/commit/a309125bbb8835461c8fb4b425c4723180f069cc

Comment 13

[Kevin Grandon :kgrandon]

Attachment: Github commit to master

Updating the attachment as the commit that actually landed in master to make uplifting clear if needed.

Comment 14

[Olle Klang]

Attachment: GitHub pull-request (v2.1)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1002469
[User impact] if declined: Theme apps will not be able to impact the UI.
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): Minimal
[String changes made]:

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/165ff9093f49993e2b17a43f4c16b9bed5bfc7c2