Closed
Bug 1082554
Opened 10 years ago
Closed 10 years ago
remove tools/performance/pageload + startup
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: jmaher, Assigned: n.nethercote)
References
Details
Attachments
(3 files)
179.99 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
9.35 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
481 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
These two directories seem ancient and are not used in Talos. Talos code lives here: http://hg.mozilla.org/build/talos
Assignee | ||
Comment 1•10 years ago
|
||
Thanks, jmaher. I can take this.
Assignee: nobody → n.nethercote
Blocks: 1080290
Assignee | ||
Comment 2•10 years ago
|
||
This was added in bug 342089, back in mid-2006. 7 files changed, 1917 deletions(-)
Attachment #8505054 -
Flags: review?(jmaher)
Assignee | ||
Comment 3•10 years ago
|
||
Finishing what bug 591717 and bug 579571 started. 6 files changed, 293 deletions(-)
Attachment #8505066 -
Flags: review?(jmaher)
Assignee | ||
Comment 4•10 years ago
|
||
jmaher, with those two patches done, the only thing left in tools/performance/ is diff-talos.py. Is that still needed? If so, we should rename the directory as tools/diff-talos/, or maybe even move the script into the talos repo?
Flags: needinfo?(jmaher)
Reporter | ||
Updated•10 years ago
|
Attachment #8505054 -
Flags: review?(jmaher) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8505066 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 5•10 years ago
|
||
as for diff-talos.py, it looks useful, we have plenty of tools like this and I use one inside the talos repository: http://hg.mozilla.org/build/talos/file/f18462778f49/talos/compare.py While they do similar things, it is nice to have something in m-c. Unfortunately diff-talos.py is outdated such that it is missing half the tests and has a lot of older tests in it. We can either: 1) delete it as it is obviously crufty 2) move it to /testing/talos/
Flags: needinfo?(jmaher)
Assignee | ||
Comment 6•10 years ago
|
||
I strongly considered deleting it, but instead moved it because (a) it's Python rather than Perl, and (b) it has a nice high-level comment at the top of the script explaining what it's doing :)
Attachment #8505811 -
Flags: review?(jmaher)
Reporter | ||
Comment 7•10 years ago
|
||
Comment on attachment 8505811 [details] [diff] [review] (part 3) - Move diff-talos.py from tools/performance/ to testing/talos/ looks good.
Attachment #8505811 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/830500259c5a https://hg.mozilla.org/integration/mozilla-inbound/rev/ee285282cc5e https://hg.mozilla.org/integration/mozilla-inbound/rev/39c4ff676526
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/830500259c5a https://hg.mozilla.org/mozilla-central/rev/ee285282cc5e https://hg.mozilla.org/mozilla-central/rev/39c4ff676526
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•