Closed Bug 1082554 Opened 8 years ago Closed 8 years ago

remove tools/performance/pageload + startup

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: jmaher, Assigned: n.nethercote)

References

Details

Attachments

(3 files)

These two directories seem ancient and are not used in Talos.

Talos code lives here: http://hg.mozilla.org/build/talos
Thanks, jmaher. I can take this.
Assignee: nobody → n.nethercote
Blocks: 1080290
This was added in bug 342089, back in mid-2006.

 7 files changed, 1917 deletions(-)
Attachment #8505054 - Flags: review?(jmaher)
Finishing what bug 591717 and bug 579571 started.

 6 files changed, 293 deletions(-)
Attachment #8505066 - Flags: review?(jmaher)
jmaher, with those two patches done, the only thing left in tools/performance/ is diff-talos.py. Is that still needed? If so, we should rename the directory as tools/diff-talos/, or maybe even move the script into the talos repo?
Flags: needinfo?(jmaher)
Attachment #8505054 - Flags: review?(jmaher) → review+
Attachment #8505066 - Flags: review?(jmaher) → review+
as for diff-talos.py, it looks useful, we have plenty of tools like this and I use one inside the talos repository:
http://hg.mozilla.org/build/talos/file/f18462778f49/talos/compare.py

While they do similar things, it is nice to have something in m-c.  Unfortunately diff-talos.py is outdated such that it is missing half the tests and has a lot of older tests in it.

We can either:
1) delete it as it is obviously crufty
2) move it to /testing/talos/
Flags: needinfo?(jmaher)
I strongly considered deleting it, but instead moved it because (a) it's
Python rather than Perl, and (b) it has a nice high-level comment at the top of
the script explaining what it's doing :)
Attachment #8505811 - Flags: review?(jmaher)
Comment on attachment 8505811 [details] [diff] [review]
(part 3) - Move diff-talos.py from tools/performance/ to testing/talos/

looks good.
Attachment #8505811 - Flags: review?(jmaher) → review+
You need to log in before you can comment on or make changes to this bug.