1082554 - remove tools/performance/pageload + startup

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

These two directories seem ancient and are not used in Talos.

Talos code lives here: http://hg.mozilla.org/build/talos

Comment 1

[Nicholas Nethercote [inactive]]

Thanks, jmaher. I can take this.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove tools/performance/pageload/, which is ancient and unused

This was added in bug 342089, back in mid-2006.

 7 files changed, 1917 deletions(-)

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove tools/performance/startup/, which is ancient and unused

Finishing what bug 591717 and bug 579571 started.

 6 files changed, 293 deletions(-)

Comment 4

[Nicholas Nethercote [inactive]]

jmaher, with those two patches done, the only thing left in tools/performance/ is diff-talos.py. Is that still needed? If so, we should rename the directory as tools/diff-talos/, or maybe even move the script into the talos repo?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

as for diff-talos.py, it looks useful, we have plenty of tools like this and I use one inside the talos repository:
http://hg.mozilla.org/build/talos/file/f18462778f49/talos/compare.py

While they do similar things, it is nice to have something in m-c.  Unfortunately diff-talos.py is outdated such that it is missing half the tests and has a lot of older tests in it.

We can either:
1) delete it as it is obviously crufty
2) move it to /testing/talos/

Comment 6

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Move diff-talos.py from tools/performance/ to testing/talos/

I strongly considered deleting it, but instead moved it because (a) it's
Python rather than Perl, and (b) it has a nice high-level comment at the top of
the script explaining what it's doing :)

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8505811 [details] [diff] [review]
(part 3) - Move diff-talos.py from tools/performance/ to testing/talos/

looks good.

Comment 8

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/830500259c5a
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee285282cc5e
https://hg.mozilla.org/integration/mozilla-inbound/rev/39c4ff676526

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/830500259c5a
https://hg.mozilla.org/mozilla-central/rev/ee285282cc5e
https://hg.mozilla.org/mozilla-central/rev/39c4ff676526