Update test_sms_with_attachments.py to match the manual smoketest

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: viorela, Assigned: RobertC)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

5 years ago
In test_sms_with_attachments.py, we are currently checking that the message received has attachment. 
We need to update it by tapping on the attachment, then assert that the user is prompted with a message asking if they would like to download attachments, as per https://moztrap.mozilla.org/manage/case/10743/ , step 4.
Link to the automated test: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_with_attachments.py
Assignee

Updated

5 years ago
Assignee: nobody → robert.chira
Assignee

Comment 1

5 years ago
The last step from the moztrap test case cannot be reproduced manually. The user is no prompted with a download option, instead the image is displayed in the gallery app and a save button is available at the top.

Peter, is the test case out of date or could this be a bug?
Flags: needinfo?(pbylenga)
Ah, that's the behavior if you turn off automatic downloads in message settings which is on now by default.  I think the test case is simply out of date.  I'll update the case.
Flags: needinfo?(pbylenga)
Assignee

Updated

5 years ago
Depends on: 1084377
Assignee

Comment 3

5 years ago
Attachment #8512478 - Flags: review?(viorela.ioia)
Attachment #8512478 - Flags: review?(florin.strugariu)
Attachment #8512478 - Flags: review?(florin.strugariu) → review+
Reporter

Comment 4

5 years ago
Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Let's wait for Bug 1080169 to be fixed, as there are some methods added in that PR that you can use here. 
I will r? again afterwards. Thanks!
Attachment #8512478 - Flags: review?(viorela.ioia) → review-
Assignee

Comment 5

5 years ago
Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

I updated the PR to use other page object. Please review this again.
Attachment #8512478 - Flags: review?(viorela.ioia)
Attachment #8512478 - Flags: review?(florin.strugariu)
Attachment #8512478 - Flags: review-
Attachment #8512478 - Flags: review+
Assignee

Updated

5 years ago
QA Whiteboard: fxosqa-auto-from-s2
Assignee

Updated

5 years ago
QA Whiteboard: fxosqa-auto-from-s2 → fxosqa-auto-from-s2, fxosqa-auto-s3
Assignee

Updated

5 years ago
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]
Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Let's update this pull with the new wait_for
Attachment #8512478 - Flags: review?(florin.strugariu) → review-
Assignee

Comment 7

5 years ago
Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

I updated the wait.
Attachment #8512478 - Flags: review?(viorela.ioia)
Attachment #8512478 - Flags: review?(jlorenzo)
Attachment #8512478 - Flags: review?(florin.strugariu)
Attachment #8512478 - Flags: review-
Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Okay for the new wait. I tested to use the ID to tap the save button, it was working on my side. I think we should use it before merging.
Attachment #8512478 - Flags: review?(jlorenzo) → review-
Assignee

Comment 9

5 years ago
Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Updated the PR
Attachment #8512478 - Flags: review- → review?(jlorenzo)
Attachment #8512478 - Flags: review?(florin.strugariu) → review+
Attachment #8512478 - Flags: review?(jlorenzo) → review+
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-from-s2] [fxosqa-auto-s3] → [fxosqa-auto-from-s1] [fxosqa-auto-from-s2] [fxosqa-auto-s3]
You need to log in before you can comment on or make changes to this bug.