1083126 - Update test_sms_with_attachments.py to match the manual smoketest

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Viorela Ioia [:viorela]]

In test_sms_with_attachments.py, we are currently checking that the message received has attachment. 
We need to update it by tapping on the attachment, then assert that the user is prompted with a message asking if they would like to download attachments, as per https://moztrap.mozilla.org/manage/case/10743/ , step 4.
Link to the automated test: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_with_attachments.py

Comment 1

[Robert Chira [:RobertC]]

The last step from the moztrap test case cannot be reproduced manually. The user is no prompted with a download option, instead the image is displayed in the gallery app and a save button is available at the top.

Peter, is the test case out of date or could this be a bug?

Comment 2

[Peter Bylenga [:PBylenga]]

Ah, that's the behavior if you turn off automatic downloads in message settings which is on now by default.  I think the test case is simply out of date.  I'll update the case.

Comment 3

[Robert Chira [:RobertC]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Comment 4

[Viorela Ioia [:viorela]]

Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Let's wait for Bug 1080169 to be fixed, as there are some methods added in that PR that you can use here. 
I will r? again afterwards. Thanks!

Comment 5

[Robert Chira [:RobertC]]

Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

I updated the PR to use other page object. Please review this again.

Comment 6

[Florin Strugariu [:Bebe]]

Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Let's update this pull with the new wait_for

Comment 7

[Robert Chira [:RobertC]]

Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

I updated the wait.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Okay for the new wait. I tested to use the ID to tap the save button, it was working on my side. I think we should use it before merging.

Comment 9

[Robert Chira [:RobertC]]

Comment on attachment 8512478 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25564

Updated the PR

Comment 10

[Johan Lorenzo [:jlorenzo]]

Merged in master: https://github.com/mozilla-b2g/gaia/commit/d8c16a79ead4d0249f6f8f2a3d34659d0ae57275