Closed
Bug 1080169
Opened 10 years ago
Closed 10 years ago
Add a test that sends an sms with picture from Gallery attached
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pbylenga, Assigned: Bebe)
References
Details
Attachments
(1 file, 2 obsolete files)
Currently the test does not test cropping images during the attachment process like Manual does. Currently Automation is not encountering https://bugzilla.mozilla.org/show_bug.cgi?id=1063658 or https://bugzilla.mozilla.org/show_bug.cgi?id=1077106. https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-id=10742 Manual STRs: Open Message app Message app opens and displays correctly, all previous threads will be display if they have not been removed. Tap on the Compose icon New Message screen will appear and display correctly. Enter a recipient in the "To:" text field Recipient will be added to the text box. Tap on Paper Clip icon Context menu will display with options: - Video - Music - Gallery - Camera Select Gallery Pictures will be populated from the phone. Select a picture Crop screen will display the photo selected and the user will be able to adjust the photo. Save the cropped image by tapping on the icon in the top right A preview of the picture selected will be displayed in the text field on the bottom. MMS text will display above the "Send" button. Tap on the image, and select 'View' Image shown. Tap on Send. MMS will be sent to recipient. Tap on the image just sent. Image shown.
Assignee | ||
Comment 1•10 years ago
|
||
@Peater @zac I don't think we can actually move the crop area with marionette At the moment we just tap done in the crop view. Zac do you have any suggestion on how to interact with the crop view?
Attachment #8504071 -
Flags: review?(viorela.ioia)
Attachment #8504071 -
Flags: review?(robert.chira)
Attachment #8504071 -
Flags: review?(gmealer)
Attachment #8504071 -
Flags: feedback?(zcampbell)
Attachment #8504071 -
Flags: feedback?(pbylenga)
Comment 2•10 years ago
|
||
Bebe, it's a canvas element and we can't currently interact with those very reliably. I'd say we have to skpi that step.
Comment 3•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 f? as per comment #2
Attachment #8504071 -
Flags: feedback?(zcampbell)
Comment 4•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 There are 2 steps from https://moztrap.mozilla.org/manage/case/10742/ that are not added in this PR. That would be: - Step 8: Tap on the image, and select 'View' and - Step 10: Tap on the image just sent. As for step 8, we are currently blocked by Bug 1080020. Please update your PR by adding these steps.
Attachment #8504071 -
Flags: review?(viorela.ioia) → review-
Updated•10 years ago
|
Summary: Update test_sms_with_attachments.py to correlate with the manual test → Add a test that sends an sms with picture from Gallery attached
Assignee | ||
Comment 5•10 years ago
|
||
Updated the pull with some of the steps. This still need some work as we are blocked by Bug 1080020
Depends on: 1080020
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 Viorela can you take a look over the changes
Attachment #8504071 -
Flags: review?(robert.chira)
Attachment #8504071 -
Flags: review?(gmealer)
Attachment #8504071 -
Flags: review-
Attachment #8504071 -
Flags: feedback?(viorela.ioia)
Comment 7•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 Bug 1080020 is fixed, can you update your PR and ask for review? Thanks!
Attachment #8504071 -
Flags: feedback?(viorela.ioia)
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 Updated with all the steps. Please review
Attachment #8504071 -
Flags: review?(viorela.ioia)
Attachment #8504071 -
Flags: review?(robert.chira)
Attachment #8504071 -
Flags: review?(gmealer)
Comment 9•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 comments in the PR
Attachment #8504071 -
Flags: review?(viorela.ioia) → review-
Updated•10 years ago
|
Attachment #8504071 -
Flags: review?(robert.chira) → review-
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 Looks like you already have two active reviewers. I'm removing myself as an r?, but I'm going to continue to eavesdrop for the learning.
Attachment #8504071 -
Flags: review?(gmealer)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → florin.strugariu
Assignee | ||
Updated•10 years ago
|
Attachment #8504071 -
Flags: review?(viorela.ioia)
Attachment #8504071 -
Flags: review?(robert.chira)
Attachment #8504071 -
Flags: review-
Comment 11•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 Looks good, but there are some comments that need to be addressed. Also, I started an adhoc run: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/256/console
Attachment #8504071 -
Flags: review?(viorela.ioia) → review-
Comment 12•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 r+
Updated•10 years ago
|
Attachment #8504071 -
Flags: review- → review+
Comment 13•10 years ago
|
||
Comment on attachment 8504071 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25092 Merged on master: https://github.com/mozilla-b2g/gaia/commit/6ef24c53f0f44a41749b3a8cd72e0fb239760a6a Can we uplift to v2.1?
Flags: needinfo?(florin.strugariu)
Attachment #8504071 -
Flags: review?(robert.chira) → review+
Assignee | ||
Comment 14•10 years ago
|
||
Flags: needinfo?(florin.strugariu)
Attachment #8515023 -
Flags: review?(viorela.ioia)
Comment 15•10 years ago
|
||
I have backed this out because it has been reviewed poorly: https://github.com/mozilla-b2g/gaia/commit/10c41953f753e2c39818080d7d9294aa1bf4fa29 Problems (also comments in git pull): 1. Explicit frame switching - wrong 2. Typo in `visible` 3. poorly coded header tap Please fix them and re-land it.
Assignee | ||
Comment 16•10 years ago
|
||
Updated the pull Zac can you review it pls
Attachment #8504071 -
Attachment is obsolete: true
Attachment #8515023 -
Attachment is obsolete: true
Attachment #8504071 -
Flags: feedback?(pbylenga)
Attachment #8515023 -
Flags: review?(viorela.ioia)
Attachment #8515910 -
Flags: review?(zcampbell)
Assignee | ||
Updated•10 years ago
|
QA Whiteboard: fxosqa-auto-from-s2
Assignee | ||
Updated•10 years ago
|
QA Whiteboard: fxosqa-auto-from-s2 → fxosqa-auto-from-s2, fxosqa-auto-s3
Assignee | ||
Updated•10 years ago
|
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]
Comment 17•10 years ago
|
||
Comment on attachment 8515910 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25764 r+
Attachment #8515910 -
Flags: review?(zcampbell) → review+
Assignee | ||
Comment 18•10 years ago
|
||
Merged in https://github.com/mozilla-b2g/gaia/commit/cd9ad5bbc2a26b77c94477639c8c2442701ae4cb It has been reviewed and R+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
QA Whiteboard: [fxosqa-auto-from-s2] [fxosqa-auto-s3] → [fxosqa-auto-from-s1] [fxosqa-auto-from-s2] [fxosqa-auto-s3]
You need to log in
before you can comment on or make changes to this bug.
Description
•