Closed
Bug 1083498
Opened 9 years ago
Closed 9 years ago
Remove SpiderMonkey support for destructuring for-in (JS1.7-only language extension)
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
(Keywords: addon-compat, dev-doc-complete, site-compat, Whiteboard: [DocArea=JS])
Attachments
(1 file)
10.68 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Updated•9 years ago
|
Keywords: dev-doc-needed
Whiteboard: [DocArea=JS]
Assignee | ||
Comment 1•9 years ago
|
||
- Remove SpiderMonkey's nonstandard behavior for destructuring for…in loops in JS1.7. - Stop collecting telemetry for destructuring for…in loops. - Change js1_7 tests to expect JS1.8's destructuring for…in behavior. - Also add two reportCompare() calls to js1_7/geniter/regress-345736.js that were presumably forgotten in https://hg.mozilla.org/mozilla-central/rev/b23162a81291.
Comment 2•9 years ago
|
||
Comment on attachment 8582211 [details] [diff] [review] remove-js17-destructuring-for-in.patch Review of attachment 8582211 [details] [diff] [review]: ----------------------------------------------------------------- Thank you! ::: js/src/tests/js1_7/geniter/regress-347593.js @@ +21,5 @@ > printStatus (summary); > + > + // Before JS1.7's destructuring for…in was fixed to match JS1.8, > + // the expected result was simply '23'. > + expect = 'TypeError: (intermediate value)[Symbol.iterator](...).next(...).value is undefined'; It's better not to check exact error messages here. Just checking ex.name is fine.
Attachment #8582211 -
Flags: review?(jorendorff) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks! https://hg.mozilla.org/integration/mozilla-inbound/rev/129deced715e
Updated•9 years ago
|
Keywords: site-compat
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/129deced715e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•9 years ago
|
Keywords: addon-compat
Comment 5•9 years ago
|
||
Updated following documents: https://developer.mozilla.org/en-US/Firefox/Releases/40 https://developer.mozilla.org/en-US/docs/Web/JavaScript/New_in_JavaScript/1.7
Comment 6•9 years ago
|
||
Also noted on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment#Firefox-specific_notes
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•