Closed Bug 1083729 Opened 10 years ago Closed 10 years ago

Workaround for the callscreen leaking

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.1 fixed, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S7 (24Oct)
Project Flags:
blocking-b2g 2.1+
Tracking Flags:
Tracking Status
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Keywords: regression, Whiteboard: [systemsfe])

Attachments

(2 files)

Gaia PR
46 bytes, text/x-github-pull-request
etienne
: review+
fabrice
: approval-gaia-v2.1+
Details | Review
Result of local run of test from bug 1083731
1.27 KB, text/plain
Details 
[Blocking Requested - why for this release]: Blocking 2.1 because of bug 1074379 and 1081714

In bug 1078448 we showed that there is a bfcache-related leaking of callscreen. This is the root cause of several callscreen-related bugs.
Attached file Gaia PR — 

        Attachment #8506068 -
        Flags: review?(etienne)
Summary: Avoid callscreen leaking → Workaround for the callscreen leaking

    
  
Depends on: 1083731

    
    

    
  
Comment on attachment 8506068 [details] [review]
Gaia PR

As we discussed the only way to meaningfully test this is with a gaia-ui-test which is in the works.
so r=me

        Attachment #8506068 -
        Flags: review?(etienne) → review+
blocking-b2g: 2.1? → 2.1+
Target Milestone: --- → 2.1 S7 (24Oct)

    
    

    
  
Gaia was closed, I retriggered Gijs test and I'll land once green.

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/43a9e1dd8f92572b3446741f3f936b3e86f37dee
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Please request Gaia v2.1 approval on this when you get a chance :)

          status-b2g-v2.1:
          --- → affected

          status-b2g-v2.2:
          --- → fixed
Flags: needinfo?(lissyx+mozillians)

    
    

    
  
Comment on attachment 8506068 [details] [review]
Gaia PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1078448
[User impact] if declined: user will have a broken callscreen after placing several calls
[Testing completed]: placing hundred of calls sequentially with test from bug 1083731, completed 200 successfully where it would fail at 25
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none
Flags: needinfo?(lissyx+mozillians)

        Attachment #8506068 -
        Flags: approval-gaia-v2.1?

        Attachment #8506068 -
        Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Whiteboard: [systemsfe]
See Also:  → 1078448
Blocks: 1082879

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: