1084035 - fennec tab casting is broken in beta

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Splitting out tab mirroring work from bug 1054959

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: mirror.patch

this works, needs clean up though. A UX design as well.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Darrin, this patch is currently adding a "Mirror tab" item to the tools menu. It then pops up a select box. I'd like to propose doing what we did in bug 1054959 and just list the available devices in a sub menu.

Comment 3

[Darrin Henein [:darrin]]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #2)
> It then pops up a select box. I'd like to propose doing what we did in
> bug 1054959 and just list the available devices in a sub menu.

This sounds like a reasonable interaction, and conforms to what we decided to do elsewhere. Sounds like the right decision to me :)

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: mirror.patch

https://www.dropbox.com/s/gc2h1m6fzydzc7i/Screenshot%202014-10-21%2015.39.01.png?dl=0

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: browser_source_type.patch

The browser constraint gets scrubbed out in GetUserMedia() if it isn't called from a privileged context. So, this will only add the browser video source if the browser type is specified in constraints and GuM is called from chrome code.

Comment 6

[Randall Barker [:rbarker]]

Comment on attachment 8509073 [details] [diff] [review]
browser_source_type.patch

This patch along with the patches for bug 1053426, bug 1080012, and bug 1080701
is required to fix tab mirror from fennec to chromecast. I have tested all four patches applied beta and verified that they fix the feature.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8509073 [details] [diff] [review]
browser_source_type.patch

Approval Request Comment
[Feature/regressing bug #]: no regression
[User impact if declined]: tab streaming to roku broken on beta for fennec
[Describe test coverage new/current, TBPL]: none
[Risks and why]: low risk
[String/UUID change made/needed]: none

Unrelated to this bug, the Fennec tab streaming feature works fine in aurora and nightly because mHasTabVideoSource is true due to Fennec having UI for selecting a tab to stream for content. That UI is restricted to Nightly and Aurora, so when that feature moved up to Beta it mysteriously didn't work. This will fix that.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Adding leave-open because I just pushed the platform patch to fx-team, but we still need the frontend patch as well.

Comment 9

[Axel Hecht [:Pike]]

Hrm, the fact that we're still not done with string changes is concerning.

The string surely can use a comment on what "Mirror" means. Like, it's not some RTL thing, for example.

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking while we wait to approve for l10n and m-c landing.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ca5008e2d97

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8509073 [details] [diff] [review]
browser_source_type.patch

Approving for Aurora while there's still time for l10n.  I was under the impression this feature is targeted at 35 so leaving the beta approval until there's confirmation of the intent here.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c7e986f4ec72

Comment 14

[:Gavin Sharp [email: [e-mail]]]

We're not planning to uplift the desktop front-end patch, as far as I know.

It's confusing that two separate patches were put in the same bug. The "browser_source_type" patch has no l10n impact and wants to be uplifted for Fennec, apparently.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 8509069 [details] [diff] [review]
mirror.patch

Can you just move this patch to another bug, actually, given this bug's tracking flags and such?

Comment 16

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8509073 [details] [diff] [review]
browser_source_type.patch

Beta+

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/47065beeef20