Closed Bug 1084362 Opened 5 years ago Closed 5 years ago

When a third-party enters a room, stop displaying the ToS and privacy links in the Loop panel

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [rooms])

Attachments

(1 file)

Coming from a discussion with RT over irc. When a third-party enters my room, the panel should stop displaying the ToS & privacy links in the Loop panel.

We already do something like this for incoming conversations - which we should maintain.

We basically need to set "has-seen-tos" to true.
To be clear, there are 3 components which are displayed on FTU:
* "Get started" button opening the tour in a new tab (bug 1083466)
    - This will disappear the next time the user opens the panel
* The links to ToS and privacy notice (bug 1084362)
    - This will disappear after the first time someone joins a room created by the user (this is because there are 2 links and given that the panel closes as you click a link, we need to give an opportunity to the user to open both links)
* The Telefonica logo (bug 1074720)
    - This will disappear the next time the user opens the panel
Whiteboard: [rooms]
backlog: --- → Fx35+
Priority: -- → P1
Assignee: nobody → standard8
Iteration: --- → 36.3
Points: --- → 1
NiKo, what do you think of this? This uses the new standaloneMozLoop so that we don't have to do weird detection, but doesn't save the new pref there as we don't need it for standalone (there's a similar pref currently, but that's going to get removed when we kill the call url code).
Attachment #8524065 - Flags: review?(nperriault)
Comment on attachment 8524065 [details] [diff] [review]
When a third-party enters a room, stop displaying the ToS and privacy links in the Loop panel.

Review of attachment 8524065 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the comment addressed.

::: browser/components/loop/content/js/roomViews.jsx
@@ +120,5 @@
>     * Desktop room conversation view.
>     */
>    var DesktopRoomConversationView = React.createClass({
> +    mixins: [ActiveRoomStoreMixin, loop.shared.mixins.DocumentTitleMixin,
> +      loop.shared.mixins.AudioMixin],

This is unrelated to this patch and must be removed.
Attachment #8524065 - Flags: review?(nperriault) → review+
https://hg.mozilla.org/integration/fx-team/rev/790c27c395af
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/790c27c395af
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Mark, I don't think this is high enough risk to warrant QE verification. Feel free to nominate this for uplift to Aurora since this is an Fx35 blocker.
Flags: qe-verify-
Flags: in-testsuite?
Comment on attachment 8524065 [details] [diff] [review]
When a third-party enters a room, stop displaying the ToS and privacy links in the Loop panel.

Approval Request Comment

requirement for Loop Rooms support for Aurora/35
On m-c; testing with rooms server changes now live in production

[String/UUID change made/needed]: none
Attachment #8524065 - Flags: approval-mozilla-aurora?
Attachment #8524065 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1113640
ToS & Privacy are now only shown on first time use. They no longer get shown later, hence clearing the in-testsuite request.
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.