Closed Bug 1084973 Opened 5 years ago Closed 5 years ago

Port |Bug 1031352 - share the logic for determining what MSVC DLLs to package| to im, mail, and suite

Categories

(Thunderbird :: Build Config, defect)

All
Windows 8.1
defect
Not set

Tracking

(thunderbird36 fixed)

RESOLVED FIXED
Thunderbird 37.0
Tracking Status
thunderbird36 --- fixed

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1031352 changes some package-manifest.in stuff that we should change.
Summary: Port |Bug 1031352 - share the logic for determining what MSVC DLLs to package| to im and mail → Port |Bug 1031352 - share the logic for determining what MSVC DLLs to package| to im, mail, and suite
This patch depends on the changes in bug 1084970. I have not yet tested it.
Attachment #8507372 - Flags: review?
Attachment #8507372 - Flags: review?(Pidgeot18)
Attachment #8507372 - Flags: review?
Attachment #8507372 - Flags: review+
Comment on attachment 8507372 [details] [diff] [review]
Port changes to im, mail, and suite

Review of attachment 8507372 [details] [diff] [review]:
-----------------------------------------------------------------

I could have sworn I reviewed a patch for this some time ago...
Attachment #8507372 - Flags: review?(Pidgeot18) → review+
Comment on attachment 8507372 [details] [diff] [review]
Port changes to im, mail, and suite

Review of attachment 8507372 [details] [diff] [review]:
-----------------------------------------------------------------

Justin, can you take a look at the suite part of this? Thanks!

Joshua, I couldn't find any bugs porting this over (and it's not in checkin-needed), but possibly it was filed by someone else at some point...
Attachment #8507372 - Flags: review?(bugspam.Callek)
Attachment #8507372 - Flags: review?(bugspam.Callek) → review+
Keywords: checkin-needed
This has bitrotted in suite/.
Flags: needinfo?(bugspam.Callek)
Keywords: checkin-needed
This doesn't need any info from Callek, it just needs a new version of the patch to be uploaded. I have it (on one of my computers...)
Flags: needinfo?(bugspam.Callek)
Landed an unbitrotted version as https://hg.mozilla.org/comm-central/rev/82c2f74c26cb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
Joshua backed this out: http://hg.mozilla.org/comm-central/rev/a16e7da5b110 for possible xpcshell failures on Windows.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Could this have caused bug 1097748?
Ed, possibly: we were seeing that on Instantbird as well.

I need to re-test this patch and see what's going on.
(In reply to Patrick Cloke [:clokep] from comment #9)
> Ed, possibly: we were seeing that on Instantbird as well.
> 
> I need to re-test this patch and see what's going on.

Maybe this might be helpful?
http://dxr.mozilla.org/comm-central/source/mozilla/browser/installer/Makefile.in#73
Depends on: 1097748
This also adds the Makefile.in changes. I forgot to add tests on my last tryserver push, so https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=faedda5888f3 is the correct push to look at. This looks as broken as trunk (but not more so!)
Attachment #8507372 - Attachment is obsolete: true
Attachment #8536113 - Flags: review?(Pidgeot18)
Attachment #8536113 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/79c940c5d453
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Component: Other → Build Config
Product: Instantbird → Thunderbird
Resolution: --- → FIXED
Target Milestone: 1.6 → Thunderbird 37.0
Version: trunk → Trunk
Pushed to beta https://hg.mozilla.org/releases/comm-beta/rev/341f30c61086 a=rkent based on IRC discussions with jcranmer.
You need to log in before you can comment on or make changes to this bug.