1084973 - Port |Bug 1031352 - share the logic for determining what MSVC DLLs to package| to im, mail, and suite

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Patrick Cloke [:clokep]]

Bug 1031352 changes some package-manifest.in stuff that we should change.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Port changes to im, mail, and suite

This patch depends on the changes in bug 1084970. I have not yet tested it.

Comment 2

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8507372 [details] [diff] [review]
Port changes to im, mail, and suite

Review of attachment 8507372 [details] [diff] [review]:
-----------------------------------------------------------------

I could have sworn I reviewed a patch for this some time ago...

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8507372 [details] [diff] [review]
Port changes to im, mail, and suite

Review of attachment 8507372 [details] [diff] [review]:
-----------------------------------------------------------------

Justin, can you take a look at the suite part of this? Thanks!

Joshua, I couldn't find any bugs porting this over (and it's not in checkin-needed), but possibly it was filed by someone else at some point...

Comment 4

[aleth [:aleth]]

This has bitrotted in suite/.

Comment 5

[Patrick Cloke [:clokep]]

This doesn't need any info from Callek, it just needs a new version of the patch to be uploaded. I have it (on one of my computers...)

Comment 6

[Patrick Cloke [:clokep]]

Landed an unbitrotted version as https://hg.mozilla.org/comm-central/rev/82c2f74c26cb

Comment 7

[Patrick Cloke [:clokep]]

Joshua backed this out: http://hg.mozilla.org/comm-central/rev/a16e7da5b110 for possible xpcshell failures on Windows.

Comment 8

[Ed Morley [:emorley]]

Could this have caused bug 1097748?

Comment 9

[Patrick Cloke [:clokep]]

Ed, possibly: we were seeing that on Instantbird as well.

I need to re-test this patch and see what's going on.

Comment 10

[Joshua Cranmer [:jcranmer]]

(In reply to Patrick Cloke [:clokep] from comment #9)
> Ed, possibly: we were seeing that on Instantbird as well.
> 
> I need to re-test this patch and see what's going on.

Maybe this might be helpful?
http://dxr.mozilla.org/comm-central/source/mozilla/browser/installer/Makefile.in#73

Comment 11

[Patrick Cloke [:clokep]]

Pushed a new version to try: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=bc1af26ab4f9

Comment 12

[Patrick Cloke [:clokep]]

Attachment: Port changes to im, mail, and suite v2

This also adds the Makefile.in changes. I forgot to add tests on my last tryserver push, so https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=faedda5888f3 is the correct push to look at. This looks as broken as trunk (but not more so!)

Comment 13

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/79c940c5d453

Comment 14

[Kent James (:rkent)]

Pushed to beta https://hg.mozilla.org/releases/comm-beta/rev/341f30c61086 a=rkent based on IRC discussions with jcranmer.