108794 - Alert dialogs appear when creating new bookmark folder

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Chris Lyon]

Using build 2001110603 on Win2K

Steps to Reproduce:
1. Right click on Personal Toolbar and select New Folder
2. Press Ok in the Create New Folder dialog

Results:
A dialog labelled Alert with the following text: 
appears: "NC:PersonalToolbarFolder"
When hitting OK, another identical dialog appears.
The folder then gets created.

Comment 1

[Chris Lyon]

Sorry, this is not limited to the Personal Toolbar, similar alerts appear 
wherever you create a folder (sidebar, manage bookmarks window)

Comment 2

[André Dahlqvist]

Verifying with 2001-11-06-12 on Linux.

Comment 3

[André Dahlqvist]

Raising severity since this is too ugly to be included in 0.9.6.

Comment 4

[Chris Lyon]

Changing OS to All besed on André's comments.

Comment 5

[André Dahlqvist]

I've narrowed it down somewhat.

2001-11-01-21   OK
2001-11-05-22   BROKEN

There aren't any tar.gz builds inbetween these dates, so I can't narrow it down
further.

Comment 6

[Chris Lyon]

*** Bug 109896 has been marked as a duplicate of this bug. ***

Comment 7

[Alex Vincent [:WeirdAl]]

*** Bug 110003 has been marked as a duplicate of this bug. ***

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

last of the bookmarks bugs...

Comment 9

[Chris Lyon]

*** Bug 111059 has been marked as a duplicate of this bug. ***

Comment 10

[Chris Lyon]

*** Bug 111547 has been marked as a duplicate of this bug. ***

Comment 11

[Alfonso Martinez]

*** Bug 111705 has been marked as a duplicate of this bug. ***

Comment 12

[xyzzy]

OK, who checked in debug code?  ;)

I get two alerts doing this, the first seems to be the "current" URL entry, the
second seems to be the parent ID within the tree.  This is also happening for
New Separator, and sounds similar to bug 110572.

Comment 13

[Neil Pryde]

These two alerts are located in bookmarksOverlay.js:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksOverlay.js#766
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/bookmarksOverlay.js#783

These lines are inserted by Blaky Blake.

-Neil.

Comment 14

[Neil Pryde]

See also:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/components/bookmarks/resources/bookmarksOverlay.js
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/xpfe/components/bookmarks/resources&command=DIFF_FRAMESET&file=bookmarksOverlay.js&rev2=1.29&rev1=1.28

Blake, please remove them a.s.a.p.

Thanks you,
-Neil.

Comment 15

[Neil Pryde]

Aha, bug 110572 will also be fixed when these alerts are removed.

Comment 16

[Neil Pryde]

"This is also happening for New Separator"

bookmarks.xul makes use of the same overlay file, bookmarksOverlay.js so this
will also be fixed after removing the alerts.

-Neil.

Comment 17

[Paul Chen]

this fix was checked in as part of fix for 102311, marking fixed

Comment 18

[Chris Lyon]

*** Bug 112676 has been marked as a duplicate of this bug. ***

Comment 19

[Chris Lyon]

*** Bug 114033 has been marked as a duplicate of this bug. ***

Comment 20

[André Dahlqvist]

Verified fixed with a CVS build from 2002-03-20-21 on Linux.