1089010 - Can open utility tray and settings app while SIM PIN dialog is open

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

STR:

1.) Enabled SIM PIN on sim card
2.) Open SIM PIN dialog (one way is to lock then unlock the phone)
3.) Pull down utility tray
4.) Click on Settings Icon

Expected result:
Either utility tray should not be opened at all, or the user should not be able to open settings app

Actual result:
The settings app opens in the background underneath the SIM PIN dialog, which can change the color of the statusbar and look really janky.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:
Not sure if it's worth blocking on this at this point, but this looks pretty bad to the user.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Rob, what should happen here? Should the user be able to open the utility tray when the SIM PIN dialog is up? Should the settings icon be clickable? Should the statusbar even show at all?

Comment 3

[Gregor Wagner [:gwagner]]

(In reply to Michael Henretty [:mhenretty] from comment #0)
> STR:
> 
> 1.) Enabled SIM PIN on sim card
> 2.) Open SIM PIN dialog (one way is to lock then unlock the phone)

Why does the SIM PIN dialog show up when we lock and unlock the phone? That seems a bug.

Comment 4

[Rob MacDonald [:robmac]]

(In reply to Michael Henretty [:mhenretty] from comment #2)
> Rob, what should happen here? Should the user be able to open the utility
> tray when the SIM PIN dialog is up? Should the settings icon be clickable?
> Should the statusbar even show at all?

The standard behaviour from dialogs is to allow the user to open the utility tray. The only possible exception might be a system-wide blocking dialog. Since this doesn't apply in the SIM PIN case, the user should be able to open the utility tray and settings.

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

I was able to reproduce this on today's 2.1 Flame(319mb)(KK)(Full Flash)

Flame 2.1 

Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

I was able to open settings behind the SIM PIN screen which change the color of the status bar. The Rocketbar also appears and the user can perform a search.

Comment 6

[Manuel Casas Barrado [:mancas]]

Attachment: Sim pin dialog is closed when Settings App is opened

Hey etienne, please take a look at the patch and let me know if you think is better to make a different approach here.

Thanks!

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 8512492 [details] [review]
Sim pin dialog is closed when Settings App is opened

lgtm, redirecting the review to Alive though, so that you guys can sync up and avoid conflicts with bug 1062819.

If this gets 2.1+ we might want to land it first to ease the uplift.

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8512492 [details] [review]
Sim pin dialog is closed when Settings App is opened

LGTM

Comment 9

[Candice Serran (:cserran)]

broken functionality and poor user experience

Comment 10

[Kevin Grandon :kgrandon]

Since this is a blocker, we're reaching the deadline, and it has an R+, going to press the merge button.

In master: https://github.com/mozilla-b2g/gaia/commit/69786521f96990e12f39c71eb9a5b5ebc13fa88f

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8512492 [details] [review]
Sim pin dialog is closed when Settings App is opened

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
not a regression

[User impact] if declined:
Really strange UX when user has sim pin enabled.

[Testing completed]:
I assume the developer and reviewers manually tested this. There is also an added unit test.

[Risk to taking this patch] (and alternatives if risky):
Looking at the patch, the code is pretty isolated to the sim lock dialog. The risk is low.

[String changes made]: none.

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.2.

Result: When the user pulls down the utility tray from the SIM PIN dialog and selects the settings icon, Settings app appears.

Device: Flame 2.2 (319mb, KK, Full Flash)
BuildID: 20141105160209
Gaia: 7918024c737c4570cacd784f267e28737ae05dea
Gecko: 2114ef80f6ae
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2) 
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

However, there is an unexpected animation shown. Filed a bug 1095082.

================================================
Leaving verifyme for 2.1 uplift.

Comment 13

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8512492 [details] [review]
Sim pin dialog is closed when Settings App is opened

Removing approval-2.1 because this patch is for master. I'm going to upload a new one for v2.1

Comment 14

[Manuel Casas Barrado [:mancas]]

Attachment: Patch for v2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
not a regression

[User impact] if declined:
Really strange UX when user has sim pin enabled.

[Testing completed]:
I assume the developer and reviewers manually tested this. There is also an added unit test.

[Risk to taking this patch] (and alternatives if risky):
Looking at the patch, the code is pretty isolated to the sim lock dialog. The risk is low.

[String changes made]: none.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/db056d03e6b8690e101645acb52584af7728550d

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Either this or bug 1089528 broke Gip tests on b2g34:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=29414&repo=mozilla-b2g34_v2_1

Comment 17

[Ryan VanderMeulen [:RyanVM]]

It was bug 1089528.

Comment 18

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.1.

Result: When the user pulls down the utility tray from the SIM PIN dialog and selects the settings icon, Settings app appears.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141110001201
Gaia: 0ec1925fc37b7c71d129ae44e42516a0cfb013c4
Gecko: 97487a2d1ee6
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0