1105454 - Can open utility tray and settings app while SIM PIN dialog is open

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

+++ This bug was initially created as a clone of Bug #1089010 +++

This bug is happening on master and v2.1 again, so rather than re-opening bug 1089010, I just cloned it here. I'm going to try and find the regressing patch.

STR:

1.) Enabled SIM PIN on sim card
2.) Open SIM PIN dialog (one way is to lock then unlock the phone)
3.) Pull down utility tray
4.) Click on Settings Icon

Expected result:
Either utility tray should not be opened at all, or the user should not be able to open settings app

Actual result:
The settings app opens in the background underneath the SIM PIN dialog, which can change the color of the statusbar and look really janky.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Yup, indeed this was broken when bug 1062819 landed. I think bug 1062819 just didn't port the fix from bug 1089010 in [1]. I can look into this.

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Just to clarify, this is NOT happening on 2.1 as my description suggests. Let's block on this for 2.2.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Uh, my fault.. lemme know if you need my help

Comment 4

[Gregor Wagner [:gwagner]]

Is this still happening?

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Gregor Wagner [:gwagner] from comment #4)
> Is this still happening?

Yes, this is still happening.

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Attachment: [Gaia PR] backport bug 1089010

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8536984 [details] [review]
[Gaia PR] backport bug 1089010

I wonder if we have the same issue if dialer/message is trying to launch themselves by mozApps.getSelf when SIM PIN dialog is opened :/

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #7)
> Comment on attachment 8536984 [details] [review]
> [Gaia PR] backport bug 1089010
> 
> I wonder if we have the same issue if dialer/message is trying to launch
> themselves by mozApps.getSelf when SIM PIN dialog is opened :/

We might, but in this case it is ok for the SIM PIN dialog to stay opened, since both of those apps will open the SIM PIN anyway if the SIM is locked.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/d22dfece04fc00457e8369c660c11f945b088d2f

Comment 10

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2.

Result: The Settings app appears when the user selects the settings icon from the utility tray, instead of opening underneath the SIM PIN screen. However, there is a couple seconds of delay, and the animation issue still exists as filed in bug 1095082.

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141218040201
Gaia: 58734e8a48157f99d5b733412b600c2e04c954fe
Gecko: 5c7a6294b82a
Gonk: e5c6b275d77ca95fb0f2051c3d2242e6e0d0e442
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0