1089186 - Error: NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative Source file: chrome://communicator/content/history/treeView.js

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Philip Chee]

(In reply to [e-mail] from Bug 1087942 comment #4)
> (In reply to Philip Chee from comment #3)
>> Opening the History window do something then close the window:
>> 
>> Fri Oct 24 2014 23:54:39
>> Error: NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a
>> WrappedNative
>> Source file: chrome://communicator/content/history/treeView.js
>> Line: 1019
> 
> Unrelated. Kairo missed the change as part of bug 543444. places/treeView.js
> is correct.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 fix setTree()

> +          try {
> +            this._result.removeObserver(this);
> +          }
> +          catch(ex) { }
If I don't wrap this in a try/catch block I get:

Error: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]
Source file: chrome://communicator/content/history/treeView.js
Line: 1019

What am I doing wrong?

Comment 2

[[e-mail]]

Not sure offhand... we should be adding the observer in tree.xml line 102.

Comment 3

[[e-mail]]

Comment on attachment 8511555 [details] [diff] [review]
Patch v1.0 fix setTree()

I don't know, I don't see any errors without the try/catch.

Comment 4

[Philip Chee]

Attachment: Patch v2.0 Remove Observer within the view itself

> Error: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsINavHistoryResult.removeObserver]
> Source file: chrome://communicator/content/history/treeView.js
Digging through firefox places history I found a similar problem in Firefox.
This v2 patch combines the relevant parts of Bug 553334 and Bug 543444.

> +          // Observer removal is done within the view itself. When the tree
> +          // goes away, treeboxobject calls view.setTree(null), which then
> +          // calls removeObserver.

> I don't know, I don't see any errors without the try/catch.
Happens in safe mode too.

Comment 5

[Philip Chee]

Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/ca2967aceeb1
comm-central changeset ca2967aceeb1

Comment 6

[Ian Neal]

Comment on attachment 8520027 [details] [diff] [review]
Patch v2.0 Remove Observer within the view itself

[Triage Comment]

Comment 7

[Philip Chee]

http://hg.mozilla.org/releases/comm-release/rev/d891cfe1516a