1089423 - crash in java.lang.IllegalStateException: at android.media.MediaCodec.dequeueInputBuffer(Native Method)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-faf177c8-006c-4b74-86d5-628672141025.
=============================================================

java.lang.IllegalStateException
	at android.media.MediaCodec.dequeueInputBuffer(Native Method)
	at dalvik.system.NativeStart.run(Native Method)
	at dalvik.system.NativeStart.run(Native Method)
Android CPU ABI

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Catch MediaCodec exceptions

This is kind of a band aid until we start using generated JNI bindings which will hopefully make all of this a little nicer.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8512148 [details] [diff] [review]
Catch MediaCodec exceptions

Review of attachment 8512148 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/GeneratedSDKWrappers.cpp
@@ +163,5 @@
>      int32_t temp = env->CallIntMethod(wrapped_obj, jDequeueInputBuffer, a0);
> +    if (env->ExceptionCheck()) {
> +        env->ExceptionClear();
> +        env->PopLocalFrame(nullptr);
> +        return -255;

magic numbers

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Gian-Carlo Pascutto [:gcp] from comment #2)
> Comment on attachment 8512148 [details] [diff] [review]
> Catch MediaCodec exceptions
> 
> Review of attachment 8512148 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: widget/android/GeneratedSDKWrappers.cpp
> @@ +163,5 @@
> >      int32_t temp = env->CallIntMethod(wrapped_obj, jDequeueInputBuffer, a0);
> > +    if (env->ExceptionCheck()) {
> > +        env->ExceptionClear();
> > +        env->PopLocalFrame(nullptr);
> > +        return -255;
> 
> magic numbers

Yeah, I'll fix, thanks.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbc43d1d8691

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

The patch fixes exception handling for several calls, so I marked the others as dups of this one.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bbc43d1d8691

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8512148 [details] [diff] [review]
Catch MediaCodec exceptions

Approval Request Comment
[Feature/regressing bug #]: bug 1014614
[User impact if declined]: Crashes, assuming bug 1014614 is uplifted
[Describe test coverage new/current, TBPL]: Nightly for a week
[Risks and why]: Low, only catches exceptions
[String/UUID change made/needed]: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Looks like snorp landed this on Aurora and forgot to mark the bug.

https://hg.mozilla.org/releases/mozilla-aurora/rev/ce9444649361

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=5811de401315

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

Relanded on beta
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?changeset=53692e16c248

Comment 14

[u279076]

As mentioned in bug 1089261 comment 3, there's been 0 crashes reported in the last week. Marking this bug verified fixed based on crash-stats.