Closed
Bug 1089656
Opened 11 years ago
Closed 10 years ago
Move credits.html outside of include.js
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
2015-03-17
People
(Reporter: mat, Assigned: kngo)
References
Details
(Keywords: perf)
credits.html is 16K of just names and links. We should either:
- Load the whole template from the network, not serve it from fireplace
or
- Load the list using an API, keeping the template extra-small in fireplace
This would reduce the size of include.js, improving performance.
Updated•11 years ago
|
Priority: -- → P4
Comment 1•10 years ago
|
||
Note: The list of names/links is generated via script[1] from github. This could be moved to the backend or other and run periodically to keep it up to date.
[1] https://github.com/mozilla/fireplace/blob/master/bin/getnames.js
| Assignee | ||
Comment 2•10 years ago
|
||
I removed it entirely for now as it doesn't seem like an important page nor are we linking to it from anywhere at the moment: https://github.com/mozilla/fireplace/commit/1e6c94963840f2ee20569b4a59ec552d53cb0bd2
Assignee: nobody → kngo
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-03-17
| Assignee | ||
Comment 3•10 years ago
|
||
+ I don't think anyone has time to make an endpoint out of it.
Comment 4•10 years ago
|
||
Please add some STRs to this bug or mark it as [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•