Consider moving /nominate javascript + template code outside of fireplace

RESOLVED FIXED in 2014-11-11

Status

Marketplace
Consumer Pages
P4
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mat, Assigned: mat)

Tracking

({perf})

2014-11-11
x86_64
Linux
Points:
---
Dependency tree / graph

Details

(Whiteboard: [qa-])

(Assignee)

Description

4 years ago
/nominate lives in fireplace, which means its template and javascript code are inlined in include.js. That represents (before minification+gzip):

4.0K	nominate.html (twice that size once inlined in include.js, lots of HTML + conditions & loops in that template)
8.0K	/media/js/views/nominate.js
4.0K	/media/js/views/nominate.styl

We would reduce the size of include.{js,css} by having that view served outside fireplace somehow. It's non-essential to fireplace, I don't even know how to reach it from the homepage.
(Assignee)

Updated

4 years ago
Keywords: perf

Updated

4 years ago
Priority: -- → P4
Scott says we can drop this page completely if we like.
(Assignee)

Comment 2

4 years ago
Awesome. Let's do that.
Assignee: nobody → mpillard
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Fixed in https://github.com/mozilla/fireplace/commit/c49cebd2cd7d5297dac67773174cee35b5005293
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2014-11-11

Comment 4

4 years ago
We can't remove the page; the link is out there and I don't want people landing on a broken page. If there's a way to keep the page without too much trouble that would be great. Otherwise, we need to have a redirect. Scott can put up a blog post we can redirect to.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Amy Tsay [:amyt] from comment #4)
> We can't remove the page; the link is out there and I don't want people
> landing on a broken page. If there's a way to keep the page without too much
> trouble that would be great. Otherwise, we need to have a redirect. Scott
> can put up a blog post we can redirect to.

Amy, on average how many submissions do we get right now?

––

It sounds like it shouldn't, but if it has to go down, redirect to https://wiki.mozilla.org/Marketplace/Contributing/Apps/CommunityCuration

But that still doesn't say how to nominate apps.

Amy, what is the expected route for folks to nominate featured apps to the Marketplace? Is this Nominate page it? Or emailing Scott? It's at least unclear from the Marketplace homepage how to do that. So I'm assuming on the newsletters it's more clear.
Flags: needinfo?(atsay)

Comment 6

4 years ago
We get a dozen or so per month. You're right, it isn't clear, partly because v1 of the program was invite-only. Let's wait for Scott to write the blog post, which will clarify things, and redirect to that instead.

Also want to give Scott a chance to chime in on whether he wants to keep the page or consolidate everything to the as-yet-unwritten blog post.
Flags: needinfo?(atsay)

Comment 7

4 years ago
The number of app noms we receive each month varies, but we got 14 in October. 

If we take down the Nomination page, I can write a blog post that essentially conveys the same info and asks folks to send app nominations to editor@mozilla.com, which comes directly to me. We can also link to the wiki page form the blog post.
(Assignee)

Comment 8

4 years ago
Scott: please write the blog post then. Not having this page means less code to maintain and less content to download (since we bundle all consumer pages together) so it improves Marketplace performance.

When the post is up, give the URL here and we'll set up the redirect.
Flags: needinfo?(sdevaney)

Comment 9

4 years ago
Cool. I'll have something written up by the end of this week.
Flags: needinfo?(sdevaney)
(Assignee)

Updated

4 years ago
Depends on: 1096495
(Assignee)

Comment 11

4 years ago
The redirection was added to dev/stage in bug 1096495, it should go in production with the next push.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.