Closed
Bug 1090161
Opened 10 years ago
Closed 10 years ago
WebviewOverlay is only used for Authenticate component so we can load this lazily within Wizard
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
(Whiteboard: [mobile app][Loop not in v1.1])
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Whiteboard: [mobile app]
|
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
José wait for reviewing this until we know if we can remove all this code to use window.open('') or we have to keep current approach. We are talking about it in the meeting today
Attachment #8513373 -
Flags: review?(josea.olivera)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8513373 [details]
Github pull request
LGTM. r=me
Thanks Cristian!
Attachment #8513373 -
Flags: review?(josea.olivera) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Merged in master:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/f87627990247f6a1c35d898552e38d960a583a2a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Whiteboard: [mobile app] → [mobile app][Loop not in v1.1]
|
||
Comment 5•10 years ago
|
||
Tested. Terms of service are shown
Flame
user
v2.0
Gecko-05f9775
Gaia-d3e4da3
Loop version: master , dd4862e
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•